Commit graph

286 commits

Author SHA1 Message Date
Thomas Arnhold
89003e9bd8 loplugin: unused variables
Change-Id: I63553a09eec81e5ae28aa79ee1d3281053b23d06
2013-02-25 03:14:01 +01:00
Tor Lillqvist
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
Markus Mohrhard
fdf59cc3b5 coverity: fix memory leak
Change-Id: Ibe595adf52c6880ce4ecdb469b89074fcdc0c16b
2013-02-18 01:58:45 +01:00
Markus Mohrhard
7511f63177 coverity: fix memory leak
Change-Id: I991f0e90abfa6e772f43afd8b8aa69d3b5ce4fa0
2013-02-18 01:58:45 +01:00
Markus Mohrhard
856a3a09a0 coverity: fix memory leak
Change-Id: I12ad99f3179ee8ef9e0322823685eb2bf337fc22
2013-02-18 01:58:45 +01:00
Markus Mohrhard
655c7b5260 coverity: fix memory leak
Change-Id: I9fa99a3f2a5de644961cbf8b9951e1c1246d97cb
2013-02-18 01:58:44 +01:00
Markus Mohrhard
e94d1bb928 coverity: no need to use a pointer here
Change-Id: I83b986c6f2f8670c2c0f6caa754fd3567c7488a8
2013-02-18 01:58:44 +01:00
Markus Mohrhard
ae3138859e coverity: new[] vs delete mismatch
Change-Id: Ic10d900b092c37ee627d3911200ebd29106cc360
2013-02-18 01:58:44 +01:00
Markus Mohrhard
7ae107542c coverity: fix memory leak
Change-Id: Iaa27244b1829bfe5a26c9352da6a8819d3037ccd
2013-02-18 01:58:40 +01:00
Markus Mohrhard
57d89a758a coverity: fix memory leak
Change-Id: I4f31cd0848e8a521bcbcb97fc1abad159745a501
2013-02-18 01:58:40 +01:00
Markus Mohrhard
0bb0c37820 coverity: fix memory leak
Change-Id: If25fd29f4788af37b4ff8ef95568751ddf176f51
2013-02-18 01:58:39 +01:00
Caolán McNamara
8f9da3e7d0 coverity#738975 Use after free
also...
 coverity#738973 Use after free
 coverity#738974 Use after free

Change-Id: Iecf2075372d76cded86b92e49225337b95f5ffd1
2013-02-16 23:31:31 +00:00
Michael Stahl
fc81393c7f gbuild: remove various pointless calls that don't add anything
Change-Id: I7eccac4fa8890c2873c6bbd7f8f5bf5b0dd006d2
2013-01-26 22:20:07 +01:00
Michael Stahl
a53586f4ef gbuild: do not copy boost headers around
- do not use gb_UnpackedTarball_copy_header_files for boost
- adapt the optimization in concat-deps.c for new path
- use boost_headers in all LinkTargets that require it
- add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus

Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-26 22:20:06 +01:00
Julien Nabet
70c88fc75f Some cppcheck cleaning
Change-Id: Iab4ff990f71321b75f69bc61a5cda728956ca85c
2013-01-26 21:27:30 +01:00
Julien Nabet
8ab3715d8e Again Fix others Consecutive return, break
Change-Id: I67a453bb09b794c996f5f02a065abe8cef6ca3b6
2013-01-19 17:16:33 +01:00
Julien Nabet
259af2832e Fix Consecutive return, break
Change-Id: I7e7586f430b4c33d4bdc786622fcf3680021d517
2013-01-19 17:16:33 +01:00
Matteo Casalin
a4c7ded1fd Cleanup: #include <tools/gen.hxx>
Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530
Reviewed-on: https://gerrit.libreoffice.org/1484
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:14:57 +00:00
Radu Ioan
3b1da9e650 fdo#39440 - cppcheck cleanliness
removed some cppcheck warning

Change-Id: I81963001e4737c583764b07bea9abf59a61dead7
Reviewed-on: https://gerrit.libreoffice.org/1518
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-12-30 23:32:26 +00:00
Peter Foley
b92a0d9208 convert icu to gbuild and add to tail_build
Change-Id: Id7d8bc05b1393cc2bae4a531c8a47f62df24b1d6
Reviewed-on: https://gerrit.libreoffice.org/1488
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2012-12-27 15:53:39 +00:00
Marcos Paulo de Souza
e6ba54ceb8 Remove (RTL_CONSTASCII_USTRINGPARAM from lotuswordpro
Change-Id: I4912ffc42edbfa1456835e61163812c371eb14c6
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com
Reviewed-on: https://gerrit.libreoffice.org/1293
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2012-12-11 12:19:16 +00:00
Michael Stahl
1658e4efac RepositoryExternal.mk: clean up awful icudata/icui18n duplication
Change-Id: Ic4794d9a908b60220a4a849ff263eaa08776550c
2012-12-02 20:58:32 +01:00
Eike Rathke
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
jailletc36
dda1172659 cppCheck: Various clean-up
xfdrawstyle.cxx: correct a copy/paste typo in constructor
number.cxx: remove an unused variable
inftxt.hxx: redundant assignment (pWrongList is assigned twice)

Change-Id: I148e23272ffa169ef16052c475e5f24a87383e5b
Signed-off-by: jailletc36 <christophe.jaillet@wanadoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/983
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2012-11-06 14:14:34 +00:00
Caolán McNamara
c2913591d8 rework filters test to squeeze through extra flags
that are needed to load .odt, .sxw etc files, and
add a regression test for CVE-2012-4233

Change-Id: Ie178725ded3d76942030d12f23074de519cf62de
2012-11-01 13:14:09 +00:00
Marcos Paulo de Souza
24e66143ed Remove useless code
These macros was never defined:
	KANJI
	AMIKAKE
	BORDER_BMP
	SMARTEXT
	JAPANESE_ENABLED
	BENUTIL_SUPPORT

So, these code inside these ifdefs was never executed. Remove all this.
Also in this commit, remove some odd comments and commented code.

Change-Id: Idd4991d06d1c879e64f07875241a8acfa35695d0
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/777
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2012-10-09 21:34:49 +00:00
Marcos Paulo de Souza
02a7bf5560 Remove not used macros from lotusworkpro
Change-Id: I0c5b52030e9837f5ee9aa6258b6ccb16dd3f03c0
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/749
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2012-10-02 20:37:57 +00:00
Arnaud Versini
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
Tor Lillqvist
eef8ae7c3f Prefixify lotuswordpro
Change-Id: I9b30477d94995adef51a76bdf298d1815f511e9e
2012-10-01 13:23:46 +03:00
Michael Stahl
5032dc0fc3 gbuild: invert handling of standard system libraries:
Always link in gb_STDLIBS, except when the library explicitly opts out
with gb_LinkTarget_disable_standard_system_libs.

Change-Id: I489a99114fbfa46d0421a27cf6c7b899dc268a4a
2012-09-28 16:49:08 +02:00
Michael Stahl
b85c349783 gbuild: replace direct gb_STDLIBS use with ...
... new gb_LinkTarget_add_standard_system_libs

Change-Id: Ib2bc843098db3d8c6822b45a3d21724e67f57d69
2012-09-28 16:49:06 +02:00
Michael Stahl
2e677c3981 gbuild: split uwinapi out of gb_STDLIBS
Change-Id: I53316e0b9369d806197bccb42cf22d3497af43e7
2012-09-28 16:49:05 +02:00
Stephan Bergmann
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-19 13:16:38 +02:00
Noel Grandin
369e3fdcda fdo#46808, Adapt i18n::LocaleData UNO service to new style
The implementation of the LocaleData implements the optional XLocaleData4,
so rather than creating a new interface for the new-style service, we simply
make the service implement XLocaleData4, which in turn implements
XLocaleData3, XLocaleData2, XLocaleData.

Change-Id: I3e9a48b031be6b2aa5e04b376b3940b942add85a
2012-09-17 14:28:21 +02:00
Julien Nabet
64787ead29 Remove unused variable
Should we use vector for m_pListLevels and use iterator then?
Where does the "10" come from?

Change-Id: I2c0d569db48226149645f039ca11633ae2b6c7a2
2012-09-15 14:07:54 +02:00
Stephan Bergmann
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00
Stephan Bergmann
24530c684a -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: Ie83cd8392363800bcb1de641b537efdab2910ddd
2012-08-31 09:04:18 +02:00
Thomas Arnhold
7910718259 Remove unused code: those classes are unused
Change-Id: Ibf41655d40c9534629bbb0dd5ae600791b42922d
2012-08-01 18:34:46 +02:00
Caolán McNamara
69bb7c732d regression test for CVE-2012-1770
Change-Id: I2c51a128437913c3bb0bc7a59774ff117603dc82
2012-07-26 16:38:05 +01:00
Julien Nabet
00ae1cec08 Change form of checking self-assignment + cleaning before assigning
Change-Id: Idc8e8445b870805b99d2b9434cf1f752c63cc6a0
2012-07-16 22:54:38 +02:00
Julien Nabet
528b406bc2 Check for assignment to self for =operator
Change-Id: I88369c1b0c6f261e8350d196b56acdc8f8f61ce8
2012-07-14 19:58:57 +02:00
Julien Nabet
962d78294b Perform initalization in initialization list
Change-Id: I103af00b8d4f057ecf427914d35aaa02fcf452ae
2012-07-14 00:46:46 +02:00
Caolán McNamara
bccf34c19a ditch String::CreateFromAscii
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
2012-07-03 21:24:35 +01:00
Michael Meeks
fdda178d88 targetted improvement of UNO API includes / usage 2012-07-02 14:43:34 +01:00
Thomas Arnhold
8e1bffe7ff Remove include guards
Change-Id: Ib4ba76d0083e5bd75cc589a55318089c004f591f
2012-06-29 15:59:53 +02:00
Thomas Arnhold
6fcac7dfc4 Remove unused include files
Those never get included at any point in the code.

Change-Id: I17736e005635b9e57759cfc95176a99e7c5e8988
2012-06-27 13:34:23 +02:00
Thomas Arnhold
d8fd071886 Remove commented out code
Change-Id: Idbd7ddb3f0a65454c4a82cd421298bee30184a4d
2012-06-27 13:32:36 +02:00
Takeshi Abe
4ba4b87042 removed unused forward declarations of class
except moving CGMBitmapDescriptor into filter/source/graphicfilter/icgm/outact.hxx

Change-Id: Ib11d1c907b4c52c6e0f261b20992659b52f4c136
2012-06-26 10:35:23 +09:00
Takeshi Abe
eb0497307b nuke dead code
Change-Id: Id9920ea7b82ea178e904f78bbd41ffc434813e0b
2012-06-07 23:03:11 +09:00
Thorsten Behrens
fcc31f1749 Targeted string re-work for lotuswordpro filter
Also cleaned up commented code, and a few extraneous temporaries
2012-06-01 17:54:29 +02:00