Commit graph

359323 commits

Author SHA1 Message Date
Noel Grandin
2922a967a1 java: Avoid naming non-fields with the prefix m_
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
Noel Grandin
188af1e56e no need to instantiate an object to get it's class
Change-Id: I7b1f8d4621a3db9094bb61753218db3646c33e34
2014-08-20 10:35:52 +02:00
Noel Grandin
ccbb51ad96 use correct loop index variable
Change-Id: I92531f8fc96c0cb0ca944a7dd50c4fe4ea740b37
2014-08-20 10:35:52 +02:00
Noel Grandin
619dc5d4c8 remove some dead Java code
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-20 10:35:52 +02:00
Noel Grandin
252ed1708a double-checked locking is not thread-safe in Java
found by PMD

Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-20 10:35:51 +02:00
Szymon Kłos
a240a78cc7 Fixed size of 'formula' dialog in Calc
Fixed:
1. Open Calc
2. Open formula dialog
3. Choose AMORDEGRC function or other with >= 4 params
Edit field is covered by other controls

Change-Id: Ie14ff91a17373e11bc8ef6477f4f22c0ea4570c3
Reviewed-on: https://gerrit.libreoffice.org/11035
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 03:12:31 -05:00
David Tardon
34d6e7790f avoid potential null dereference
Change-Id: I2236a18608ffa9481c30088044f34e1a3372dd11
2014-08-20 10:08:49 +02:00
David Tardon
8c536baf20 do not use obsolete OSL_VERIFY macro
Change-Id: I8efdd4933d3e47c5e086dc4a4685110390d6b6e8
2014-08-20 10:08:49 +02:00
David Tardon
238d6ac878 this assert does not make sense
... as the code apparently can work even if xFormatTypes is empty.

Change-Id: I6b733b9b31329d4fafc745bc23d0f555286950e6
2014-08-20 10:08:49 +02:00
Caolán McNamara
0a42632a74 empty Reference
valgrind + bff

Change-Id: Id3c039a46dec5d2d4a4642dfb53d23a76972dde2
2014-08-20 08:57:06 +01:00
Caolán McNamara
e324771991 empty m_aStates
valgrind + bff

Change-Id: I3bd526b7ebf0f4fce5d0c7054809e0dc2908e73f
2014-08-20 08:43:09 +01:00
rbuj
37c49c3058 jurt: Throwable.getCause() instead of Throwable.getTargetException()
As of the JDK 1.4, Throwable.getCause() is the preferred method for getting thrown target exception.

Change-Id: I14f3f9ae52869d1149f92b32562e7fb3293109b5
Reviewed-on: https://gerrit.libreoffice.org/11027
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-20 01:50:57 -05:00
rbuj
b9813addf2 xmerge: Convert a primitive type into a string
Avoid unnecessary temporaries when converting primitive data types into a String.

Change-Id: If361383be52d8258be7c8c9bddf3ba05d5ca92c1
Reviewed-on: https://gerrit.libreoffice.org/11026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-20 01:48:33 -05:00
Markus Mohrhard
1558b50e4f remove whitespace
Change-Id: I5634bf40e8ccc4ce076409907c13f9c6f52d11a3
2014-08-20 08:17:40 +02:00
Tor Lillqvist
a1a480f91e Wa: C4701: potentially uninitialized local variable 'fVal' used
Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b
2014-08-20 09:01:41 +03:00
Miklos Vajna
8b6ce55b90 writerfilter: remove now unused namespace-alias elements
Change-Id: If58b3a9f5b1d79d164bb1c2a7c18aa4f99f00ca8
2014-08-19 23:26:09 +02:00
Miklos Vajna
a5396d64a4 writerfilter: stop reading namespace-alias elements
The same info is already available from oox.

Change-Id: I0725799e1f3ffebf6140ad38a0ce376e5417265d
2014-08-19 23:26:09 +02:00
Valentin Kettner
15295ab6db Refactored SwDoc::GetEditShell .
Removed its output paramater as GetCurrentViewShell should be
used instead and added a const version.

Change-Id: Iad8b57553b6e93e3472ce8c6905d08e8d49af770
2014-08-19 21:57:06 +02:00
Eike Rathke
5a05115ee2 more flexible handling of current date/time hotkeys
Let Ctrl+; current date and Shift+Ctrl+; (Ctrl+:) current time behave more
flexible, depending on the formatting (and as such the type) of the existing
cell content.

key date on time  cell => current date + time of cell => date+time formatted cell
key date on other cell => current date => date formatted cell
key time on date  cell => date of cell + current time => date+time formatted cell
key time on other cell => current time => time formatted cell

Change-Id: I2ccbfbab3c50c36a72c4db4696520e32f94caefa
2014-08-19 21:54:46 +02:00
Eike Rathke
11f145d90f a date is a date, without time
And use DateTime instead of manually concatenating Date and Time.

Change-Id: I6f9fb988beea2a9a17c976d3b98860c4f9ed063b
2014-08-19 21:54:44 +02:00
Caolán McNamara
f47baab6d3 Resolves: fdo#82355 crash on loading ppt
regression probably triggered by...

commit 2e3c45afc6
Date:   Fri Mar 4 07:38:16 2011 -0800
Remove usage of deprecated List container.

but that just stopped at the first NULL by chance

Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b
2014-08-19 20:49:17 +01:00
Tor Lillqvist
a0de5cc93d fdo#529470: I can't remove a path in AutoText dialog
This is, not surprisingly, somewhat weird code, but I think this patch does
what is necessary, it does fix the bug.

Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31
2014-08-19 21:03:05 +03:00
Luboš Luňák
bbc2f9e990 fix last commit
Change-Id: I32d3f99a2f090637d6891123f91093c0bcceddf4
2014-08-19 18:35:35 +02:00
Luboš Luňák
6fc89b66df try to fix windows build
Change-Id: I7620d71fe34b5f7bbd9bf9bf63b634d85cdb4d6c
2014-08-19 18:30:11 +02:00
Caolán McNamara
749f7548b4 only subtract height of hscroll if visible
otherwise infinite loop in extensions update check

Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3
2014-08-19 17:20:34 +01:00
Miklos Vajna
788632dcb0 DOCX export: handle SDT end right before a section break introducing headers
Change-Id: I0fab5ae4335ed6016d31aa243b131899c3154388
2014-08-19 18:19:04 +02:00
Miklos Vajna
1c06dc14a1 writerfilter: stop reading namespace-alias elements in factoryimpl
Change-Id: I52c2298c9583617481069040e118520cf8935c6d
2014-08-19 18:19:03 +02:00
Caolán McNamara
69d673b1ae dangling unused .ui file
Change-Id: Ifc1968e5474c7f252960d4b790d6f01db29cab8a
2014-08-19 16:39:53 +01:00
Luboš Luňák
869a3e1b7f split CppunitTest_sw_ooxmlexport into several tests
In order to allow running them in parallel. There are already enough
tests to make it run for a couple of minutes and it's annoying to
see only once core busy with it.
I intentionally left the original file at the same name, without 1
appended, in order to avoid merge problems.

Change-Id: I097c45c34797cc68f5d1790cf31eefc96fbaf44e
2014-08-19 17:25:00 +02:00
Caolán McNamara
36490fff3f facepalm: nAvailHeight is not derived from allocation Width
Change-Id: Ic99c6519b02c546e0d3574cb756e3fb172d1ff52
2014-08-19 16:14:23 +01:00
Takeshi Abe
82cb89fa05 Avoid possible memory leaks in case of exceptions
Change-Id: I41392572692bc219ae18ad89d95fc8be47d6812c
2014-08-19 23:35:41 +09:00
Caolán McNamara
1ab0e8717b guard against division by 0
valgrind + bff

Change-Id: I5fa40f7a9759c98bb70ee6eb854dd9b376401f89
2014-08-19 15:22:13 +01:00
Takeshi Abe
44afb981a5 fdo#75757: remove inheritance to std::vector
by replacing it with a typedef.

Change-Id: Iaa88086e3c5195012982dd625bfd589de2e484a2
Reviewed-on: https://gerrit.libreoffice.org/11017
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-19 08:30:44 -05:00
David Tardon
ca54b6ea90 use SolarMutex instead of a custom GdkThreadLock
C.f. commit 861a1c2dea.

Change-Id: I9f6cf917c63ee8c0db5461529c4ee277e231368f
2014-08-19 15:22:45 +02:00
Noel Grandin
4b4bff3402 java: no need to instantiate String objects directly
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
Noel Grandin
c552aac9f8 java: use 'Byte.valueOf' instead of 'new Byte'
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
2014-08-19 14:57:18 +02:00
Noel Grandin
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
Noel Grandin
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long'
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
Noel Grandin
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
Noel Grandin
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
Noel Grandin
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
Noel Grandin
1e6f0b2d8b simplify CallFormWizard
Change-Id: I0dfdc1acb0b550c1eeed16498f3e791e0123c4eb
2014-08-19 14:57:16 +02:00
Noel Grandin
3a8d351988 java: remove unused methods
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
Noel Grandin
8b65a61788 fix intermittent crash in make check
The original crash was in GtkSalMenu::Active, triggered from
RefreshMenusUnity and it looked like the refresh method was accessing
already freed memory.

Change-Id: Ib07d839a976869eb8719e71e0653f1a72e3b0e80
2014-08-19 14:57:13 +02:00
Miklos Vajna
b3f4709d73 DOCX export: handle SDT around floating tables
Change-Id: I07fedc201c51008baca3254dcc099f0182aa4c72
2014-08-19 13:03:33 +02:00
Markus Mohrhard
8ae264eb2f enable test after fixing the validation error
Change-Id: I99cd2c23d640eef744b292d3643baab6d42d191f
2014-08-19 12:48:53 +02:00
Ptyl Dragon
b00ce3241e fix for PtylTestEncryptionAndExport (on sofficemain.cxx)
Change-Id: I2857dae2df3b3e7e89b5bd56b35a4b8f3868920e
2014-08-19 13:14:10 +03:00
Miklos Vajna
914431e165 DOCX export: handle multi-para SDT's ending right before a table
Change-Id: I47ea5fd6e1b4d9d5a2893112efdcd810c4c84cfb
2014-08-19 10:34:52 +02:00
Eilidh McAdam
7b31e45ec7 Make Draw use paper size when printing - fdo#63905
Previously, Draw/Impress use the default size from the printer.
Now Draw uses the paper size (specified in page formatting).
Impress still uses the old method - not sure if this is correct
but printing handouts etc probably complicate print/paper size.

Change-Id: If90bae4ac59cd95dd50fcd8deb25fd900756193e
Reviewed-on: https://gerrit.libreoffice.org/9866
Reviewed-by: Matúš Kukan <matus.kukan@collabora.com>
Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-08-19 03:34:34 -05:00
Noel Grandin
0c8c3a536b fix java1.5 build compatibility
accidentally introduced by me in commit 0477e6c3 "java: add
@Override annotation to overriding methods"

Change-Id: Ieccd78f57282778a5e8f805f7a40f5e6a24e9498
2014-08-19 10:21:22 +02:00