Unfortunately, I failed to create a clean-room example,
even when I pasted some binary garbage at the end of the file.
Somehow I was getting a sanitized version from getAsStream.
In any case, this prevents crashing with the two examples I have,
although there are still significant problems somewhere
because the export just results in empty pages...
The problem is that reading again with the Pdfium-fixed version
gets mixed in with the original read results,
and things get pretty garbled.
Probably m_rElements and everything needs to be cleared
before tokenizing the fixup-version.
Change-Id: I01daefa23b8f92e2849d71bca269ba2b476199da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174648
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
coverity seems to be having trouble seeing through the function
pointers
and
cid#1607619 Data race condition
Change-Id: I94692f124dd82b58be6aee41b49cb309f66b213d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Let it use the same calculation as ImpSvNumberInputScan::GetTimeRef.
Decreases rounding errors.
Change-Id: I6474a1a5913d78c236adc511389c4abcebed2de6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174650
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The following patch appears to be upstreamed now
0001-AvoidCombiningExtrememelyLargeMeshes.patch.1
Add a patch to deal with a clang issue that only shows
up when building for 32-bit Windows.
The issue is reported upstream, but there is only
a workaround so far, no fix.
Change-Id: I1c50019a2afe39d245c6b02243789752e84445a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174585
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
OUString::number rounds to 15 significant digits, unfortunately; so
where in a fix for tdf#163344 it was needed to output something like
result: 0.60416666666666663, expected: 0.60416666666666674
it used to print
result: 0.604166666666667, expected: 0.604166666666667
Change-Id: I099d91ce4ac05358a119c63a5b1e481107aa7343
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174651
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
A wide set of smil elements and attributes is exported in json format.
Change-Id: I900e3b1032417b62ae3144c14bcd466358a103e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172550
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174586
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Since commit 872dba61a1 (INTEGRATION:
CWS xmlfilter01 (1.1.2.3.2.1.16); FILE MERGED, 2003-04-04),
XMLFilterDetect service uses Clipboardformat field in filterdetect.
Thus, it detects any file starting with "<?xml" and having string
"pwi" as "writer_PocketWord_File", because writer_PocketWord_File.xcu
has the text "doctype:pwi" as the value of its ClipboardFormat.
The problem is: since commit 1e6e891016
(restore PocketWord filter, this time backed by libwps, 2020-09-27),
this format is not handled by XMLFilterDetect service. So the filter
mis-detects some else filter's data, which then isn't accepted there.
This change makes the code of FilterDetect::detect to make sure that
it only processes its own data, checking DetectService property, too.
I didn't remove the ClipboardFormat property value from the mentioned
XCU, because (1) I don't know if it may be used by other code; and
(2) because it allows to have the sensible unit test.
Change-Id: I02fafe8df10f64640305d45cf1461b0a37552630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174607
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reference:
https://bugs.documentfoundation.org/show_bug.cgi?id=163219#c7
Everywhere the With block variable is defined
or redefined inside the With block, the Basic
code has been reviewed.
Found in
SFDatabases/SF_Database.xba/SetTransactionMode()
SFDocuments/SF_Document.xba/Styles()
ScriptForge/SF_Dictionary.xba/ImportFromPropertyValues()
ScriptForge/SF_UI.xba/SetStatusBar()
ScriptForge/SF_UI.xba/ShowProgressBar()
Most changes consist in isolating the With block
variable before the With block itself.
No functional change.
This solution is a workaround for the bug.
IT DOES NOT SOLVE THE ROOT CAUSE.
Change-Id: I48af29d3d9c8b1e36ef5a85c8cfe28f9639ae483
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174560
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
* Drop redundant "minor version >= 0" check
* For kf6, require version >= 6.0, i.e. drop support
for older pre-release development versions
Change-Id: Idffbc8eef513887727f6b256cb47a770294435bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174587
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Evaluate the "accepts-tab" GtkTextView property [1]
and set the `tabChangesFocus` QPlainTextEdit property
based on that, so tab moves focus to the next control
when "accepts-tab" is set to false in a "GtkTextView"
object in a .ui file, like the ones where this property
was newly set in previous commit
Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Oct 7 08:10:56 2024 +0200
a11y: Leave accessible description text view on simple tab key
(They're not yet supported by QtInstanceBuilder yet, but
once they are, that will work as expected.)
[1] https://docs.gtk.org/gtk3/property.TextView.accepts-tab.html
[2] https://doc.qt.io/qt-6/qplaintextedit.html#tabChangesFocus-prop
Change-Id: Ib1d33f37016a2601aa9ab9c370c9076dbae5bed3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174570
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Set the "accepts-tab" property to false for the GtkTextView
where an accessible description can be set, so pressing
the tab key moves focus to the next field in the dialog,
instead of inserting a literal tab character.
This simplifies using the dialog when using the keyboard only.
For the VCL and GTK implementations, pressing Ctrl+Tab
would previously be needed to move focus, which is less
intuitive.
Setting the property does not technically prevent inserting
tabs, they could still be inserted by copy-pasting
text containing tabs; just pressing the tab key while
the text view has focus won't insert them any more.
(I can't think of any reason to use actual tab characters
in the accessible description, however.)
Do this for the .ui files used for the following 2 scenarios:
* select QR code object in Writer, open context menu,
select "Alt Text" context menu entry
* select an image in Writer, open context menu,
select "Options" context menu entry, go to the
"Options" tab page
Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174569
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
so I messed up and uploaded skia m117 twice. But now there are two
copies of skia m117 in various CDN caches, with different sha256
output (no idea how that happened).
So upload a THIRD COPY with a new name, and then I can fix the
sha256 value in download.lst in a way that doesn't break the build for
someone.
Change-Id: I297ff4d9fa3a0edd902c85f2d674950945249a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174590
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Those KDE version check can be moved into compile-time.
This change will also reduce the time to check when native compiling,
too, since we don't need to run the just-built binaries.
Change-Id: I0d60ade17b1ab5aaf4f729e39aba1345f088e6b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174512
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The problem is, that having a local variable referring the same value
as the original expression 'foo' is not the same as referencing 'foo'
itself. After 'foo' is re-assigned, the local variable still refers
to the original value, not the new one.
It seems impossible to implement the reference using existing codegen
primitives, to imitate the true reference to 'foo', not to its value.
If we implement it by changing the runtime, the bytecode won't work
identically in older versions; if we introduce a new bytecode, that
would be an incompatible change.
As a workaround, only create the local With variable, when the block
variable is created using some function (as much as known by parser).
I think that there would be cases when this would still not work as
intended: an example is a property implemented using getter function;
the parser would likely treat the property as a variable, and avoid
creation of the local variable; and the getter would be called every
time a dot access will happen (which was the essence of tdf#132064).
However, this seems a better alternative to the bug fixed here.
Change-Id: I50bf679762fd2e73f215a000fa0ab60fd6ae7453
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174564
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The sort comparison patch seems to have been upstreamed.
Lots of patches needed to be redone.
Followed the skia release notes in replacing calls
to SkCanvas::flush and SkSurface::flushAndSubmit.
Change-Id: I13179565b95cc0720b4548cd4baecc5adacc7133
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174554
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
this code seems to be duplicated in
sw/source/core/unocore/XMLRangeHelper.cxx
too
Change-Id: Ib41edfa33a72f32dff1f6720e6b0f356e9773f18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174556
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
In commits f3f46b5fe7 (tdf#132064: make
With statement only evaluate its argument once, 2024-04-18) and
40d0e6f4c4 (tdf#162962: always create a
local "Nothing" for the "WITH" variable, 2024-09-16), I used hacks to
emulate the global Nothing.
This change implements it properly, I think, It makes sure to use the
RTL's Nothing; this saves compile-time checks, strings in pool, and
makes code cleaner.
Change-Id: I3d007c5aa187e9aa61c1c369511be969b8cf57f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174553
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
currently justs supports hyperlinks and nothing else over plain
text.
puts each paragraph in a separate div
Change-Id: I645d28e0bb6ed13e930e1555753846d10ecf5dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174388
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174504
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
1) On first call, "by column" was selected although that is the less common case.
> now by row is selected by default
2) The meaning of "Orientation" is not really clear. Suggestion: Compare: rows columns
> changed as suggested
3) The purpose of "Items" is unclear.
> renamed "Items" to "Records"
4) Help page does not exist.
> help page patch has been merged
5) If a database range is selected, the dialog does not consider the property "Contains column labels" of the database range.
> didn't quite get this one; require some help to reproduce
6) It is not usual to use "Okay", but other dialogs have it named "OK".
> changed as suggested.
7) Command has no extended tip.
> Added TooltipLabel
```
<prop oor:name="TooltipLabel" oor:type="xs:string">
<value xml:lang="en-US">Remove or select duplicate records from the selection</value>
</prop>
```
Change-Id: I9579af68b396cddeca608dc077af3b468191942b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174201
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
