If we selected the classification on the toolbar and then go into
the classification dialog, we need to add the current category
from the doc. properties to the classification result so it is
shown in the dialog automatically.
Change-Id: I80909d39efa61f263fdb7dd10188f8d7ae12d1e0
Reviewed-on: https://gerrit.libreoffice.org/44853
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
In addition move reading of origin to classificationhelper as we
need to read it there.
Change-Id: I472b073587e68e6896f915477603a25db9b310d3
Reviewed-on: https://gerrit.libreoffice.org/44848
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
When identifier is used for category, it is written into the
metadata under a different key. When loading it back, it should
fill the corresponding properties (identifier if identifier key was
used or name if name key was used), otherwise this can lead to
inconsistent behaviour when loading the classification data back
from the file.
Change-Id: Idbd9bde866d117bd7f60bcc224069f00a27fb9e2
Reviewed-on: https://gerrit.libreoffice.org/44846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
In paragraph classification we store only the identifier and not
the name, but for the ClassificationDialog we use the name as an
identifier, so we need to resovle the identifier to the name when
reading in the input classification results. It might make sense
to switch to identifiers in the dialog also as they are language
independent.
Abbreviated name is only for the classification category and has
no effect for other classefication elementslike markers and IP
parts, so always fill them with the full name directly.
Change-Id: I23bd0e8e92b16807a5b4d3162e503b799aa40718
Reviewed-on: https://gerrit.libreoffice.org/44845
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
This reverts commit f643e1f687.
Failing in firebird, back to the drawing board..
Change-Id: I087d2fa6e81cf713458b1c9645edc7c1facf148c
Reviewed-on: https://gerrit.libreoffice.org/44843
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Regions are specified as a binary tree of region nodes, and each node must
either be a terminal node or specify one or two child nodes.
Nodes contains two child nodes:
RegionNodeDataTypeAnd = 0x00000001,
RegionNodeDataTypeOr = 0x00000002,
RegionNodeDataTypeXor = 0x00000003,
RegionNodeDataTypeExclude = 0x00000004,
RegionNodeDataTypeComplement = 0x00000005,
Terminal nodes:
RegionNodeDataTypeRect = 0x10000000,
RegionNodeDataTypePath = 0x10000001,
RegionNodeDataTypeEmpty = 0x10000002,
RegionNodeDataTypeInfinite = 0x10000003
RegionNode must contain at least one element.
Change-Id: I668e5892701b979f09bcf5bbce44a43226676192
Reviewed-on: https://gerrit.libreoffice.org/44324
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
This should be a pure re-factor, plus:
switch from Serif -> Sans font default for the UI (wow).
enable larger font size for LOK only
that avoids a hard to debug svx junit test failure.
Change-Id: Id438026064983ea4907819bab55c4be740954605
Reviewed-on: https://gerrit.libreoffice.org/44625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
...that are created in java.io.tmpdir (e.g., /tmp on Linux) by
connectivity.tools.HsqlDatabase.createDBDocument() during e.g.
JunitTest_dbaccess_complex.
This revealed that connectivity.tools.AbstractDatabase.delete() (even if it
would have been called by the test) would have been non-effective at deleting
the file, as the java.io.File constructor used takes a pathname not a file URL
as argument, so the call to java.io.File.delete() would not have deleted the
relevant file (and returned false, rather).
Change-Id: I268e1d1732ac7a0db9ccde7d4ac4f09aa3811e11
Reviewed-on: https://gerrit.libreoffice.org/44801
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
... plus limiting 0-character, and not buffer length in (only)
some cases where max len then was MAXSTRLEN-1, accompanied by a
mix of >= and > comparisons.
Change-Id: I5b8452db52b1d464eb1410e31990043f7997af20
...by structurally comparing complex constexpr exprs that use template functions
that happen to not have been instantiated, so Expr::EvaluateAsRValue et al would
fail. (Which happened with SFX_PRINTER_ALL in SfxViewShell::SetPrinter,
include/sfx2/viewsh.hxx.)
Now all of the LO code base should compile without causing
checkIdenticalDefaultArguments to return Maybe.
Change-Id: I2b103418c2c68f6d2242535c9cca3222a2508778
Reviewed-on: https://gerrit.libreoffice.org/44773
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...introduced with cab6e68369 "Make
checkIdenticalDefaultArguments more precise", causing older Clang to hang when
compiling specific LO source files.
Change-Id: I99cfcad2f0cd9adccd5aa84d21502f586762217f
take ImageMagicks 1000 warnings as the starting point
Change-Id: Id685764404d27b151daf031a4860055f64dd0915
Reviewed-on: https://gerrit.libreoffice.org/44818
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
No idea whether 1bpp non-greylevel (i.e. with two palette entries that aren't shades
of grey) PNG images are mishandled.
Change-Id: I72173c7398db7f0e93c19679e3e392949bf1f4d2
