Commit graph

490908 commits

Author SHA1 Message Date
Gabor Kelemen
b8d04d32c1 [API CHANGE] Drop unused MozabDriver config group
last mentions of it were removed in 2021 by:
commit ee9ed2192b
and in 2015 by:
commit 4e3086da3e

Change-Id: Ic8c048f296c2c199fb43836a63a0c084196794cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158975
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:32:21 +01:00
Gabor Kelemen
dca1eeb19d [API CHANGE] Drop unused IncludedExtensions config key
last mention of it was removed in 2018 by:
commit e98bcfcc3c

Change-Id: Ia36b86efcd47132dabc7206fd53a8661e013ac09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158970
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:32:00 +01:00
Gabor Kelemen
e03dbcc6b7 [API CHANGE] Drop unused ThesaurusDialogImage config key
last mention of it was removed in 2011 by:
commit b243afd875

Change-Id: Ie48aecd0f2c30d7322dde774c84ce913a835a7a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158972
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:31:42 +01:00
Gabor Kelemen
fc77f34ebc [API CHANGE] Drop unused PreventTips config key
last mention of it was removed in 2012 by:
commit 74970948bb

Change-Id: I1a576f94eca9ecb7fe0d580f50d20b1def79668e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158973
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:31:27 +01:00
Gabor Kelemen
96d4bc4bb0 [API CHANGE] Drop unused SimpleControlPoint LargeControlPoint config keys
last mentions of them were removed in 2011-2012 by:
commit bbd638350f
commit 6ea8ea456c
commit ec4f69493b

Change-Id: Iba3820806a761c12dead77ce6207c62f60f7055c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158974
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:31:09 +01:00
Gabor Kelemen
23e106034e find-unused-configkeys: check whether sets...
are used at all, if they have an otherwise unused group as template

TODO: Still gives some false positives if a group is only used
as template of a set which is only used as template of another
set which is actually used (MergeToolBarInstruction MergeStatusBarInstruction)

Change-Id: Ia2f83c12a4e0bdcc88b1530bac4daaf456531f8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159297
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:30:30 +01:00
Gabor Kelemen
1ec76f7a38 [API CHANGE] Drop unused ShowAlienFilterWarning config key
last mention of it was removed in 2011 by:
commit ebb3da4a2b

Change-Id: I07a5e60f59781b9720543d436efede7b257cc872
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159296
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11 18:28:46 +01:00
Jean-Pierre Ledure
7b2a6f0444 ScriptForge (SFDatabases) new Dataset service
A dataset represents a set of tabular data
stored/produced by a database.
To use datasets, the database instance must exist
but the Base document may not be open.

A Dataset instance is create either with
- the (new) database.CreateDataset() method
- from an existing dataset with the (new)
  dataset.CreateDataset() method.

The proposed API supports next main purposes:
- browse for- and backward thru the dataset to get its content
- update any record with new values
- create new records or delete some.
In summary, the AKA "CRUD" operations
(create, read, update, delete).

The originality of the proposed API is the use
of a dense syntax to make insertions and updates
easy and readable:
Example:
(BASIC)
  Dim newID As Long
  newID = dataset.Insert("LastName", "Doe", "FirstName", "John")
  '     ... is equivalent to:
  Dim dict As Object, newID As Long
  Set dict = CreateScriptService("ScriptForge.Dictionary")
  dict.Add("LastName", "Doe")
  dict.Add("FirstName", "John")
  newID = dataset.Insert(dict)
(PYTHON) - next statements are equivalent
  newid = dataset.Insert('LastName', 'Doe', 'FirstName', 'John')
  newid = dataset.Insert({'LastName': 'Doe', 'FirstName': 'John'})
  newid = dataset.Insert(dict(LastName = 'Doe', FirstName = 'John'))
  newid = dataset.Insert(LastName = 'Doe', FirstName = 'John')

You will notice that the returned value is the AutoValue primery
key (when it exists) which makes it reuse as a foreign key
immediate.

The API is fully available both in Basic and Python user scripts.

The new service will require its inclusion in the user documentation.

Change-Id: I4f834c4234e5b96ec8fddfffbad791ecf31899df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159325
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
2023-11-11 18:20:15 +01:00
Andras Timar
c45779ce3d On Linux dictionaries are packaged separately
Change-Id: Iadbd5a1411c3b2c72deb59ba91f86d889a34fdc3
(cherry picked from commit 135a474477)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159312
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11 16:49:26 +01:00
Caolán McNamara
454d70247f ofz#63845 Integer-overflow
Change-Id: Ic2396c92b53012642976e75fcfa42cf2737f3092
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159311
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11 16:49:18 +01:00
Mike Kaganski
8d6209d92d Finally remove superfluous --with-theme=default option
... as suggested in commit 7524f45e0a
(remove superfluous --with-theme=default option, 2014-08-22).

Change-Id: Iddd1e000039846023c3a4e2ebd73b0010d70c706
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159320
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11 16:40:47 +01:00
Mike Kaganski
3b74fa43f5 Simplify input theme filtering
Change-Id: Iaa96feee79902f780409a19f97fed201793a66ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159319
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11 16:25:03 +01:00
Mike Kaganski
db029c5a02 When MPL subset needs to disable icon themes, suggest filtered input
A suggestion like "you wanted to have a, b, c, d; you need to exclude
b; use e" makes little sense :-)

Change-Id: I0212f0197b89c3e9d281fa5b24708672b82561b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159318
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11 16:24:57 +01:00
Andrea Gelmini
619b0fcef2 Remove exec bits on rtf file
Change-Id: I00f56edefeba01ab75fa504a074a5c99269bcef7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159321
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-11 15:41:53 +01:00
Mike Kaganski
0d0068f723 Make the unit test linear and more explicit
In the pevious state, the test would not even fail in case when import
started to drop last paragraphs.

Change-Id: Ic28d059ed41f88c9264743034a5ce5397fff0b2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159317
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11 12:23:48 +01:00
Mike Kaganski
42f6e7e5d6 Fix Windows 64-bit build using VS 2022
... after commit fce1815505, failing like

  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): error C7692: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
  C:\lo\src\core\include\vcl/vclenum.hxx(174): note: could be 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)'
  C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or       'bool operator ==(ErrCode,const ErrCodeMsg &)'
  C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or       'bool operator ==(const ErrCodeMsg &,ErrCode)'
  C:\lo\src\core\include\tools/gen.hxx(536): note: or       'bool operator ==(const Selection &,const Selection &)'
  C:\lo\src\core\include\tools/gen.hxx(473): note: or       'bool operator ==(const Range &,const Range &)'
  C:\lo\src\core\include\tools/gen.hxx(365): note: or       'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)'
  C:\lo\src\core\include\tools/gen.hxx(361): note: or       'bool operator ==(const Size &,const Size &)'
  C:\lo\src\core\include\tools/gen.hxx(231): note: or       'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)'
  C:\lo\src\core\include\tools/gen.hxx(227): note: or       'bool operator ==(const Point &,const Point &)'
  C:\lo\src\core\include\tools/color.hxx(256): note: or 'bool Color::operator ==(const Color &) const' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
  C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' [synthesized expression 'y == x']
  C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\vcl/vclenum.hxx(174): note: or 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: or       'built-in C++ operator==(int, sal_uInt32)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: or       'built-in C++ operator==(int, sal_Int32)'
  C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or       'bool operator ==(const TypedWhichId<T> &,sal_uInt16)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
  C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or       'bool operator ==(sal_uInt16,const TypedWhichId<T> &)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
  C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or       'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or       'bool operator ==(T *,const VclPtr<reference_type> &)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(233): note: or       'bool operator ==(const T *,const VclPtr<reference_type> &)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const T *,const VclPtr<reference_type> &)': could not deduce template argument for 'const T *' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(229): note: or       'bool operator ==(const VclPtr<reference_type> &,T *)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(224): note: or       'bool operator ==(const VclPtr<reference_type> &,const T *)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(220): note: or       'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(220): note: or 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color'
  C:\lo\src\core\include\vcl/vclptr.hxx(224): note: or 'bool operator ==(const VclPtr<reference_type> &,const T *)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color'
  C:\lo\src\core\include\vcl/vclptr.hxx(229): note: or 'bool operator ==(const VclPtr<reference_type> &,T *)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color'
  C:\lo\src\core\include\vcl/vclptr.hxx(233): note: or 'bool operator ==(const T *,const VclPtr<reference_type> &)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const T *,const VclPtr<reference_type> &)': could not deduce template argument for 'const T *' from 'Color'
  C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or 'bool operator ==(T *,const VclPtr<reference_type> &)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'Color'
  C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
  C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
  C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: while trying to match the argument list '(int, Color)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): error C7692: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
  C:\lo\src\core\include\vcl/vclenum.hxx(174): note: could be 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)'
  C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or       'bool operator ==(ErrCode,const ErrCodeMsg &)'
  C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or       'bool operator ==(const ErrCodeMsg &,ErrCode)'
  C:\lo\src\core\include\tools/gen.hxx(536): note: or       'bool operator ==(const Selection &,const Selection &)'
  C:\lo\src\core\include\tools/gen.hxx(473): note: or       'bool operator ==(const Range &,const Range &)'
  C:\lo\src\core\include\tools/gen.hxx(365): note: or       'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)'
  C:\lo\src\core\include\tools/gen.hxx(361): note: or       'bool operator ==(const Size &,const Size &)'
  C:\lo\src\core\include\tools/gen.hxx(231): note: or       'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)'
  C:\lo\src\core\include\tools/gen.hxx(227): note: or       'bool operator ==(const Point &,const Point &)'
  C:\lo\src\core\include\tools/color.hxx(256): note: or 'bool Color::operator ==(const Color &) const' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
  C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' [synthesized expression 'y == x']
  C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' [synthesized expression 'y == x']
  C:\lo\src\core\include\vcl/vclenum.hxx(174): note: or 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' [synthesized expression 'y == x']
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: or       'built-in C++ operator==(int, sal_uInt32)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: or       'built-in C++ operator==(int, sal_Int32)'
  C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or       'bool operator ==(const TypedWhichId<T> &,sal_uInt16)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
  C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or       'bool operator ==(sal_uInt16,const TypedWhichId<T> &)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
  C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or       'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
  C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or       'bool operator ==(T *,const VclPtr<reference_type> &)'
  C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'int'
  ...

Change-Id: Id976fe515287a4aa12d7ff8ca0ca09c31c65309f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159316
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11 12:22:40 +01:00
Noel Grandin
9bba3a604d use more concrete type in ImpEditEngine::SetUndoManager
instead of dynamic_cast'ing to the type we want, and __ignoring__ the
parameter if it is not, just adjust the type that we want, which
luckily everything is already sending

Change-Id: If083e11c9818cdcae199afc1261efbdb652e1c76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159295
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-11 11:03:58 +01:00
Mike Kaganski
f5926c8cfb Move user agent initialization to InitCurl_easy
Places that didn't initialize it previously, would benefit automatically

Change-Id: I2f1ff25fc58d9378462072bc92d7b37be2370fc8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159299
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11 08:42:57 +01:00
Noel Grandin
50add20437 loplugin:fieldcast improvements
reduce false positives, and also check reinterpret_cast

Change-Id: Ia6f214393f28451d18c16b764a3c2b149d29ba8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-11 07:22:56 +01:00
Oliver Specht
fce1815505 tdf#158044 handling of paragraph attributes in RTF import
style attributes need to be repeated at the paragraph
if not repeated then defaults have to be applied

Change-Id: I4ee567e8006c240c046b7e7bb75eae92e5563776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158839
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-10 22:29:40 +01:00
Mike Kaganski
e021d5dee1 Add missing license headers
Change-Id: I4c94fb9d92b02b42b185d205887fa7bce1c45be6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159235
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 21:40:15 +01:00
Mike Kaganski
fac623a8b8 Fix packaging with --enable-mpl-subset
Change-Id: I1cae9e9a9837df968663b6f46bd1e0d369377126
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159308
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 21:38:08 +01:00
Mike Kaganski
cf53900ae8 Fix packaging with --disable-curl
Change-Id: I9c3c1f1953c4d59c5a2d4c6017e73768d93a7bc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159307
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 21:38:00 +01:00
Mike Kaganski
500def3076 Improve error logging in remove_Files_Without_Sourcedirectory
Change-Id: I7ed7c08bd57bb5d1b11bc7c029decd571a6758f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159236
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 21:37:32 +01:00
Mike Kaganski
9aa2eee9d8 Fix the fix
Commit 87f0da8023 put the check
into a wrong position

Change-Id: I459c11e00babfc604c5d35aac4f7cd0ce3701c3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159237
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 21:37:10 +01:00
Caolán McNamara
630ea24fa4 ofz#64065 Abrt on config
Change-Id: Idb76d58ab6036c9f38b0b76a3a240dcfb07d52a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159310
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-10 21:35:48 +01:00
Armin Le Grand (allotropia)
23e9a4cf1e tdf#158169 take no actions in disposed incarnation
Using the described steps in the bug report it is possible
to have an already disposed incarnation of ChildrenManagerImpl
that gets called with notifyEvent. If exposed it is necessary
not to execute actions, but to inform the caller by triggering
a lang::DisposedException(). The SfxBaseModel::notifyEvent
that executes this will then remove the instance from it's list.

Change-Id: Ie39e37d6e55ea66f441e732b612774b18d7c3ca1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159306
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-11-10 20:05:11 +01:00
Noel Grandin
867c4b75dd loplugin:fieldcast in SvxNewTableDialogWrapper
Change-Id: Ia3efee04b725162e4812f1e419cc9d8e11b6d8f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159301
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 19:55:00 +01:00
Julien Nabet
fe12f1d83b Fix errors gtk4
[AWK] CustomTarget/postprocess/registry/fcfg_langpack_qtz.list
/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:249:85: error: passing 'css::uno::Reference<css::accessibility::XAccessibleContext>' by value, rather pass by const lvalue reference [loplugin:passparamsbyref]
                        css::uno::Reference<css::accessibility::XAccessibleContext> xContext)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:329:83: error: passing 'css::uno::Reference<css::accessibility::XAccessibleContext>' by value, rather pass by const lvalue reference [loplugin:passparamsbyref]
                      css::uno::Reference<css::accessibility::XAccessibleContext> xContext)
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
[XCD] registry_qtz
[CUS] filter/source/svg
[CUS] sw/generated
[PY ] CustomTarget/writerfilter/source/ooxml/OOXMLFactory_generated.cxx
[PY ] CustomTarget/writerfilter/source/ooxml/OOXMLFactory_generated.hxx
[PY ] CustomTarget/writerfilter/source/ooxml/OOXMLFactory_values.hxx
[PY ] CustomTarget/writerfilter/source/ooxml/qnametostr.cxx
/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:311:81: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
static void applyObjectAttribute(GtkAccessible* pGtkAccessible, const OUString& rName,
                                                                ~~~~~~~~~~~~~~~~^~~~~
/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:312:50: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
                                 const OUString& rValue)
                                 ~~~~~~~~~~~~~~~~^~~~~~
4 errors generated.

/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:329:83: error: passing 'css::uno::Reference<css::accessibility::XAccessibleContext>' by value, rather pass by const lvalue reference [loplugin:passparamsbyref]
                      css::uno::Reference<css::accessibility::XAccessibleContext> xContext)
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~

/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:312:50: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
                                 const OUString& rValue)
                                 ~~~~~~~~~~~~~~~~^~~~~~

/home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:318:52: error: no member named 'toInt32' in 'std::basic_string_view<char16_t>'
        const int nLevel = static_cast<int>(rValue.toInt32());
                                            ~~~~~~ ^
1 error generated.

Change-Id: I01942a3f65e87e33a093f8994e4bf44e74bafc65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159291
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-10 19:28:09 +01:00
Matt K
0c3b89da7c tdf#62603 Fix find/replace to not extend font attributes
This change modifies the logic of the core replace code
to now not replace the 1st character and extend its
attributes, but instead to actually replace characters
to keep respective formatting.  Additional checks
are made for whether the replacement was shorter or
longer than the found text, and to handle trimming
or appending the final portions as needed.

Change-Id: I03a5645898e55ad386bacc2766af9b244a97bd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155274
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 19:05:13 +01:00
Mike Kaganski
87f0da8023 Fix --disable-curl checks: --disable-online-update is needed
Change-Id: I63598815a2ed3c7300102180a8a8439e2ef1605d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159234
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 17:52:27 +01:00
Mike Kaganski
7fc847a99c Improve MPL subset directions text a bit
Change-Id: Ibf91009a2dea5a728bf27388168199e87a1d05d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159233
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10 17:34:32 +01:00
Noel Grandin
6976c0ad33 loplugin:fieldcast in mailmerge unit tests
Change-Id: I3c5f31848ea572678a6ba85463ebda04b882eeaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159303
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 17:03:20 +01:00
Noel Grandin
c4216ba557 loplugin:fieldcast in OTableStyleContext
Change-Id: I8c5c1d569d022ac679e4939d97fdd293000c23ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159300
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 17:02:24 +01:00
Andreas Heinisch
bb79936ec8 tdf#96854 - De-static-ize last used option for copy/move sheet
Change-Id: Iafb12b51f166f9485f1658c406a98e5db5b246ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159292
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-11-10 16:59:29 +01:00
Kohei Yoshida
e890b0f0a9 Upgrade orcus to 0.19.2
Change-Id: I2cbf5f93c3b8b2235828affdef7309c3611b19b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159258
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-11-10 15:35:47 +01:00
Noel Grandin
2d5894cc9b avoid unnecessary intermediate buffer
and make it more obvious that we are doing recursive stuff here

Change-Id: I00209e0123eaacb015484949700ea0c983278fbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159285
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 13:51:00 +01:00
Noel Grandin
1041dc7d41 reduce noise in exceptionToStringImpl
otherwise we end up with log messages like

wrapped: void message: "at
C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/comphelper/source/misc/diagnose_ex.cxx:66"

when we call ourself to print out sub-exceptions

Change-Id: I9e598a6b68469e9baa3232811f310b7e24f1b77e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159284
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 13:50:51 +01:00
Miklos Vajna
8d973c5b94 sw floattable, insert UI: default to at-char for non-split flys
Inserting new images defaulted to the at-char anchor type, but inserting
a new frame defaulted to at-para, which is inconsistent. This is now more
visible, since LOK exposes the insert frame dialog.

An additional problem is that the LOK case hides anything other than
at-char and as-char in the frame properties dialog since commit
4154d281fb (sw lok: hide UI to set
Word-incompatible anchor types, 2019-07-05), which was intended for
images, but also affects text frames as well. But floating tables want
to-para anchored frames to be able to split.

Fix the problem by defaulting to at-char anchoring, unless we deal with
floating tables.

And show the to-para anchor widget in the LOK case again, given that all
of to-para, to-char and as-char have their use-cases, even when editing
Word documents.

Change-Id: I89b0973183a750d86f56e0cccd7b0fbcb3dc070d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159261
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-11-10 13:49:10 +01:00
Stephan Bergmann
c1bd25e467 Disable flakey navigator UITest again
f2ba17fecb "disable more flakey navigator UITest",
then 0a0c5a5b05 "UITest_sw_navigator: avoid
oneprocess" enabled it again, apparently in the false hopes that non-oneprocess
would magically fix this issue.  But this still causes frequent failures, e.g.,
<https://ci.libreoffice.org//job/lo_ubsan/2974/> failed with

> ======================================================================
> FAIL: test_tdf134390 (navigator.navigator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sc/qa/uitest/calc_tests8/navigator.py", line 145, in test_tdf134390
>     self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
> AssertionError: '1' != '2'
> - 1
> + 2

and <https://ci.libreoffice.org//job/lo_ubsan/2975/> failed with

> ======================================================================
> FAIL: test_tdf134390 (navigator.navigator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sc/qa/uitest/calc_tests8/navigator.py", line 145, in test_tdf134390
>     self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
> AssertionError: '53' != '2'
> - 53
> + 2

Change-Id: I39e878c20085cca3233f7c8859b9a1d28fcc56c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159262
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-10 13:33:26 +01:00
Noel Grandin
28756e84e4 loplugin:fieldcast in framework::AddonsToolBarWrapper
Change-Id: I1fc692581acc805d6c84156d6df57093cf9dff93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159281
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:36:48 +01:00
Noel Grandin
e88c98f81c loplugin:fieldcast in framework::MenuBarManager::MenuItemHandler
Change-Id: I5a98f1bc5783bbd78ba6596ced9bb77cd3037f95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159280
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:36:41 +01:00
Noel Grandin
b048814f5e loplugin:fieldcast in accessibility::AccessibleContextBase
Change-Id: Ibd71c2e809731114d4415754c8fd94110bd5736b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159225
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:35:58 +01:00
Noel Grandin
860d18034f loplugin:fieldcast in oox::drawingml::Shape
Change-Id: I0e5642f4f7dbb3f95d92fbb4dcf5b17f4becf503
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159224
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:35:48 +01:00
Noel Grandin
651b8080d1 loplugin:fieldcast in SvxClipBoardControl
Change-Id: I5877e1dd8c17c36a5233457030d54349f11ab04f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159223
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:35:40 +01:00
Noel Grandin
d294d1a32d loplugin:fieldcast in XMLPageExport
Change-Id: I07c5f2a6af46a3952d4fbc617d86174b1e23d518
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159222
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:35:26 +01:00
Noel Grandin
86441791e2 loplugin:fieldcast in framework::MenuBarWrapper
Change-Id: I7e44ad4db77db5fe4de543f47ffc4b8127e0ebea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159255
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10 12:35:17 +01:00
Andrea Gelmini
53a48cce9f Fix typo
Change-Id: I6e0bd6560f3dbc289da3e3e7ae65514600a4ac58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159202
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2023-11-10 11:39:27 +01:00
Balazs Varga
985b404f20 tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialog
for Language - Writing Aids Page.

Change-Id: I25723fb616544cd6ee7d894c3ca1aa6742748a73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159186
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-10 11:15:17 +01:00
Stephan Bergmann
2368e09cd1 Disable flakey navigator UITest again
f2ba17fecb "disable more flakey navigator UITest",
then 0a0c5a5b05 "UITest_sw_navigator: avoid
oneprocess" enabled it again, apparently in the false hopes that non-oneprocess
would magically fix this issue.  But this still hangs frequently, e.g.
<https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/45650/> hung here (and
got killed by kill-wrapper) with the python.bin process at

> Thread 1 (Thread 0x7f85438bbb80 (LWP 217701) "python3"):
> Traceback (most recent call first):
>   <built-in method sleep of module object at remote 0x7f854143b728>
>   File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/uitest/uitest/test.py", line 72, in wait_until_property_is_updated
>     time.sleep(DEFAULT_SLEEP)
>   File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sw/qa/uitest/navigator/tdf154521.py", line 158, in test_query_selected_bookmark
>     self.ui_test.wait_until_property_is_updated(xContentTree, "SelectEntryText", "Bookmark 2")
>   File "/usr/lib64/python3.6/unittest/case.py", line 622, in run
>     testMethod()
>   File "/usr/lib64/python3.6/unittest/case.py", line 670, in __call__
>     return self.run(*args, **kwds)
>   File "/usr/lib64/python3.6/unittest/suite.py", line 122, in run
>     test(result)
>   File "/usr/lib64/python3.6/unittest/suite.py", line 84, in __call__
>     return self.run(*args, **kwds)
>   File "/usr/lib64/python3.6/unittest/runner.py", line 176, in run
>     test(result)
>   File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/uitest/test_main.py", line 138, in <module>
>     result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(test_suite)

and the soffice.bin process just idling with nothing going on.

Change-Id: I44a38b12050cfe2cf4831631406df9018018e2ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159260
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-10 10:45:31 +01:00