Commit graph

3464 commits

Author SHA1 Message Date
Marcos Paulo de Souza
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
Stephan Bergmann
c319ccfc37 Revert "Simplify ImplRepository::impl_getLocationForModel return type"
This reverts commit 72305ed49d, which was bogus,
cf. the comment in ImplRepository::getDocumentBasicManager about recursive
calls.
2014-08-22 09:10:40 +02:00
Stephan Bergmann
73b2ea1dfa Remove BasicManagerCleaner
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22 09:06:55 +02:00
Stephan Bergmann
72305ed49d Simplify ImplRepository::impl_getLocationForModel return type
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22 09:03:27 +02:00
Stephan Bergmann
8c5834d5cb Remove trivial typedef, to make code more obvious
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-22 08:59:01 +02:00
Michael Meeks
d718c1f65f coverity#1202729 - ensure we have exactly a one dimensional array.
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
2014-08-21 00:39:45 +01:00
Caolán McNamara
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
Caolán McNamara
d438c470d7 coverity#1231668 Unchecked return value
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
2014-08-17 16:39:21 +01:00
Thomas Arnhold
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
Stephan Bergmann
d9baa2b06e -Werror,-Wundefined-bool-conversion
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-11 16:00:46 +02:00
Takeshi Abe
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
Michael Stahl
e5b0aa9a7c basic: -Werror=sign-compare
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29 18:06:06 +02:00
Alexandre Vicenzi
ae7ca8b957 fdo#46037: remove unused comphelper/configurationhelper.hxx
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 15:40:41 +00:00
Noel Grandin
c694837aea convert linked list to std::vector in SbxDimArray
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23
Reviewed-on: https://gerrit.libreoffice.org/10298
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 15:38:56 +00:00
Lionel Elie Mamane
1392a88c25 fdo#52076 remove empty library instead of writing it out empty
Change-Id: Id4fd8c4f34e8ed07044eb428049731c4b9b694ca
Reviewed-on: https://gerrit.libreoffice.org/10507
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-07-24 15:34:09 +00:00
Takeshi Abe
ea5ef0a72e Drop unused #includes
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
2014-07-24 01:06:15 +09:00
Takeshi Abe
50725318e4 Drop an unused function
Change-Id: I59eb46f9d57e9fd72ed86c972685be93d154e3c7
2014-07-18 23:24:58 +09:00
Takeshi Abe
fffc9b2f26 fdo#75757: remove inheritance to std::vector
... which was introduced at 2110397670.

Change-Id: If0f634b29e1891574267edf8cc07b24d07a9406c
Reviewed-on: https://gerrit.libreoffice.org/10363
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-17 21:29:50 +00:00
Tobias Lippert
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
Takeshi Abe
d97b5e420f Avoid possible memory leaks in case of exceptions
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
2014-07-16 18:01:39 +09:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
Caolán McNamara
eb9b890bc9 DBG_ASSERT->assert when followed by dereference
Change-Id: I9390228721df1b713d8cf2e719854b74d6b639c8
2014-07-06 21:06:06 +01:00
Caolán McNamara
c80be30203 coverity#706241 Uncaught exception
we've already checked to see if the element exists, so
we know that its not there.

Change-Id: I538c0d48a883d478e4c748d222b21958d083c049
2014-07-03 08:29:41 +01:00
Caolán McNamara
b35f3dfb1a coverity#706240 Uncaught exception
Change-Id: Ie31f5e1ff74ff8b9f35d7ce08e1f02a780375890
2014-07-01 16:43:05 +01:00
Norbert Thiebaud
42fcd888ae coverity#735397 dead code
Change-Id: If8d82a39af7a506f42b6c13d8408ffc479b564e7
2014-07-01 12:44:06 +02:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
Caolán McNamara
daa6898578 clang: Dead initialization
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26 16:29:15 +01:00
Caolán McNamara
a7fcb3ed07 clang: Returning null reference
Change-Id: I2cfc14e73696a027283dfa5eef98f784505dc5a3
2014-06-26 16:29:13 +01:00
Caolán McNamara
2daceb87b9 clang: Uninitialized argument value
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-26 16:29:13 +01:00
Kohei Yoshida
ec1636fa09 Remove this weird inheritance from smart-pointer-wrapped class.
SbxVarEntry is now its own class.

Change-Id: I5c5ce1990fa83930acced1d507f5b0de60bf221e
2014-06-25 15:03:46 -04:00
Kohei Yoshida
e14abb13dc Use boost::optional to store alias name.
Change-Id: I809b21ea156061a265c0d83d58534df10bc273bc
2014-06-25 15:03:46 -04:00
Kohei Yoshida
ff0ecb2621 pData -> mpVarEntries.
pData is a nightmare with grepping as it's too generic of a name.

Change-Id: I01b3f1b503f21ee13c97733fa66804874a2cddc4
2014-06-25 15:03:46 -04:00
Kohei Yoshida
bb6d9b0123 Remove this class that only derives from std::vector and not much else.
Change-Id: Ibc584f4148cec49a9ac34a240cc2fa3e87daf443
2014-06-25 15:03:46 -04:00
Noel Grandin
533c6cb6ba fixes for up-casting to Reference<XInterface>
Fix regressions introduced with
6a043e9c0a "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25 17:10:43 +02:00
Miklos Vajna
f870059a5a basic: silence expected SAL_WARN output
These were HACK() and DbgOut() messages previously, none of these ended
up on stderr. It seems that they are more or less harmless, so as long
as nobody fixes them, silence them, so more useful warnings are not
hidden when one does e.g. xray on a drawinglayer shape.

Change-Id: I7343d93d2916d9978852418aca725d027eb09128
2014-06-19 11:29:31 +02:00
Caolán McNamara
136a2bc384 coverity#1210096 Uncaught exception
Change-Id: I1d06c7a6a61556c2b501a16c224ccc6fe52307d0
2014-06-17 10:58:01 +01:00
Caolán McNamara
66f98136fd coverity#1210098 Uncaught exception
Change-Id: I531891fa1cce10a331dd651ee9ce52d1f8d0c169
2014-06-17 10:58:01 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Stephan Bergmann
f8ef1fe95b loplugin:staticcall
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
2014-06-13 17:54:23 +02:00
Caolán McNamara
2278e8f80e coverity#1213486 Uncaught exception
Change-Id: Ia4d919d88bf22168aa770ad35fd8360b0b155efe
2014-06-13 09:50:53 +01:00
Markus Mohrhard
9284a63add iprevent violation of exception spec
Change-Id: I1f638ae3a2e88e0cadaab0046ef087fe77e16b06
2014-06-10 15:58:24 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Stephan Bergmann
457933f1aa Do not both _use_library_objects and _use_libraries sb
Change-Id: I11f667104a0ca7279542fab53ad754d4de8c807d
2014-06-04 16:53:54 +02:00
Stephan Bergmann
e6655225e6 Avoid static BasicDLL (that would be destroyed after DeInitVCL now)
Change-Id: Id8968a7746815ecce79b6eb1ce971b74e770efa4
2014-06-04 10:16:06 +02:00
Stephan Bergmann
369d95931f DeInitVCL at end of tests
This required some changes to the framework:

* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
  once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
  the exisiting unobootstrapprotector).  CppunitTests that need VCL now need to
  declare gb_CppunitTest_use_vcl.

* For things to work properly, the UNO component context needs to be disposed
  from within DeInitVCL (cf. Desktop's Application::DeInit called from
  DeInitVCL).  The easiest solution was to introduce an
  Application::setDeInitHook (where the hook is called from DeInitVCL)
  specifically for vclbootstrapprotector to call.

* PythonTests don't (yet) call DeInitVCL; they still hook into
  BootstrapFixture's original test_init functionality (to call InitVCL), and do
  not make use of the vclbootstrapprotector.

Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04 08:55:12 +02:00
Thomas Arnhold
dd8f095940 WaE: warning C4101: 'ex' : unreferenced local variable
Change-Id: Ib8b71b50fe52a7cc4e261626549ac3e067851797
2014-06-04 08:30:26 +02:00
Thomas Arnhold
3038794d2e basic: typo
Change-Id: I10c9e480a94a966dac4f6c17fc69fa8892c56955
2014-06-02 12:04:31 +02:00
Stephan Bergmann
6b4c596b01 Fix memory leak for BASIC sub (as well as void function)
d88593af59 "INTEGRATION: CWS ab34: #i73457#
Prevent sub from beeing set as param 0 for return type void" to fix i#73457
"Memory Leak in all Basic type void Method calls" had made the PutDirect call
dependent on != SbxVOID only (which would cover void functions) but not also on
!= SbxEMPTY (which would apparently be required to also cover subs, as seen with
CppunitTest_basic_vba run under lsan).  Either this was an oversight with the
original fix, or subs have meanwhile changed from GetType() == SbxVOID to
SbxEMPTY?

Change-Id: I3e5dbf79bfd5eea3cfec8ed3fa984d13167aa501
2014-06-02 11:12:11 +02:00
Takeshi Abe
6a53ea218c Avoid possible memory leaks in case of exceptions
Change-Id: Iad3de981a1c9660b1322315640e531c9891db0bf
2014-05-31 00:35:27 +09:00