Noel Grandin
c0415d5f1e
java: remove unnecessary constructor declarations
...
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
Noel Grandin
6884ef6317
java: don't catch and then just rethrow an exception
...
without doing anything else useful
Change-Id: I5803d84d46e0a70e1759f2202e2c2273087f8723
2014-08-20 11:47:47 +02:00
Noel Grandin
8c9fdc4a96
java: remove modifiers implied by the context
...
found by PMD
Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
Noel Grandin
3f210b0e75
java: remove unnecessary return statements
...
found by PMD
Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-20 10:35:54 +02:00
Noel Grandin
60f152caee
java: avoid unnecessary comparisons in boolean expressions
...
i.e. stuff like "x == true"
Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
Noel Grandin
2922a967a1
java: Avoid naming non-fields with the prefix m_
...
found by PMD
Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
Noel Grandin
4b4bff3402
java: no need to instantiate String objects directly
...
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
Noel Grandin
0764292c5d
java: use 'Short.valueOf' instead of 'new Short'
...
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
Noel Grandin
ff0ad0493e
java: use 'Integer.valueOf' instead of 'new Integer'
...
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
Noel Grandin
be1bb7b1cc
java: use Boolean.valueOf instead of instantiating Boolean objects
...
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
Noel Grandin
56ef5533fc
java: classes in java.lang package do not need to be fully qualified
...
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
Noel Grandin
3a8d351988
java: remove unused methods
...
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
Chris Laplante
341d9c4f08
odk: Clean up comments
...
Change-Id: I38aa34192244cdd29e1cce7ac612aa9cd5f9e8a1
Reviewed-on: https://gerrit.libreoffice.org/11006
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-19 02:54:14 -05:00
Chris Sherlock
3579f76f15
Suppress unchecked warning - this is fine
...
Change-Id: I69f47cf975a9ed91d4a1408351b5ad1751aab19e
2014-08-16 22:24:48 +10:00
Noel Grandin
0d916bb240
java: remove unused imports
...
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
Noel Grandin
ac5954d7c5
java: remove commented out code
...
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
Noel Grandin
34bcf9b498
java: remove dead methods
...
found by UCDetector
Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
Noel Grandin
4155c28ae1
java: remove unused interfaces
...
found by UCDetector
Change-Id: Ide8b3b5c9969048aff84eed16b9eea096abad349
2014-08-13 09:44:17 +02:00
Noel Grandin
8583da1e93
java: remove unused fields
...
found by UCDetector
Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
Noel Grandin
68cd011c90
java: reduce scope, make some methods private
...
found by UCDetector
Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
Noel Grandin
70f56bc22f
java: reduce scope, make member classes private
...
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
Noel Grandin
da677dfd59
java: reduce scope, make fields private
...
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
Noel Grandin
14d1a11ec4
java: reduce scope, make constructors private
...
found by UCDetector
Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
Noel Grandin
e701b3f732
java: reduce scope, make constants private
...
found by UCDetector
Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12 12:16:37 +02:00
Noel Grandin
5656fe58a0
java: fix broken javadoc tags
...
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
Noel Grandin
1c496506bc
java: remove useless javadoc tags
...
that are not conveying any useful information
Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
Noel Grandin
f086884fc3
java: remove unused parameters
...
Change-Id: If51df0579dad2496d88699e6c850976d7e89ca9b
2014-08-12 09:41:30 +02:00
Noel Grandin
c218458ead
java: remove unnecessary semi-colons
...
Change-Id: I2eab5efff06ced09459adb407dbf789b8042a948
2014-08-12 09:41:30 +02:00
Noel Grandin
2035213b0b
java: remove unused methods
...
Change-Id: Ifd5de2d7cd1fa6ac34e45b17293c9f245a554a37
2014-08-12 09:41:30 +02:00
Noel Grandin
f35c721196
java: remove unused fields
...
Change-Id: I8d9196067d397dbd2c649b6c99011c193a60424f
2014-08-12 09:41:30 +02:00
Noel Grandin
161a7e3a4b
java: remove unused parameters
...
Change-Id: Iefc29756fd02b6898803c8a7faecd55108e088eb
2014-08-12 09:41:29 +02:00
Noel Grandin
d1d2d3296b
java: remove exceptions from throws clauses that are not actually thrown
...
Change-Id: I9d0f9242c911d9dd05f2229da44a2e8305b3df6a
2014-08-12 09:41:29 +02:00
Noel Grandin
b082fc648f
java: remove unused variables
...
Change-Id: I92400e4a6d794dae5198bf59b0e8ced0acbe348e
2014-08-12 09:41:29 +02:00
Noel Grandin
0477e6c39b
java: add @Override annotation to overriding methods
...
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
Noel Grandin
d5a31b2215
java: remove unused parameters
...
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
Noel Grandin
41709cc268
java: remove unused parameters
...
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
2014-08-11 12:33:02 +02:00
Michael Stahl
3e2ae631ec
odk: outdated documentation
...
Change-Id: I7e675a544729a7e1763d69888d1ad721c70df77c
2014-08-08 14:14:05 +02:00
Matthew Pottage
03e0bd6b3b
[API CHANGE] Removed two cppuhelper deprecated headers.
...
The headers cppuheader/compbase.hxx and implbase.hxx. They have been deprecated
since 2001. Moved the definitions of the deprecated functions to
cppuhelper/source/compat.cxx.
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, adding fixes and clean-up
in cppuhelper/source/compat.cxx and odk/Package_odk_headers.mk
Change-Id: I48b3cbf551b59d72614737a883a96aab55fc2090
2014-08-08 11:25:55 +02:00
Noel Grandin
616b3ad504
java: remove exceptions from throws clauses that are not
...
.. actually thrown
Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
Noel Grandin
b6a83e99c8
java: remove redundant null checks
...
Change-Id: Ia42e5ed715fbd3f5b84029a9844da55f307c6260
2014-08-08 09:48:19 +02:00
Noel Grandin
b58c053fed
java: remove unnecessary semi-colons
...
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-08 09:48:18 +02:00
Noel Grandin
a274d19d11
java: remove redundant super-interfaces
...
Change-Id: Iaf671ef87057362c804999a5154d8e8277bbc4b8
2014-08-08 09:48:18 +02:00
Noel Grandin
336f3b9153
java: code some code to use non-deprecated constructors
...
Change-Id: I4194a3dfd361d1955cf5bb4fab915150eecfa21a
2014-08-08 09:48:17 +02:00
Noel Grandin
2d700944b5
java: remove unused imports
...
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08 09:48:17 +02:00
Noel Grandin
e7a474b29a
java: remove unused variables
...
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
2014-08-08 09:48:16 +02:00
Noel Grandin
27459c71ef
java: remove unused fields
...
Change-Id: I25fef9590a34ec8d9aab182b3d267ae3cd649a87
2014-08-08 09:48:16 +02:00
Noel Grandin
8d6cf7a147
java: remove dead methods
...
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
Michael Stahl
e16cc171f1
odk: fix CustomTarget_allheaders for Win32 make
...
This one also has an overly long command line that is cut off.
Change-Id: I2d49e39b5dca6e1d84fffcb3212042b6d82c13f3
2014-08-05 14:53:23 +02:00
Noel Grandin
0c5f51ebbc
java: remove commented out code
...
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
Noel Grandin
d26540bb05
java: remove unused fields
...
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00