Commit graph

29018 commits

Author SHA1 Message Date
Olivier Hallot
c8a3b2d14c HIG-ify Cond. format manager + Help button
* Add help button to Conditional format manager
* HIG-ify with frame

Change-Id: I54a77a8e33a9bbbc1dd9b64cb4997a21c2e1a318
Reviewed-on: https://gerrit.libreoffice.org/11079
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-22 21:31:40 -05:00
Olivier Hallot
a022847126 HIG-ify conditional format dialog + help button
* Add help button to contitional format dialog
* HIG-ify with frames

Change-Id: Iea34bc7b6b14f26d8eb29557610baa7160238c5d
Reviewed-on: https://gerrit.libreoffice.org/11078
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-22 21:31:26 -05:00
Olivier Hallot
6814967742 Restore help button in Pivot Table Dialog
Change-Id: I9602fbb7edd7c7370a806cc0a61b3743a13229de
Reviewed-on: https://gerrit.libreoffice.org/11080
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-22 21:28:15 -05:00
Kohei Yoshida
10851dff98 Split FillAsTable into Binary and Xml variants in the same manner.
And remove BIFF-only records from the Xml variant.

Change-Id: Ia18cc079d9a9249fbbe0c328b14b719fba8d6bbf
2014-08-22 21:56:00 -04:00
Kohei Yoshida
44e68c897e Split FillAsHeader into FillAsHeaderBinary and FillAsHeaderXml.
To reduce complexity in each method, and remove records that are
specific to binary export form the Xml variant.

Change-Id: I6c66054b99dd8cded5767610f2390952b59caf23
2014-08-22 21:56:00 -04:00
Kohei Yoshida
16f9011c9c Make header (workbook) export and worksheet export clearer.
Change-Id: I9540fa32ca6a4ce041e15b272a049fcdf267fb0c
2014-08-22 21:55:59 -04:00
Eike Rathke
d40700d58e treat datetime as handled
Change-Id: Idc94174662eee5a75a6b467e47cbf9027e3ba224
2014-08-22 23:45:22 +02:00
Eike Rathke
0f4a999e02 current date/time hotkey inserts also if cell is in input or edit mode
Change-Id: Ib3caed607a5ca1b5ce82de0472223c7bdc8f7f54
2014-08-22 23:45:21 +02:00
Eike Rathke
e45001fad0 InsertCurrentTime: don't fiddle with the cell while editing
Change-Id: Ia12b10a44b7d90344a009753ddae801b7d58dddf
2014-08-22 23:45:21 +02:00
Matúš Kukan
7afacb97a7 Use anonymous namespace for these. (mostly EnumWrapper)
Change-Id: Ice90e519bbd32a12de59d696a6dfedaaf45bd45e
2014-08-22 23:04:14 +02:00
Eike Rathke
75aad687cb resolved fdo#82936 do not clear the 3D flag on refupdate
Change-Id: I2ae1368a2ffc20e988ff3ab66590a9f98902b862
2014-08-22 13:03:52 +02:00
Eike Rathke
10b6bda51c init formula options once, fdo#82183
Change-Id: I1db4816f4693e35024c6dc6c70585d7b72e68c32
2014-08-22 04:31:32 +02:00
Eike Rathke
9344af955b nitpick on comment form
Change-Id: I023f79187aaf6eb943a50516dace2aa229c5a87b
2014-08-22 02:59:57 +02:00
Eike Rathke
c0aba5007b fdo#82183 do not reset globals while loading a document
Destroying the function list while an instance of the Formula Wizard is
still open is a bad idea. Workaround not doing this when loading a
document due to a DDE function or external reference being entered in
the wizard.

Change-Id: I6fa00fb4f442bf7c9410679e446ff460289e4b16
2014-08-22 01:12:18 +02:00
Eike Rathke
07b18860ae out-of-bounds string access
... when parsing  ='foo'#  with no character following.

Change-Id: Id65fce721cb47a4d3c947c677323bdcaa2ce957f
2014-08-22 00:16:15 +02:00
Eike Rathke
fe4d72b563 it's about time to write GOALSEEK as ODFF ORG.OPENOFFICE.GOALSEEK
Change-Id: Ie5a0464b49baae62e217e87f4d0040151f3aa8a5
2014-08-21 15:43:09 +02:00
Olivier Hallot
e903d3ab04 fdo#80367 (part) help pages fo Calc XML source
Implement help button for Calc Data-XML Source

Change-Id: Ic1097b13c1d2266a8a1f21a4cbc9d416aacba892
Reviewed-on: https://gerrit.libreoffice.org/11055
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-21 08:18:40 -05:00
Eike Rathke
7c6a82d66e write COLOR function with extension namespace
and add to Excel import/export maps so it survives saving in that format

Change-Id: I3a8e07fdd1bded77d4bad60eefffeb0b1dbdd734
2014-08-21 15:10:08 +02:00
Eike Rathke
c08fea639c add missing parameter flag
in dbgutil build gave:
warn:legacy.osl:27022:1:tools/source/rc/resmgr.cxx:701:
file:///build/libo/dev/instdir/program/../program/resource/scen-US.res
Class: 272, Id: 436. Classpointer not at the end!
Resource Stack
Class: 272, Id: 25044

and the following value of the suppress flag was taken in place of the
parameter flag, which was identical and didn't harm in this case, but ...

Change-Id: I951381ef2a5c2d7d7d44892ad5c34ea77ace51ce
2014-08-21 14:10:45 +02:00
Stephan Bergmann
da401ac07b Work around unhelpful MSVC error C2216: override cannot be used with inline
Change-Id: I2944b9911b2458bf1c0f1645fd983b635be67bd2
2014-08-20 18:24:52 +02:00
Eike Rathke
135df4753d convert some OSL_TRACE to SAL_WARN
Change-Id: Ifb687de25a6da4696e659e27cb34668a9762445f
2014-08-20 18:20:38 +02:00
Stephan Bergmann
9a42c59394 Bad hack to enforce weakly emitted RTTI for ScValidationDlg
...(by inlining all its virtual functions), as otherwise -fsanitize=undefined
makes sc require ScValidationDlg RTTI (to verify the cast to ScValidationDlg in
the ScValidityRefChildWin ctor in sc/source/ui/view/reffact.cxx) but which would
only be emitted in scui (against which sc cannot link).

Change-Id: Id9e2bf0719ba3bba35e5ae1f0e58190d9fdb6dd4
2014-08-20 17:02:59 +02:00
Michael Stahl
2d4b87f0c1 ODF export: don't write invalid "group-name" attribute
Radio buttons are grouped via their "form:name" attribute already.

Change-Id: I9f8b27a2904d947c3d4665495d36961e3e41d2c6
2014-08-20 16:40:14 +02:00
Noel Grandin
794d5ac4ac vcl: use enum for complex text layout constants
Since these constants are bitfield flags, we define some methods to make
working with them reasonably type safe.

Move the definitions to outdevstate.hxx, since we need the values there,
and that appears to be the "root most" header file.

Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing
as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write
weird code thinking that it's a real flag.

Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343
Reviewed-on: https://gerrit.libreoffice.org/10676
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-20 09:01:26 -05:00
Stephan Bergmann
893d5f9973 Clean up line splicing and indentation
Change-Id: I2b9725052aeaeebef84ec9aedba639f6dda537ff
2014-08-20 15:44:59 +02:00
Caolán McNamara
4b339818bb add a VclViewport
like GtkViewport so that the scrolled region will be clipped,
which also has the side-effect of stopping glade clobbering
the non view-port scrolled .ui files on editing

Change-Id: Ic64174b3a35b77f068e0085cdc7721aeb33f1d82
2014-08-20 14:00:58 +01:00
Eike Rathke
fdb7429bf5 update input bar with new value
If setting the number format isn't called we need to explicitly update
the input bar.

Change-Id: I60c4808ce86eb659d3faf92d368c5118ee9673b2
2014-08-20 13:43:33 +02:00
Eike Rathke
32e8c47df8 refine current date/time hotkey handling
Nearing the "do what I mean" principle..

* key date on time cell  =>  current date + time of cell  =>  date+time formatted cell
  * unless time cell was empty or 00:00 time  =>  current date  =>  date formatted cell
* key date on date+time cell  =>  current date + 00:00 time  =>  date+time formatted cell
  * unless date was current date  =>  current date  =>  date formatted cell
* key date on other cell  =>  current date  =>  date formatted cell
* key time on date cell  =>  date of cell + current time  =>  date+time formatted cell
  * unless date cell was empty  =>  current time  =>  time formatted cell
* key time on date+time cell  =>  current time  =>  time formatted cell
  * unless cell was empty  =>  current date+time  =>  date+time formatted cell
* key time on other cell  =>  current time  =>  time formatted cell

Change-Id: I5025e0d0ea9ac83d1b9e0b130262df6db4693a56
2014-08-20 13:43:31 +02:00
Markus Mohrhard
4fe377ad6d disable the test until I understand the problem
Change-Id: I9a24ff49823a9521d412e1e761c4c1b6ece6b601
2014-08-20 11:27:48 +02:00
Noel Grandin
2922a967a1 java: Avoid naming non-fields with the prefix m_
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
Tor Lillqvist
a1a480f91e Wa: C4701: potentially uninitialized local variable 'fVal' used
Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b
2014-08-20 09:01:41 +03:00
Eike Rathke
5a05115ee2 more flexible handling of current date/time hotkeys
Let Ctrl+; current date and Shift+Ctrl+; (Ctrl+:) current time behave more
flexible, depending on the formatting (and as such the type) of the existing
cell content.

key date on time  cell => current date + time of cell => date+time formatted cell
key date on other cell => current date => date formatted cell
key time on date  cell => date of cell + current time => date+time formatted cell
key time on other cell => current time => time formatted cell

Change-Id: I2ccbfbab3c50c36a72c4db4696520e32f94caefa
2014-08-19 21:54:46 +02:00
Eike Rathke
11f145d90f a date is a date, without time
And use DateTime instead of manually concatenating Date and Time.

Change-Id: I6f9fb988beea2a9a17c976d3b98860c4f9ed063b
2014-08-19 21:54:44 +02:00
Noel Grandin
4b4bff3402 java: no need to instantiate String objects directly
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
Noel Grandin
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
Noel Grandin
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
Noel Grandin
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
Noel Grandin
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
Markus Mohrhard
8ae264eb2f enable test after fixing the validation error
Change-Id: I99cd2c23d640eef744b292d3643baab6d42d191f
2014-08-19 12:48:53 +02:00
Kohei Yoshida
3104f95254 Let's not export sheet tab color when it's not set.
COL_AUTO is the default value which is treated as color not being set.  The
old code would export it as a white color which is not correct.

Change-Id: Ib68fccfb228333f2059edc4cfffeed90880ebc60
2014-08-18 15:18:35 -04:00
Kohei Yoshida
ead1db7d49 Write test to ensure that we export sheet tab color settings correctly.
Previously, we would incorrectly export a sheet tab without any color set
as a tab with white color.

Change-Id: I97e59a0d8e2fba6db64149f53acfe4331a5ce2ba
2014-08-18 15:18:34 -04:00
Stephan Bergmann
759f5d24b0 Consistency around XColorItem in svx/sdshcitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1 "Remove unused ctors" and
68969cc61a "Consistency around SdrMetricItem."

Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
2014-08-18 18:18:08 +02:00
Stephan Bergmann
08edafa656 Consistency around SdrOnOffItem in svx/sdtcfitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1 "Remove unused ctors" and
68969cc61a "Consistency around SdrMetricItem."

Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18 14:56:55 +02:00
Caolán McNamara
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
Caolán McNamara
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
Stephan Bergmann
a51c423743 Consistency around SdrMetricItem in svx/sdsxyitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1 "Remove unused ctors" and
68969cc61a "Consistency around SdrMetricItem."

Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
2014-08-18 10:55:36 +02:00
Thomas Arnhold
dc053144e6 pivottablelayoutdialog: define default button
Change-Id: Ica4bc2a52e7351899a5741086c6db299caa5ed16
2014-08-18 01:45:14 +02:00
Caolán McNamara
209cdaa109 coverity#737702 Uncaught exception
Change-Id: Idfc005c1c34c609b7dcaae266cdaf6a15a403e5a
2014-08-17 16:39:19 +01:00
Thomas Arnhold
e99535df4d remove executable bits
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
2014-08-17 05:50:13 +02:00
Olivier Hallot
18749c7ad3 fdo#80453 (part) Help button for insert random #
* Insert help button in dialogo
* HIG-ify dialog.

Change-Id: I839af28981e9bd980842e73e29bd6443f4154b86
Reviewed-on: https://gerrit.libreoffice.org/10944
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-16 22:18:27 -05:00