office-gobmx/sdext/Executable_pdf2xml.mk
Kevin Suo e788317bb5 tdf#104597 related: restore the mirroring of Bidi_Mirrored characters
The method PDFIProcessor::mirrorString() was removed, and
::comphelper::string::reverseString was used, by Kevin Suo in commit
69e9925ded.

The old PDFIProcessor::mirrorString() did two things:
1) Reverse the code points in the string. However, due to its use of iterateCodePoints(&i)
rather than iterateCodePoints(&i, -1) (i.e. iterating in forward rather than reversed order),
the reverse was not functioning at all.
2) Use GetMirroredChar (i.e. the icu unicode u_charMirror() which was dropped in
commit 720a093461) to get the mirrored-image of
characters with the Bidi_Mirrored properties.

Stephan Bergmann restored the #1 in commit 50d73574b6
(by introducing comphelper::string::reverseCodePoints). However, the #2 was not restored.

I do not see a clear reason to drop #2 (at least this is an area I don't quite familiar
with), so it's better to restore it as well, in *this* commit, named as SubstituteBidiMirrored.

Change-Id: Ic263097938310e6e04f3b95bb12e4f4e834198f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143041
Tested-by: Jenkins
Reviewed-by: Kevin Suo <suokunlong@126.com>
2022-11-30 13:40:24 +01:00

44 lines
1,022 B
Makefile

# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
$(eval $(call gb_Executable_Executable,pdf2xml))
$(eval $(call gb_Executable_use_sdk_api,pdf2xml))
$(eval $(call gb_Executable_use_externals,pdf2xml,\
boost_headers \
cppunit \
zlib \
))
$(eval $(call gb_Executable_set_include,pdf2xml,\
-I$(SRCDIR)/sdext/source/pdfimport/inc \
$$(INCLUDE) \
))
$(eval $(call gb_Executable_use_libraries,pdf2xml,\
basegfx \
vcl \
comphelper \
cppu \
unotest \
cppuhelper \
sal \
tl \
xo \
i18nutil \
))
$(eval $(call gb_Executable_use_library_objects,pdf2xml,pdfimport))
$(eval $(call gb_Executable_add_exception_objects,pdf2xml,\
sdext/source/pdfimport/test/pdf2xml \
))
# vim:set noet sw=4 ts=4: