b37ae3985b
I can't reproduce the problem from tdf#136933 anymore (using kf5
and qt5), while it's reproducible using v.7.0 bibisect repo with
qt5. I conclude, that the problem got resolved in the meanwhile.
So it seems to make sense to just revert the problematic commit.
The incorrect line drawing still may need to be fixed eventually.
There seem to be no way to test SlideImpl::getCurrentSlideBitmap,
which eventually calls CanvasHelper::strokePolyPolygon. So this
change has no unit test, unfortunately.
Change-Id: I1d82b6f734a4f69d93c9d61732f55ef8158cfbe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173933
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| inc | ||
| opengl | ||
| qa/cppunit | ||
| source | ||
| workben | ||
| CppunitTest_canvas_test.mk | ||
| Executable_canvasdemo.mk | ||
| IwyuFilter_canvas.yaml | ||
| Library_cairocanvas.mk | ||
| Library_canvasfactory.mk | ||
| Library_canvastools.mk | ||
| Library_directx9canvas.mk | ||
| Library_gdipluscanvas.mk | ||
| Library_oglcanvas.mk | ||
| Library_simplecanvas.mk | ||
| Library_vclcanvas.mk | ||
| Makefile | ||
| Module_canvas.mk | ||
| Package_opengl.mk | ||
| README.md | ||
| README.vars | ||
| StaticLibrary_directxcanvas.mk | ||
UNO-based Graphics Backend
UNO-based graphics backend, lesser impedance to modern graphics APIs than vcl.
The canvas Framework
The canvas framework is the successor of the system GUI and graphics
backend VCL. Basic functionality is available, supplying just as much
features as necessary to provide a VCL-equivalent feature set (except
proper BiDi/CTL support).
The canvas framework consists of the following two modules, canvas and
cppcanvas. Additionally, a new generic graphics tooling is used (but
not exclusively by the canvas, Armin's drawinglayer module also make
use of it), which resides in basegfx.
The UNO API used by the canvas is primarily under
css::rendering, with css::rendering::XCanvas
being the central interface.
The slideshow Engine
The slideshow engine has replaced the former Impress-embedded
presentation framework with a fully independent UNO component, and it
is based on the canvas. Some features used there are only available
from canvas, like double-buffering, and hardware-accelerated
alpha-blending (currently not on all platforms).
Cairo canvas
Cairo canvas is one of backends of canvas component. canvas is mostly
used for slideshow rendering and also for emf+ rendering. we hoped it
will even be used by drawing layer, but it didn't happen (yet?) for
API look at offapi/com/sun/star/rendering/, the implementation is in
canvas and cppcanvas modules.
Cairo canvas backend uses Cairo library for rendering. Main advantage
is support of alpha transparency and in some cases accelerated
rendering.
The backend itself is quite old and stable, not many changes in that area lately, mostly changes for emf+ rendering, communication with vcl and bugfixes
Future Works
Look at Cairo canvas and situation when it is used
(mostly slideshow).
TODO
There still might be more cases when we can save some roundtrips when exchanging data with vcl.