Test repository to check push and ssh key
Find a file
Michael Weghorn 00c0ee8cf0 tdf#147083 wina11y: Return a11y object instead of child ID
Quoting MSAA doc about implementing child IDs [1]:

> # How Servers Implement Child IDs
>
> Server developers can assign child IDs to both simple elements and
> accessible objects. However, the recommended approach is to support the
> standard Component Object Model (COM) interface IEnumVARIANT in every
> accessible object that has children.
>
> If you implement IEnumVARIANT, you must:
>
> * Enumerate all children, both simple elements and accessible objects.
>   Provide child IDs for all simple elements and provide the IDispatch to
>   each accessible object.
> * For accessible objects, set the vt member of the VARIANT to
>   VT_DISPATCH. The pdispVal member must contain a pointer to the IDispatch
>   interface. Note that the VARIANT is allocated and freed by the client.
> * For simple elements, the child ID is any 32-bit positive integer.
>   Note that zero and negative integers are reserved by Microsoft Active
>   Accessibility. Set the VARIANT structure vt member to VT_I4 and the lVal
>   member to the child ID.
>
> If you do not support IEnumVARIANT, you must assign child IDs and
> number the children in each object sequentially starting with one.

So far, LibreOffice was returning negative "child IDs" instead of pointers
to accessible objects, which were not conformant to the MSAA
specification and not accepted by NVDA as valid child IDs
(s.a. discussion on the first version of my related NVDA pull request
to fix the announcement of a single selected cell in Calc, [2]).

Adapt that to return pointers to accessible objects and
drop the now unused 'CMAccessible::Get_XAccChildID'.

[1] https://docs.microsoft.com/en-us/windows/win32/winauto/how-servers-implement-child-ids
[2] https://github.com/nvaccess/nvda/pull/13277

Change-Id: I52a6f637adf334dee66627e6992451e6d81a7c9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129201
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-01-31 17:31:11 +01:00
.git-hooks
.github
.vscode vscode-ide-integration: use gdb from $PATH by default 2022-01-17 15:06:32 +01:00
accessibility
android
animations animations : use cppuhelper::BaseMutex 2022-01-30 07:32:41 +01:00
apple_remote
avmedia tdf#145538 - Use range based for loops 2022-01-17 20:49:57 +01:00
basctl move ToolBoxItemId into its own header 2022-01-26 12:07:18 +01:00
basegfx tdf#145614 Convert #define to enum or constexpr 2022-01-19 06:55:12 +01:00
basic Fix format string 2022-01-31 14:08:17 +01:00
bean
bin extract an initial webpfuzzer_seed_corpus.zip from the afl corpus 2022-01-31 11:46:49 +01:00
binaryurp
bridges WASM UNO: add a minimal dummy bridge 2022-01-19 14:26:09 +01:00
canvas
chart2 tdf#146066 chart: fix automatic axis scaling at dates 2022-01-31 16:07:06 +01:00
cli_ure
codemaker Improve DBG_UNHANDLED_EXCEPTION output a bit 2022-01-23 09:50:33 +01:00
comphelper fix opengl slide transition 2022-01-21 13:44:57 +01:00
compilerplugins WASM open links in new browser tabs 2022-01-20 10:26:04 +01:00
config_host upgrade to box2d 2.4.1 2022-01-24 09:58:45 +01:00
configmgr
connectivity Mysql/MariaDB: remove useless include+using + unused vars in mysqlc_connection 2022-01-30 19:21:12 +01:00
cppcanvas
cppu WASM UNO: add a minimal dummy bridge 2022-01-19 14:26:09 +01:00
cppuhelper WASM set correct path to FS image unorc 2022-01-28 19:34:17 +01:00
cpputools
cui gtk4: remove stray xalign 2022-01-29 20:20:09 +01:00
dbaccess used TypedWhichId in the constructor of various svx *Item classes 2022-01-29 18:59:53 +01:00
desktop no need to call GetWhich on these SID_ values 2022-01-27 20:05:46 +01:00
dictionaries@d37591fce4 Update git submodules 2022-01-19 22:46:16 +01:00
distro-configs WASM add strip flags to configure.ac 2022-01-19 12:00:48 +01:00
drawinglayer avoid Skia GPU surfaces for small virtual devices (bsc#1183308) 2022-01-24 14:40:22 +01:00
editeng lokCalcRTL: selection coords should be mirrored w.r.t output area 2022-01-29 05:05:35 +01:00
embeddedobj Recheck modules [e-f]* with IWYU 2022-01-17 01:33:35 +01:00
embedserv
emfio Recheck modules [e-f]* with IWYU 2022-01-17 01:33:35 +01:00
eventattacher
extensions gtk4: remove unwanted caps-lock-warning from GtkSpinButton 2022-01-29 18:03:40 +01:00
external support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
extras WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
filter Unit test for 0-byte ods detection 2022-01-31 17:05:28 +01:00
forms Recheck modules [e-f]* with IWYU 2022-01-17 01:33:35 +01:00
formula Recheck modules [e-f]* with IWYU 2022-01-17 01:33:35 +01:00
fpicker Recheck modules [e-f]* with IWYU 2022-01-17 01:33:35 +01:00
framework WASM make test file loading work 2022-01-20 14:27:16 +01:00
helpcompiler Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
helpcontent2@d5322f2e28 Update git submodules 2022-01-31 14:12:14 +01:00
hwpfilter avoid dangling tmp files in hwp import 2022-01-29 14:31:01 +01:00
i18nlangtag tdf#146602 Add Pennsylvania Dutch {pdc-US} 0x06AF to language list 2022-01-26 17:03:52 +01:00
i18npool Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
i18nutil Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
icon-themes support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
idl Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
idlc
include sw: prefix members of SwPagePreview, SwScrollbar, ... 2022-01-31 17:25:31 +01:00
instsetoo_native Make installer compression tool configurable 2022-01-22 10:14:23 +01:00
io Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
ios
javaunohelper Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
jurt Avoid loplugin:salcall 2022-01-23 12:28:20 +01:00
jvmaccess
jvmfwk Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
l10ntools Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
librelogo
libreofficekit Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
lingucomponent Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
linguistic Recheck modules [i-l]* with IWYU 2022-01-27 18:52:16 +01:00
lotuswordpro ofz: Undefined-Shift 2022-01-28 09:52:08 +01:00
m4
nlpsolver
o3tl Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
odk Let CppunitTest_odk_checkapi build against the SDK include directory 2022-01-19 23:00:55 +01:00
offapi remove css:💹:XDataInterpreter 2022-01-23 12:45:18 +01:00
officecfg related tdf#111733 TextCharacterSpacingControl sw: goto position tab 2022-01-27 18:34:37 +01:00
onlineupdate
oovbaapi vba: add support for Application.WindowState + test 2022-01-27 07:38:09 +01:00
oox Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
opencl Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
osx Add more source files for debugging convenience 2022-01-27 15:54:35 +01:00
package Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
pch
postprocess WASM open links in new browser tabs 2022-01-20 10:26:04 +01:00
pyuno Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
qadevOOo
readlicense_oo support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
registry
remotebridges Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
reportbuilder
reportdesign Recheck modules [o-r]* with IWYU 2022-01-30 16:10:57 +01:00
ridljar
sal WASM setup as non-multiuser, desktop build 2022-01-19 10:50:35 +01:00
salhelper
sax WASM make test file loading work 2022-01-20 14:27:16 +01:00
sc lokCalcRTL: fix autofilter popup position 2022-01-31 06:52:43 +01:00
scaddins
sccomp
schema
scp2 support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
scripting make comphelper::OInterfaceContainerHelper4 more threadsafe 2022-01-14 21:04:10 +01:00
sd sw: prefix members of SwPagePreview, SwScrollbar, ... 2022-01-31 17:25:31 +01:00
sdext
setup_native use mktemp for FAKEDBRPM 2022-01-29 11:42:27 +01:00
sfx2 SID_COPY_STREAM_IF_POSSIBLE is a SfxBoolItem 2022-01-31 14:06:16 +01:00
shell WASM open links in new browser tabs 2022-01-20 10:26:04 +01:00
slideshow
smoketest
solenv support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
soltools
sot
starmath no need to call GetWhich on these SID_ values 2022-01-27 20:05:46 +01:00
static Fix typos 2022-01-21 12:51:49 +01:00
stoc Let loplugin:nullptr look into template instantiations 2022-01-15 15:58:07 +01:00
store Let loplugin:nullptr look into template instantiations 2022-01-15 15:58:07 +01:00
svgio
svl fix loading file with very large number of styles 2022-01-29 10:40:31 +01:00
svtools tdf#83523 ruler: Invalidate full ruler rect on app bg change 2022-01-31 12:27:48 +01:00
svx tdf#146860 Vertical alignment of text inside grouped shapes textbox incorrect 2022-01-31 15:06:32 +01:00
sw sw: prefix members of SwPagePreview, SwScrollbar, ... 2022-01-31 17:25:31 +01:00
swext
sysui change rpm compression algorithm to multi threaded xz 2022-01-23 15:13:03 +01:00
test
testtools
toolkit WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
tools jsonwriter: ensure correct number of bytes is available 2022-01-31 17:01:33 +01:00
translations@59aa671612 Update git submodules 2022-01-26 14:15:58 +01:00
ucb ucb: webdav-curl: suppress libcurl proxy detection 2022-01-31 16:55:21 +01:00
ucbhelper fix opengl slide transition 2022-01-21 13:44:57 +01:00
udkapi
uitest
UnoControls tdf#145614 Convert #define to enum or constexpr 2022-01-19 06:55:12 +01:00
unodevtools
unoidl
unoil
unotest
unotools WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
unoxml
ure
uui
vbahelper
vcl support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
winaccessibility tdf#147083 wina11y: Return a11y object instead of child ID 2022-01-31 17:31:11 +01:00
wizards Fix typo 2022-01-31 14:24:31 +01:00
writerfilter Related tdf#66039 DOCX WPG import: Do not put extra paragraph at the end 2022-01-31 17:16:25 +01:00
writerperfect WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
xmerge
xmlhelp
xmloff Fix typos 2022-01-20 15:16:55 +01:00
xmlreader
xmlscript
xmlsecurity gtk4: remove stray xalign 2022-01-29 20:21:09 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
config_host_lang.mk.in
configure.ac support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
g Allow g to run git gc command 2022-01-15 15:42:34 +01:00
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
Makefile.gbuild
Makefile.in Add <module>.*all aliases to .all* and update help 2022-01-17 11:10:34 +01:00
README.cross
README.help.md
README.md
README.Solaris
Repository.mk The Emscripten FS image isn't installed anymore 2022-01-21 15:24:25 +01:00
RepositoryExternal.mk support for the WebP image format (tdf#114532) 2022-01-31 10:44:29 +01:00
RepositoryFixes.mk WASM more initial bits and pieces 2022-01-19 10:49:40 +01:00
RepositoryModule_build.mk
RepositoryModule_host.mk WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.5
  • macOS:
    • Runtime: 10.13
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.