Caolán McNamara
3c06623733
cid#1500664 Dereference before null check
this looks sensible at:
commit e7c7d6f0e9
Author: Kurt Zenker <kz@openoffice.org>
Date: Thu Sep 11 09:16:30 2003 +0000
INTEGRATION: CWS mav05 (1.1.2); FILE ADDED
as:
if ( (*pElementIter)->m_bIsStorage )
{
OSL_ENSURE( (*pElementIter)->m_pStorage && (*pElementIter)->m_pStorage->m_xPackageFolder.is(),
"An inserted storage is incomplete!\n" );
if ( !(*pElementIter)->m_pStorage || !(*pElementIter)->m_pStorage->m_xPackageFolder.is() )
throw uno::RuntimeException(); // TODO
xNewElement = uno::Reference< lang::XUnoTunnel >( (*pElementIter)->m_pStorage->m_xPackageFolder,
uno::UNO_QUERY );
(*pElementIter)->m_pStorage->Commit();
}
and then didn't after:
commit 8c64f087f8
Author: Rüdiger Timm <rt@openoffice.org>
Date: Thu Oct 30 08:48:27 2003 +0000
INTEGRATION: CWS mav08 (1.2.10); FILE MERGED
2003/10/15 08:07:55 mav 1.2.10.2: #i21121# substorages implement transacted mode
2003/10/13 14:26:33 mav 1.2.10.1: #i21121# Transacted mode for storages
Change-Id: Ib05359b282d078cd40b41ed8f2fe9242235c9c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130417
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>