d5cb1c694c
After 5d7af3c38b "make some classes
module-private" various tests in my Linux ASan+UBSan build failed due to missing
symbols.
Identified the problematic types with
> make check screenshot gb_SUPPRESS_TESTS=x && for i in $(find instdir/program workdir/LinkTarget/CppunitTest -type f); do LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}instdir/program:workdir/UnpackedTarball/cppunit/src/cppunit/.libs ldd -r "$i" 2>/dev/null | grep 'undefined symbol: _ZTI'; done
and fixed the ensuing
> sw/source/core/SwNumberTree/SwNodeNum.cxx:190:32: error: dynamic_cast from 'SwNumberTreeNode' with hidden type visibility to 'SwNodeNum' with default type visibility [loplugin:dyncastvisibility]
> SwNodeNum* pChild( dynamic_cast<SwNodeNum*>(pNode) );
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sw/inc/SwNumberTree.hxx:114:7: note: base class 'SwNumberTreeNode' with hidden type visibility defined here [loplugin:dyncastvisibility]
> class SwNumberTreeNode
> ~~~~~~^~~~~~~~~~~~~~~~
> sw/inc/SwNodeNum.hxx:29:26: note: derived class 'SwNodeNum' with default type visibility defined here [loplugin:dyncastvisibility]
> class SAL_DLLPUBLIC_RTTI SwNodeNum : public SwNumberTreeNode
> ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fallout.
Change-Id: I7abafdb4d02216e1a047f886d5e72ad3420115ce
Reviewed-on: https://gerrit.libreoffice.org/82210
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
102 lines
3.5 KiB
C++
102 lines
3.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#ifndef INCLUDED_SW_INC_SWNODENUM_HXX
|
|
#define INCLUDED_SW_INC_SWNODENUM_HXX
|
|
|
|
#include "SwNumberTree.hxx"
|
|
|
|
class SwTextNode;
|
|
struct SwPosition;
|
|
class SwNumRule;
|
|
|
|
class SAL_DLLPUBLIC_RTTI SwNodeNum : public SwNumberTreeNode
|
|
{
|
|
public:
|
|
|
|
explicit SwNodeNum( SwTextNode* pTextNode, bool isHiddenRedlines );
|
|
// note: this is only for creating phantom nodes and root nodes; these
|
|
// never have a text node
|
|
explicit SwNodeNum( SwNumRule* pNumRule );
|
|
virtual ~SwNodeNum() override;
|
|
|
|
SwNumRule* GetNumRule() const { return mpNumRule;}
|
|
void ChangeNumRule( SwNumRule& rNumRule );
|
|
SwTextNode* GetTextNode() const { return mpTextNode;}
|
|
|
|
virtual bool IsNotificationEnabled() const override;
|
|
|
|
virtual bool IsContinuous() const override;
|
|
|
|
virtual bool IsCounted() const override;
|
|
|
|
virtual bool LessThan(const SwNumberTreeNode & rNode) const override;
|
|
|
|
virtual bool IsRestart() const override;
|
|
|
|
virtual SwNumberTree::tSwNumTreeNumber GetStartValue() const override;
|
|
|
|
SwPosition GetPosition() const;
|
|
|
|
// The number tree root node is deleted, when the corresponding numbering
|
|
// rule is deleted. In this situation the number tree should be empty -
|
|
// still registered text nodes aren't allowed. But it is possible, that
|
|
// text nodes of the undo nodes array are still registered. These will be
|
|
// unregistered.
|
|
// Text nodes of the document nodes array aren't allowed to be registered
|
|
// in this situation - this will be asserted.
|
|
static void HandleNumberTreeRootNodeDelete( SwNodeNum& rNodeNum );
|
|
|
|
/** determines the <SwNodeNum> instance, which is preceding the given text node
|
|
|
|
#i81002#
|
|
*/
|
|
const SwNodeNum* GetPrecedingNodeNumOf( const SwTextNode& rTextNode ) const;
|
|
|
|
protected:
|
|
virtual SwNumberTreeNode * Create() const override;
|
|
|
|
// --> #i64010#
|
|
virtual bool HasCountedChildren() const override;
|
|
virtual bool IsCountedForNumbering() const override;
|
|
|
|
// method called before this tree node has been added to the list tree
|
|
virtual void PreAdd() override;
|
|
// method called at a child after this child has been removed from the list tree
|
|
virtual void PostRemove() override;
|
|
private:
|
|
SwTextNode *const mpTextNode;
|
|
SwNumRule * mpNumRule;
|
|
bool m_isHiddenRedlines;
|
|
|
|
static void UnregisterMeAndChildrenDueToRootDelete( SwNodeNum& rNodeNum );
|
|
|
|
SwNodeNum( const SwNodeNum& ) = delete;
|
|
SwNodeNum& operator=( const SwNodeNum& ) = delete;
|
|
|
|
virtual bool IsCountPhantoms() const override;
|
|
|
|
virtual bool IsNotifiable() const override;
|
|
|
|
virtual void NotifyNode() override;
|
|
};
|
|
|
|
#endif // INCLUDED_SW_INC_SWNODENUM_HXX
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|