office-gobmx/toolkit/source/awt/vclxplugin.cxx
Norbert Thiebaud d0dbce798b remove a confusing use of GetMutex() when a SolarMutexGuard is really meant
VCLXDevice, VCLXGraphics and derived class use a mutex that is really
a reference to the SolarMutex. They declare a function GetMutex() to
access tis reference to the SolarMutex, and the implementation
use
osl::SolarGuard aGuard(GetMutex())
to take a guad on the solar mutex.

This is confusing because some other class in that framework also implement
a GetMutex() function, but which this time return a regular Mutex.

Since this particular use of GetMutex() is to get the SolarMutex, and
invariably this is then used to take a Guard on the SolarMutex,
all these uses are replaced by a SolarMutexGuard object, which encapsulate
that behavior.
2010-11-01 12:24:32 -05:00

84 lines
2.2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*************************************************************************
*
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* Copyright 2000, 2010 Oracle and/or its affiliates.
*
* OpenOffice.org - a multi-platform office productivity suite
*
* This file is part of OpenOffice.org.
*
* OpenOffice.org is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License version 3
* only, as published by the Free Software Foundation.
*
* OpenOffice.org is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License version 3 for more details
* (a copy is included in the LICENSE file that accompanied this code).
*
* You should have received a copy of the GNU Lesser General Public License
* version 3 along with OpenOffice.org. If not, see
* <http://www.openoffice.org/license.html>
* for a copy of the LGPLv3 License.
*
************************************************************************/
#include "vclxplugin.hxx"
#include <com/sun/star/awt/PosSize.hpp>
#include <toolkit/helper/convert.hxx>
#include <toolkit/helper/property.hxx>
#include <vcl/ctrl.hxx>
#include <vcl/svapp.hxx>
#include "forward.hxx"
namespace layoutimpl
{
using namespace ::com::sun::star;
VCLXPlugin::VCLXPlugin( Window *p, WinBits b )
: VCLXWindow()
, mpWindow( p )
, mpPlugin( 0 )
, mStyle( b )
{
}
VCLXPlugin::~VCLXPlugin()
{
}
void SAL_CALL VCLXPlugin::dispose() throw(uno::RuntimeException)
{
{
SolarMutexGuard aGuard;
lang::EventObject aDisposeEvent;
aDisposeEvent.Source = W3K_EXPLICIT_CAST (*this);
}
VCLXWindow::dispose();
}
void VCLXPlugin::SetPlugin( ::Control *p )
{
mpPlugin = p;
}
awt::Size SAL_CALL VCLXPlugin::getMinimumSize()
throw(::com::sun::star::uno::RuntimeException)
{
SolarMutexGuard aGuard;
if ( mpPlugin )
return AWTSize( mpPlugin->GetSizePixel() );
return awt::Size();
}
} // namespace layoutimpl
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */