Test repository to check push and ssh key
Find a file
Miklos Vajna 0e0bad1a6a tdf#128736 sw ContinuousEndnotes: fix use-after-free on text frame join
Regression from commit 61cf196631 (sw
ContinuousEndnotes: fix moving them to the previous page, 2019-10-25),
the problem was that the SwFootnoteFrame::mpReference was not updated on
frame split. This meant that by the time the frame was joined,
SwTextFrame::JoinFrame() thought that the follow has no footnotes, so
the footnote reference was not updated, resulting in a dangling pointer.

Fix the problem by going back to using bEnd for endnotes (both the Word
compat and the normal case), this means that
SwTextFrame::ConnectFootnote() will invoke
SwFootnoteBossFrame::ChangeFootnoteRef(), fixing the dangling pointer.

Then fix the original problem differently: similar to the in-section
endnotes, just remove + append them, this makes sure that the endnotes
(in the Word compat case) move to a previous page on page delete.

Change-Id: Ia1b8e54b4a0b0f385c703f8e7016011c3ac57a03
Reviewed-on: https://gerrit.libreoffice.org/82778
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2019-11-15 16:39:48 +01:00
.git-hooks
.github
accessibility
android android/mobile-config.py: Use python3 2019-11-13 16:07:24 +01:00
animations
apple_remote
avmedia New loplugin:consttobool 2019-11-14 19:53:53 +01:00
basctl Fix macro disabling in Basic IDE 2019-11-12 08:10:07 +01:00
basegfx
basic cid#1448329 Wrapper object use after free 2019-11-14 20:29:57 +01:00
bean
bin make bin/update_pch work with srcdir != builddir 2019-11-11 10:21:31 +01:00
binaryurp
bridges
canvas
chart2 chart2: Weld ChartTypePanel 2019-11-15 16:28:50 +01:00
cli_ure
codemaker
comphelper
compilerplugins Fix loplugin:consttobool for assert on macOS 2019-11-15 14:38:27 +01:00
config_host
configmgr use std::move when popping stuff off stacks 2019-11-12 13:59:50 +01:00
connectivity make some classes module-private 2019-11-15 08:13:06 +01:00
cppcanvas
cppu
cppuhelper
cpputools
cui Resolves: tdf#128802 manage dnd ourself 2019-11-15 14:27:51 +01:00
dbaccess make some classes module-private 2019-11-15 08:13:06 +01:00
desktop lok: calc: switch row / column / grouping data to pixels. 2019-11-13 11:16:56 +01:00
dictionaries@4fb010374f Update git submodules 2019-11-13 00:44:49 +01:00
distro-configs
drawinglayer
dtrans Fix typo 2019-11-11 09:38:03 +01:00
editeng
embeddedobj
embedserv
emfio
eventattacher
extensions
external CVE-2019-16707 2019-11-13 09:55:10 +01:00
extras tdf#114746 Restore asian and complex tags in Classy_Red template 2019-11-14 19:16:18 +01:00
filter Added Orientation argument to LOKIT renderFont 2019-11-10 22:39:55 +01:00
forms
formula
fpicker Resolves: tdf#128767 fpicker sets labels on buttons as well as labels 2019-11-13 12:49:43 +01:00
framework tdf#42949 Fix IWYU warnings in framework/*/*hxx 2019-11-11 09:48:23 +01:00
helpcompiler
helpcontent2@4ad79a357b Update git submodules 2019-11-14 21:47:29 +01:00
hwpfilter
i18nlangtag
i18npool
i18nutil
icon-themes Breeze & Sifr: tdf#127458: Add Auto Redact icons 2019-11-11 05:25:52 +01:00
idl
idlc
include Revert "tdf#126128 Reduce page properties dialog's height." 2019-11-15 08:42:24 +01:00
instsetoo_native User interface languages: At least one is required 2019-11-11 16:11:34 +01:00
io
ios
javaunohelper Extend loplugin:salbool to loplugin:fakebool 2019-11-13 15:06:42 +01:00
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit New loplugin:consttobool 2019-11-14 19:53:53 +01:00
lingucomponent
linguistic
lotuswordpro
m4
nlpsolver
o3tl
odk
offapi revert action button changes to UNO XStyleSetting 2019-11-13 21:39:25 +01:00
officecfg Add ChartTypePanel to the ChartDeck 2019-11-14 21:13:19 +01:00
onlineupdate
oovbaapi
oox tdf#117658 PPTX import: fix duplicated math object handling 2019-11-13 18:43:57 +01:00
opencl
osx
package do not clean up EncryptionData during SaveAs 2019-11-15 12:50:38 +01:00
pch
postprocess
pyuno
qadevOOo
readlicense_oo
registry
remotebridges
reportbuilder
reportdesign no need to store reference to Import here 2019-11-13 10:26:35 +01:00
ridljar
sal Silence -Werror=sign-compare (--enable-cipher-openssl-backend) 2019-11-12 13:03:16 +01:00
salhelper
sax Fix useless assert(true) (which would never fire) 2019-11-13 22:30:31 +01:00
sc reduce iteration in ScViewData::GetScrPos 2019-11-15 07:19:01 +01:00
scaddins
sccomp
schema
scp2 User interface languages: At least one is required 2019-11-11 16:11:34 +01:00
scripting
sd sd: define three columns for the slide transition pane 2019-11-15 12:51:10 +01:00
sdext tdf#42949 Fix IWYU warnings in sdext/ 2019-11-13 09:45:38 +01:00
setup_native
sfx2 do not clean up EncryptionData during SaveAs 2019-11-15 12:50:38 +01:00
shell tdf#128538: Open filesystem directories in Finder after all 2019-11-15 09:44:28 +01:00
slideshow use std::move when popping stuff off stacks 2019-11-12 13:59:50 +01:00
smoketest
solenv use icerun also for python/java/ui tests 2019-11-15 12:12:41 +01:00
soltools
sot
starmath
stoc
store
svgio
svl
svtools
svx Log exception 2019-11-15 10:35:24 +01:00
sw tdf#128736 sw ContinuousEndnotes: fix use-after-free on text frame join 2019-11-15 16:39:48 +01:00
swext
sysui
test
testtools
toolkit make some classes module-private 2019-11-15 08:13:06 +01:00
tools Don't compile cpuid test with INTRINSICS_CXXFLAGS 2019-11-11 22:21:38 +01:00
translations@6d4072204c Update git submodules 2019-11-13 15:27:23 +01:00
ucb Extend loplugin:salbool to loplugin:fakebool 2019-11-13 15:06:42 +01:00
ucbhelper
udkapi
uitest
UnoControls
unodevtools
unoidl
unoil
unotest
unotools
unoxml
ure
uui Better throw RuntimeException than assert here 2019-11-12 14:50:25 +01:00
vbahelper
vcl loplugin:indentation 2019-11-15 10:51:14 +01:00
winaccessibility
wizards
writerfilter DOCX: clean-up paragraph bottom handling of table style 2019-11-15 15:51:27 +01:00
writerperfect clang-format: don't fix up namespace comments 2019-11-14 08:30:47 +01:00
xmerge
xmlhelp
xmloff xmloff: create XMLDrawContentExportOasis instances with an uno constructor 2019-11-15 09:05:49 +01:00
xmlreader
xmlscript
xmlsecurity make some classes module-private 2019-11-15 08:13:06 +01:00
.buckconfig
.buckversion
.clang-format clang-format: don't fix up namespace comments 2019-11-14 08:30:47 +01:00
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitreview
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in
config_host_lang.mk.in
configure.ac --with-windows-sdk: correct parameter is 10.0, not 10 2019-11-14 04:27:16 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst external: update pdfium to 3963 2019-11-13 09:02:30 +01:00
g
hardened_runtime.xcent
install-sh
leak-suppress.txt fix doc 2019-11-13 06:13:09 +01:00
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-blacklist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2017 version 15.7
  • macOS:
    • Runtime: 10.10
    • Build: 10.13.2 + Xcode 9.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.