Michael Weghorn 27c95bb445 svx: Simplify "Go to Page" dialog, let SpinButton do its job ... Set the allowed range using weld::SpinButton::set_range so that weld::SpinButton makes sure that a value within the correct range is set, instead of having a custom handler called when the text of the spinbutton changes that effectively does the same thing (+ manually setting cursor to the end of the edit, but sticking to the toolkit default there instead makes sense to me for consistency). Adjust the test case to no longer type invalid input for the page number ("3a"), as SalInstanceSpinButton doesn't parse the number then, but would set the value to the minimum (here: 1) instead. (If a different behavior were intended here, that should be implemented in SalInstanceSpinButton or the underlying VCL widgets to be consistent across dialogs.) In GotoPageDlg::GetPageSelection, use weld::SpinButton::get_value to get the integer value right away, instead of getting the text and converting that into an integer manually. All that custom handling provided an interesting test case while implementing support for that dialog using native Qt widgets, see commits up to commit 70825e677f Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 28 00:30:10 2024 +0100 tdf#130857 qt weld: Notify about spinbox combined value+text change , but apart from that (which is done now), I think that a more standard approach makes more sense. Change-Id: I06492b6629a4210c6325d50467da8e195daa4c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177463 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>		2024-11-28 11:57:33 +01:00
..
annotation	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
diagram
dialog	svx: Simplify "Go to Page" dialog, let SpinButton do its job	2024-11-28 11:57:33 +01:00
sdr	tdf#159007 Revert "optimization to skip SdrObject::GetViewContent()"	2024-10-17 22:16:40 +02:00
sidebar
theme
unodraw
AccessibleControlShape.hxx
AccessibleGraphicShape.hxx
AccessibleOLEShape.hxx
AccessibleShape.hxx
AccessibleShapeInfo.hxx
AccessibleShapeTreeInfo.hxx
AccessibleTextHelper.hxx
ActionDescriptionProvider.hxx
algitem.hxx
anchorid.hxx
autoformathelper.hxx
bmpmask.hxx
camera3d.hxx	svx: prefix members of Camera3D	2024-10-15 09:42:28 +02:00
charmap.hxx
charthelper.hxx
ChildrenManager.hxx
chrtitem.hxx
ClassificationCommon.hxx
ClassificationDialog.hxx
ClassificationField.hxx	Improve loplugin:dyncastvisibility to check for non-inline key functions	2024-11-14 12:49:22 +01:00
clipboardctl.hxx
clipfmtitem.hxx
colorbox.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
ColorSets.hxx
colorwindow.hxx
CommonStyleManager.hxx
compatflags.hxx
compressgraphicdialog.hxx
connctrl.hxx
constructhelper.hxx
contdlg.hxx
ctredlin.hxx
cube3d.hxx	svx: prefix members of E3dCubeObj	2024-11-04 14:31:42 +01:00
cuicharmap.hxx	tdf#152299 - Remove unused define(s) from C/C++ files	2024-11-23 13:20:58 +01:00
dataaccessdescriptor.hxx
databaselocationinput.hxx
databaseregistrationui.hxx
dbaexchange.hxx
dbaobjectex.hxx
def3d.hxx
deflt3d.hxx
dialcontrol.hxx
dialmgr.hxx
dialogs.hrc
dlgctl3d.hxx
dlgctrl.hxx
dlgutil.hxx
DocumentColorHelper.hxx
drawitem.hxx
e3ditem.hxx	svx: prefix members of SvxB3DVectorItem	2024-11-19 15:32:51 +01:00
e3dsceneupdater.hxx
e3dundo.hxx
EnhancedCustomShape2d.hxx
EnhancedCustomShapeFunctionParser.hxx
EnhancedCustomShapeGeometry.hxx
EnhancedCustomShapeTypeNames.hxx
extedit.hxx
extrusionbar.hxx
f3dchild.hxx
FileExportedDialog.hxx	improve loplugin passparamsbyref	2024-11-19 07:46:25 +01:00
fillctrl.hxx
flagsdef.hxx
float3d.hxx
fmdmod.hxx	com::sun::star -> css	2024-11-10 10:50:15 +01:00
fmgridcl.hxx
fmgridif.hxx
fmmodel.hxx
fmobjfac.hxx
fmpage.hxx
fmsearch.hxx
fmshell.hxx
fmsrccfg.hxx
fmsrcimp.hxx
fmtools.hxx
fmview.hxx
fntctrl.hxx
fontwork.hxx
fontworkbar.hxx
fontworkgallery.hxx
formatpaintbrushctrl.hxx
framebordertype.hxx
framelink.hxx	svx: unused return	2024-11-19 18:03:18 +01:00
framelinkarray.hxx
frmdirlbox.hxx
frmsel.hxx
galctrl.hxx
gallery.hxx	tdf#152299 - Remove unused define(s) from C/C++ files	2024-11-23 14:50:42 +01:00
gallery1.hxx	enforce null checking of AcquireTheme return	2024-09-09 09:17:13 +02:00
galleryitem.hxx
galleryobjectcollection.hxx
galmisc.hxx	tdf#152299 - Remove unused define(s) from C/C++ files	2024-11-23 14:51:25 +01:00
galtheme.hxx	these can be const	2024-09-11 09:37:09 +02:00
GenericCheckDialog.hxx
grafctrl.hxx
graphctl.hxx
graphichelper.hxx
grfcrop.hxx	tdf#152299 - Remove unused define(s) from C/C++ files	2024-11-23 13:19:32 +01:00
grfflt.hxx
gridctrl.hxx	use more concrete UNO types in svx	2024-09-14 08:18:24 +02:00
hdft.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
helperhittest3d.hxx
hexcolorcontrol.hxx
hlnkitem.hxx
hyperdlg.hxx
IAccessibleParent.hxx
IAccessibleViewForwarder.hxx
IAccessibleViewForwarderListener.hxx
ifaceids.hxx
ImageMapInfo.hxx
imapdlg.hxx
insctrl.hxx
ipolypolygoneditorcontroller.hxx
itemwin.hxx
itextprovider.hxx
labelitemwindow.hxx
langbox.hxx
lathe3d.hxx
linectrl.hxx
linkwarn.hxx
measctrl.hxx
MediaShellHelpers.hxx
modctrl.hxx
msdffdef.hxx
nbdtmg.hxx	loplugin:constantparam	2024-10-01 11:17:19 +02:00
nbdtmgfact.hxx
numberingpreview.hxx	svx: prefix members of SvxNumberingPreview	2024-10-07 09:19:33 +02:00
numfmtsh.hxx
numinf.hxx
numvset.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
obj3d.hxx
objfac3d.hxx
ofaitem.hxx
optgenrl.hxx
optgrid.hxx
pagectrl.hxx
pageitem.hxx
pagenumberlistbox.hxx
Palette.hxx
PaletteManager.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
papersizelistbox.hxx
paraprev.hxx
ParaSpacingControl.hxx
ParseContext.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
passwd.hxx
polypolygoneditor.hxx
postattr.hxx
pszctrl.hxx
RectangleAlignmentItem.hxx
rectenum.hxx
relfld.hxx	tdf#36709 GUI changes for font-relative first-line indent	2024-11-14 17:30:06 +01:00
rotmodit.hxx
rubydialog.hxx	tdf#156543 sw: Added base text mono feature to Asian Phonetic Guide	2024-09-12 21:51:39 +02:00
ruler.hxx
rulritem.hxx
samecontentlistbox.hxx
scene3d.hxx	svx: prefix members of E3dScene	2024-11-11 09:49:49 +01:00
sdangitm.hxx
sdasitm.hxx
sderitm.hxx
sdgcpitm.hxx	SdrGrafCropItem needs its own SfxItemType	2024-09-30 18:27:45 +02:00
sdggaitm.hxx
sdgluitm.hxx
sdgmoitm.hxx
sdmetitm.hxx
sdooitm.hxx
sdprcitm.hxx
sdrhittesthelper.hxx
sdrmasterpagedescriptor.hxx
sdrobjectfilter.hxx
sdrobjectuser.hxx
sdrpageuser.hxx
sdrpagewindow.hxx
sdrpaintwindow.hxx
sdrundomanager.hxx
sdshcitm.hxx
sdshitm.hxx
sdshtitm.hxx
sdsxyitm.hxx
sdtaaitm.hxx
sdtacitm.hxx
sdtaditm.hxx
sdtagitm.hxx
sdtaiitm.hxx
sdtaitm.hxx
sdtakitm.hxx
sdtayitm.hxx
sdtcfitm.hxx
sdtditm.hxx
sdtfchim.hxx
sdtfsitm.hxx
sdtmfitm.hxx
sdynitm.hxx
searchcharmap.hxx
selctrl.hxx
selectioncontroller.hxx
ShapeTypeHandler.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
signaturelinehelper.hxx
SmartTagItem.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
SmartTagMgr.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
spacinglistbox.hxx
SpellDialogChildWindow.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
sphere3d.hxx
srchdlg.hxx
statusitem.hxx
strarray.hxx
strings.hrc	tdf#161826 - Add uniform Glow effect for texts in shapes	2024-08-29 19:59:24 +02:00
svdcrtv.hxx
svddef.hxx	tdf#163486: PVS V1043 global object variable is declared in header (svddef.hxx)	2024-11-22 10:34:37 +01:00
svddrag.hxx
svddrgmt.hxx	svx: prefix members of SdrDragMove	2024-11-25 09:21:11 +01:00
svddrgv.hxx	cid#1556149 disentangle this undo code a little	2024-09-09 09:18:19 +02:00
svdedtv.hxx
svdedxv.hxx	svx: prefix members of SdrObjEditView	2024-08-26 09:14:03 +02:00
svdetc.hxx
svdgeodata.hxx
svdglev.hxx
svdglue.hxx
svdhdl.hxx
svdhlpln.hxx
svditer.hxx
svdlayer.hxx
svdmark.hxx
svdmodel.hxx	reduce time spent in RecalcPageNums when importing PDF	2024-09-06 14:48:17 +02:00
svdmrkv.hxx
svdoashp.hxx
svdoattr.hxx
svdobj.hxx
svdobjkind.hxx
svdocapt.hxx
svdocirc.hxx
svdoedge.hxx
svdograf.hxx	no need to cache GraphicAttr in SdrGrafObj	2024-10-22 11:44:10 +02:00
svdogrp.hxx
svdomeas.hxx
svdomedia.hxx
svdoole2.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
svdopage.hxx
svdopath.hxx
svdorect.hxx
svdotable.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
svdotext.hxx	improve loplugin passparamsbyref	2024-11-19 07:46:25 +01:00
svdouno.hxx
svdoutl.hxx
svdovirt.hxx
svdpage.hxx	We don't need a virtual here	2024-10-22 09:17:02 +02:00
svdpagv.hxx	svx: prefix members of SdrPageView	2024-09-09 09:33:31 +02:00
svdpntv.hxx	improve loplugin passparamsbyref	2024-11-19 07:46:25 +01:00
svdpoev.hxx	svx: prefix members of SdrPolyEditView	2024-09-23 09:30:29 +02:00
svdpool.hxx
svdsnpv.hxx	svx: prefix members of SdrSnapView	2024-09-30 09:24:05 +02:00
svdsob.hxx
svdtext.hxx
svdtrans.hxx	tdf#163486: PVS V1043 global object variable is declared in header (include/)	2024-11-22 14:25:57 +01:00
svdtypes.hxx	tdf#163486: PVS V1043 global object variable is declared in header (include/)	2024-11-22 14:25:57 +01:00
svdundo.hxx
svdview.hxx
svdviter.hxx
svdxcgv.hxx
svx3ditems.hxx
SvxColorChildWindow.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
SvxColorValueSet.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
svxdlg.hxx	loplugin:passstuffbyref in svx	2024-11-06 15:45:24 +01:00
svxdllapi.h
svxerr.hxx
svxgraphicitem.hxx
svxids.hrc	support setting writer comment contents from simple-html	2024-10-04 15:28:21 +02:00
svxitems.hrc
SvxNumOptionsTabPageHelper.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
SvxPresetListBox.hxx	tdf#157467 SvxPresetListBox: contextmenu must affect item under mouse	2024-11-12 14:52:37 +01:00
SvxShapeTypes.hxx	tdf#143148 Use pragma once instead of include guards in svx directory	2024-10-03 13:49:50 +02:00
SvxXTextColumns.hxx
swframeexample.hxx
swframeposstrings.hxx
swframetypes.hxx
swframevalidation.hxx
sxcecitm.hxx
sxcgitm.hxx
sxciaitm.hxx
sxcllitm.hxx
sxctitm.hxx
sxekitm.hxx
sxelditm.hxx	Improve loplugin:dyncastvisibility to check for non-inline key functions	2024-11-14 12:49:22 +01:00
sxenditm.hxx
sxmbritm.hxx
sxmlhitm.hxx
sxmtfitm.hxx
sxmtpitm.hxx
sxmtritm.hxx
sxmuitm.hxx
tabarea.hxx
tabline.hxx
tbcontrl.hxx
tbxcolor.hxx
tbxctl.hxx
transfrmhelper.hxx
txencbox.hxx
txenctab.hxx
ucsubset.hxx
uiobject.hxx
unoapi.hxx
unobrushitemhelper.hxx
unofill.hxx
unomaster.hxx
unomid.hxx
unomod.hxx
unomodel.hxx
UnoNamespaceMap.hxx
unopage.hxx
unopool.hxx
unoprov.hxx
unoshape.hxx	use more concrete UNO types in chart2	2024-09-13 18:51:41 +02:00
unoshprp.hxx	tdf#161826 - Add uniform Glow effect for texts in shapes	2024-08-29 19:59:24 +02:00
unoshtxt.hxx
view3d.hxx
viewlayoutitem.hxx
viewpt3d.hxx	svx: prefix members of Viewport3D	2024-10-21 11:28:48 +02:00
weldeditview.hxx
xbitmap.hxx
xbtmpit.hxx
xcolit.hxx
xdash.hxx
xdef.hxx	tdf#163486: PVS V1043 global object variable is declared in header (xdef.hxx)	2024-11-21 16:05:02 +01:00
xenum.hxx
xfillit0.hxx
xfilluseslidebackgrounditem.hxx
xflasit.hxx
xflbckit.hxx
xflbmpit.hxx
xflbmsli.hxx
xflbmsxy.hxx
xflbmtit.hxx
xflboxy.hxx
xflbstit.hxx
xflbtoxy.hxx
xflclit.hxx
xflftrit.hxx
xflgrit.hxx
xflhtit.hxx
xfltrit.hxx
xftadit.hxx
xftdiit.hxx
xftmrit.hxx
xftouit.hxx
xftshcit.hxx
xftshit.hxx
xftshxy.hxx
xftstit.hxx
xgrscit.hxx
xhatch.hxx
xit.hxx
xlineit0.hxx
xlinjoit.hxx
xlnasit.hxx
xlncapit.hxx
xlnclit.hxx
xlndsit.hxx
xlnedcit.hxx
xlnedit.hxx
xlnedwit.hxx
xlnstcit.hxx
xlnstit.hxx
xlnstwit.hxx
xlntrit.hxx
xlnwtit.hxx
xmleohlp.hxx
xmlexchg.hxx
xmlgrhlp.hxx
xmlsecctrl.hxx
xoutbmp.hxx
xpoly.hxx	svx: prefix members of XPolygon	2024-09-16 16:17:39 +02:00
XPropertyEntry.hxx
xsflclit.hxx
xtable.hxx
xtextit0.hxx
zoom_def.hxx
zoomctrl.hxx
zoomsliderctrl.hxx
zoomslideritem.hxx