d1a2b80b9d
...as discussed in the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-November/086234.html> "Bump --enable-compiler-plugins Clang baseline?" (and now picked up again at <https://lists.freedesktop.org/archives/libreoffice/2022-February/088459.html> "Re: Bump --enable-compiler-plugins Clang baseline?"), and clean up compilerplugins/clang/ accordingly Change-Id: I5e81c6fdcc363aeefd6227606225b526fdf7ac16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
109 lines
2.9 KiB
C++
109 lines
2.9 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#ifndef LO_CLANG_SHARED_PLUGINS
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
#include <set>
|
|
#include "config_clang.h"
|
|
#include "plugin.hxx"
|
|
|
|
/**
|
|
Check for places where we declare a block directly inside a block
|
|
*/
|
|
namespace {
|
|
|
|
class BlockBlock:
|
|
public loplugin::FilteringPlugin<BlockBlock>
|
|
{
|
|
public:
|
|
explicit BlockBlock(loplugin::InstantiationData const & data):
|
|
FilteringPlugin(data) {}
|
|
|
|
virtual bool preRun() override
|
|
{
|
|
StringRef fn(handler.getMainFileName());
|
|
if (loplugin::isSamePathname(fn, SRCDIR "/sal/osl/unx/file_misc.cxx"))
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
void run() override {
|
|
if (preRun()) {
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
}
|
|
|
|
bool VisitCompoundStmt(CompoundStmt const * );
|
|
bool VisitCaseStmt(CaseStmt const * );
|
|
};
|
|
|
|
bool BlockBlock::VisitCompoundStmt(CompoundStmt const * compound)
|
|
{
|
|
if (ignoreLocation(compound))
|
|
return true;
|
|
if (compound->size() != 1)
|
|
return true;
|
|
auto inner = *compound->body_begin();
|
|
if (!isa<CompoundStmt>(inner))
|
|
return true;
|
|
if (compiler.getSourceManager().isMacroBodyExpansion(compound->getBeginLoc()))
|
|
return true;
|
|
if (compiler.getSourceManager().isMacroBodyExpansion(inner->getBeginLoc()))
|
|
return true;
|
|
if (containsPreprocessingConditionalInclusion(compound->getSourceRange())) {
|
|
return true;
|
|
}
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"block directly inside block",
|
|
compound->getBeginLoc())
|
|
<< compound->getSourceRange();
|
|
report(
|
|
DiagnosticsEngine::Note,
|
|
"inner block here",
|
|
inner->getBeginLoc())
|
|
<< inner->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
bool BlockBlock::VisitCaseStmt(CaseStmt const * caseStmt)
|
|
{
|
|
if (ignoreLocation(caseStmt))
|
|
return true;
|
|
auto compoundStmt = dyn_cast<CompoundStmt>(caseStmt->getSubStmt());
|
|
if (!compoundStmt)
|
|
return true;
|
|
if (compoundStmt->size() != 2)
|
|
return true;
|
|
auto it = compoundStmt->body_begin();
|
|
auto inner1 = *it;
|
|
if (!isa<CompoundStmt>(inner1))
|
|
return true;
|
|
++it;
|
|
if (!isa<BreakStmt>(*it))
|
|
return true;
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"block directly inside block",
|
|
compoundStmt->getBeginLoc())
|
|
<< compoundStmt->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration< BlockBlock > blockblock("blockblock", true);
|
|
|
|
}
|
|
|
|
#endif // LO_CLANG_SHARED_PLUGINS
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|