Test repository to check push and ssh key
Find a file
Caolán McNamara 186f8724fc cid#1465274 Dereference before null check
Change-Id: I40337228b8591ac4f5367e581a0d2fa7575f0143
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98623
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-13 16:09:17 +02:00
.git-hooks Fixup pre-commit hook to work with worktrees 2020-07-10 22:52:07 +02:00
.github
accessibility move CheckBox to toolkit-only headers 2020-07-12 20:28:56 +02:00
android android: fix the build output directory 2020-07-07 21:21:09 +02:00
animations
apple_remote
avmedia replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
basctl update pches 2020-07-12 12:20:05 +02:00
basegfx replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
basic update pches 2020-07-12 12:20:05 +02:00
bean
bin Fix typo 2020-07-12 18:20:42 +02:00
binaryurp replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
bridges
canvas tdf#134647 crash going to next slide on slideshow 2020-07-11 08:56:04 +02:00
chart2 tdf#134676 Chart OOXML import: fix X axis title width 2020-07-13 11:30:24 +02:00
cli_ure
codemaker
comphelper update pches 2020-07-12 12:20:05 +02:00
compilerplugins replace usage of whitelist with allowlist 2020-07-10 01:36:07 +02:00
config_host configure: add a --with-product-flavor switch 2020-07-01 16:35:13 +02:00
configmgr replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
connectivity tdf#42949 Fix IWYU warnings in include/[a-r]*/*hxx 2020-07-13 12:22:54 +02:00
cppcanvas update pches 2020-07-12 12:20:05 +02:00
cppu replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
cppuhelper update pches 2020-07-12 12:20:05 +02:00
cpputools
cui tdf#118148 Add extended tips to selectpathdialog.ui 2020-07-13 00:08:04 +02:00
dbaccess tdf#42949 Fix IWYU warnings in include/[a-r]*/*hxx 2020-07-13 12:22:54 +02:00
desktop desktop: separate executable shortcut for safe-mode 2020-07-13 10:53:12 +02:00
dictionaries@d4a80b15ed
distro-configs android: Add a CP x86 configuration too. 2020-07-01 18:00:09 +02:00
drawinglayer update pches 2020-07-12 12:20:05 +02:00
dtrans dtrans/mcnttype: create instances with uno constructors 2020-07-11 18:33:18 +02:00
editeng cid#1465259 silence Arguments in wrong order 2020-07-11 22:09:26 +02:00
embeddedobj replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
embedserv embedserv: create instances with uno constructors 2020-07-07 17:44:43 +02:00
emfio update pches 2020-07-12 12:20:05 +02:00
eventattacher eventattacher: create instances with uno constructors 2020-07-09 20:04:18 +02:00
extensions replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
external update pches 2020-07-12 12:20:05 +02:00
extras [pt-PT] Added 13 autocorrect words 2020-07-01 23:12:23 +02:00
filter Fix typo 2020-07-13 15:03:36 +02:00
forms update pches 2020-07-12 12:20:05 +02:00
formula formula: create instances with uno constructors 2020-07-07 22:01:33 +02:00
fpicker replace usage of blacklist with denylist 2020-07-10 01:34:54 +02:00
framework Removed duplicated include 2020-07-12 18:21:32 +02:00
helpcompiler replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
helpcontent2@d949d2a201 Update git submodules 2020-07-11 22:32:09 +02:00
hwpfilter
i18nlangtag
i18npool replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
i18nutil
icon-themes Colibre tdf#133268, Sukapura tdf#106229 2020-07-05 03:28:57 +02:00
idl
idlc
include drop m_xFormatter during dispose 2020-07-13 15:29:43 +02:00
instsetoo_native
io replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
ios
javaunohelper replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
jurt
jvmaccess replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
jvmfwk replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
l10ntools Upcoming improved loplugin:staticanonymous -> redundantstatic: l10ntools 2020-07-01 13:20:34 +02:00
librelogo
libreofficekit replace usage of whitelist with allowlist 2020-07-10 01:36:07 +02:00
lingucomponent replace usage of whitelist with allowlist 2020-07-10 01:36:07 +02:00
linguistic replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
lotuswordpro update pches 2020-07-12 12:20:05 +02:00
m4
nlpsolver
o3tl
odk Typo: pargraph->paragraph 2020-07-07 17:10:03 +02:00
offapi replace usage of whitelist with allowlist 2020-07-10 01:36:07 +02:00
officecfg tdf#67560: PNG export option Save transparency not remembered 2020-07-10 13:25:08 +02:00
onlineupdate
oovbaapi
oox tdf#134221 Fix SMARTART caption text location 2020-07-13 11:36:02 +02:00
opencl replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
osx
package update pches 2020-07-12 12:20:05 +02:00
pch
postprocess replace usage of blacklist with denylist 2020-07-10 01:34:54 +02:00
pyuno replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
qadevOOo
readlicense_oo
registry replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
remotebridges Upcoming improved loplugin:staticanonymous -> redundantstatic: remotebridges 2020-07-01 21:22:10 +02:00
reportbuilder
reportdesign update pches 2020-07-12 12:20:05 +02:00
ridljar
sal Allow making SAL_LOG based output fatal 2020-07-07 14:15:04 +02:00
salhelper
sax Upcoming improved loplugin:staticanonymous -> redundantstatic: sax 2020-07-01 21:29:44 +02:00
sc cid#1465274 Dereference before null check 2020-07-13 16:09:17 +02:00
scaddins replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
sccomp replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
schema
scp2 Add Turkish (tr) dictionary 2020-07-02 09:04:02 +02:00
scripting replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
sd Removed executable bit on pptx 2020-07-13 15:04:10 +02:00
sdext tdf#90978 add gap between the exit button and the right edge of the toolbar 2020-07-13 00:35:02 +02:00
setup_native Related: tdf#82184: consider installer language for UI list to install 2020-07-12 22:59:11 +02:00
sfx2 drop unneeded include line 2020-07-12 21:31:14 +02:00
shell replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
slideshow update pches 2020-07-12 12:20:05 +02:00
smoketest
solenv filter/config: create instances with uno constructors 2020-07-13 12:42:43 +02:00
soltools
sot update pches 2020-07-12 12:20:05 +02:00
starmath update pches 2020-07-12 12:20:05 +02:00
stoc replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
store replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
svgio update pches 2020-07-12 12:20:05 +02:00
svl update pches 2020-07-12 12:20:05 +02:00
svtools clarify what WantMouseEvent is for 2020-07-12 20:54:15 +02:00
svx don't grab focus if focus is already in a subcontrol 2020-07-13 15:29:20 +02:00
sw tdf#132483: DOCX import: fix OLE anchoring position 2020-07-13 15:47:15 +02:00
swext
sysui
test replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
testtools Upcoming improved loplugin:staticanonymous -> redundantstatic: testtools 2020-07-02 10:06:47 +02:00
toolkit move CheckBox to toolkit-only headers 2020-07-12 20:28:56 +02:00
tools replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
translations@cae548d4c0 Update git submodules 2020-07-02 21:29:34 +02:00
ucb replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
ucbhelper replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
udkapi
uitest uitest: Fix small issue in UI Logger DSL grammar "EditUIObject" 2020-07-03 11:46:38 +02:00
UnoControls replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
unodevtools Upcoming improved loplugin:staticanonymous -> redundantstatic: unodevtools 2020-07-02 13:16:27 +02:00
unoidl replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
unoil
unotest
unotools update pches 2020-07-12 12:20:05 +02:00
unoxml update pches 2020-07-12 12:20:05 +02:00
ure
uui update pches 2020-07-12 12:20:05 +02:00
vbahelper update pches 2020-07-12 12:20:05 +02:00
vcl drop m_xFormatter during dispose 2020-07-13 15:29:43 +02:00
winaccessibility
wizards
writerfilter tdf#132483: DOCX import: fix OLE anchoring position 2020-07-13 15:47:15 +02:00
writerperfect replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
xmerge
xmlhelp replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
xmloff update pches 2020-07-12 12:20:05 +02:00
xmlreader
xmlscript xmlscript: create instances with uno constructors 2020-07-06 20:17:26 +02:00
xmlsecurity update pches 2020-07-12 12:20:05 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in
config_host_lang.mk.in
configure.ac replace usage of blacklist with denylist 2020-07-10 01:34:54 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst
g
hardened_runtime.xcent.in
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in When cross-compiling to DESKTOP, just make "build" for the build platform 2020-07-06 01:07:35 +02:00
README.cross
README.md
README.Solaris
Repository.mk desktop: separate executable shortcut for safe-mode 2020-07-13 10:53:12 +02:00
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist replace usage of blacklist with denylist 2020-07-10 01:34:54 +02:00
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.4
  • macOS:
    • Runtime: 10.10
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.