1e92059fe9
In SdrPaintView (and subclasses) the mpModel variable is always the same as the input (reference) model, so there is no need for that extra variable. Change the strange and confusing var. name mrSdrModelFromSdrView (the input reference to SdrModel) to just mrModel and use that in GetModel(). Change the GetModel() to return a reference instead of a pointer and reactor the code to accomodate the change. This gets rid of many nullptr checks for the pointer that the GetModel() returns and makes the code more simple is some cases. Change-Id: I18351a417fd82f49262a83de036ec1420a65399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146373 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| source | ||
| uiconfig | ||
| workbench/addin | ||
| AllLangMoTarget_chart.mk | ||
| CppunitTest_chart2_common_functors.mk | ||
| CppunitTest_chart2_dialogs_test.mk | ||
| CppunitTest_chart2_dump.mk | ||
| CppunitTest_chart2_export.mk | ||
| CppunitTest_chart2_export2.mk | ||
| CppunitTest_chart2_export3.mk | ||
| CppunitTest_chart2_geometry.mk | ||
| CppunitTest_chart2_import.mk | ||
| CppunitTest_chart2_import2.mk | ||
| CppunitTest_chart2_pivot_chart_test.mk | ||
| CppunitTest_chart2_trendcalculators.mk | ||
| CppunitTest_chart2_uichart.mk | ||
| CppunitTest_chart2_xshape.mk | ||
| export_setup.mk | ||
| import_setup.mk | ||
| IwyuFilter_chart2.yaml | ||
| JunitTest_chart2_unoapi.mk | ||
| Library_chartcontroller.mk | ||
| Library_chartcore.mk | ||
| Makefile | ||
| Module_chart2.mk | ||
| README.md | ||
| UIConfig_chart2.mk | ||
Chart Implementation for LibreOffice Calc
The chart2 denotes a second generation re-write done to rid us of the
foul and twisted legacy chart code.
Debugging
Shortcuts
CTRL + F12 creates a layout dump based on the XShapeDumper based on SAL_WARN("chart2", ...