office-gobmx/compilerplugins/clang/charrightshift.cxx
Stephan Bergmann 5d546de67b Adapt to Clang 12 trunk RecursiveASTVisitor change
<https://github.com/llvm/llvm-project/commit/
5689b38c6a4220cc5f6ba68a56486229b10071bf> "Removed a RecursiveASTVisitor feature
to visit operator kinds with different methods".

That change is incompatible in that before the change individual TraverseUnary*
and TraverseBin* functions were called, while now TraverseUnaryOperator and
TraverseBinaryOperator/TraverseCompoundAssignOperator are called for all the
different operators.  Fixed that with a few #if for the non-shared plugins, but
that doesn't work for the shared plugin.  So made the two affected plugins non-
shared for now and left a better fix as a TODO.

Change-Id: I5b87d329ae2c4c93bf605bb1ecc9641039f014a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99000
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-19 23:05:57 +02:00

65 lines
2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include "check.hxx"
#include "plugin.hxx"
namespace {
class CharRightShift:
public loplugin::FilteringPlugin<CharRightShift>
{
public:
explicit CharRightShift(loplugin::InstantiationData const & data):
FilteringPlugin(data) {}
void run() override
{ TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitBinaryOperator(BinaryOperator const * expr) {
if (expr->getOpcode() != BO_Shr) {
return true;
}
if (ignoreLocation(expr)) {
return true;
}
auto t = expr->getLHS()->IgnoreParenImpCasts()->getType();
if (!loplugin::TypeCheck(t).Char()) {
return true;
}
if (!expr->getRHS()->getType()->isBuiltinType()) {
//TODO: in which case the expression should be an
// CXXOperatorCallExpr instead of a BinaryOperator? but at least
// recent Clang trunk reports
//
// '(' >> orExpression
//
// (connectivity/source/commontools/RowFunctionParser.cxx, the RHS
// being of type boost::spirit::rule<ScannerT>) here
return true;
}
report(
DiagnosticsEngine::Warning,
("right shift of %0 is implementation-defined when 'char' is signed"
" and value is negative"),
expr->getLHS()->getExprLoc())
<< t << expr->getSourceRange();
return true;
}
};
loplugin::Plugin::Registration<CharRightShift> charrightshift("charrightshift");
}
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */