office-gobmx/sw
Julien Nabet c6cc724d88 tdf#158323: CRASH when switch back from HTML to Normal View...
after edit in HTML code.

bt:
0  rtl::Reference<SfxStyleSheetPool>::get (this=0xb8) at include/rtl/ref.hxx:205
1  0x00007f4361f3857c in SwDocStyleSheetPool::GetEEStyleSheetPool (this=0x0) at sw/inc/docstyle.hxx:236
2  0x00007f4362dcb8e2 in SwPostItMgr::SwPostItMgr (this=0x558439087f60, pView=0x5584387f7e80) at /home/julien/lo/libreoffice/sw/source/uibase/docvw/PostItMgr.cxx:229
3  0x00007f43630e6b14 in SwView::SwView (this=0x5584387f7e80, _rFrame=..., pOldSh=0x5584356fa360) at /home/julien/lo/libreoffice/sw/source/uibase/uiview/view.cxx:1003
4  0x00007f43632fee79 in SwWebView::SwWebView (this=0x5584387f7e80, _rFrame=..., _pShell=0x5584356fa360) at /home/julien/lo/libreoffice/sw/source/uibase/web/wview.cxx:85
5  0x00007f43632feb51 in SwWebView::CreateInstance (rFrame=..., pOldView=0x5584356fa360) at /home/julien/lo/libreoffice/sw/source/uibase/web/wview.cxx:67
6  0x00007f4393710655 in SfxViewFactory::CreateInstance (this=0x558434c3a090, rFrame=..., pOldSh=0x5584356fa360) at /home/julien/lo/libreoffice/sfx2/source/view/viewfac.cxx:26
7  0x00007f4393501e31 in SfxBaseModel::createViewController
   (this=0x558431de5a80, i_rViewName="Default", i_rArguments=empty uno::Sequence, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5584360bf520)
   at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:4334
8  0x00007f4393502a3f in non-virtual thunk to SfxBaseModel::createViewController(rtl::OUString const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&, com::sun::uno::Reference<com::sun::frame::XFrame> const&) () at /home/julien/lo/libreoffice/instdir/program/libsfxlo.so
9  0x00007f43936b4ce4 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView
   (i_rModel=uno::Reference to (SwXTextDocument *) 0x558431de5b10, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5584360bf520, i_rViewFactoryArgs=..., i_rViewName="Default")
   at /home/julien/lo/libreoffice/sfx2/source/view/frmload.cxx:577
10 0x00007f43936b1f6c in (anonymous namespace)::SfxFrameLoader_Impl::load
   (this=0x558436633660, rArgs=uno::Sequence of length 18 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5584360bf520)
   at /home/julien/lo/libreoffice/sfx2/source/view/frmload.cxx:759
11 0x00007f439441ea51 in framework::LoadEnv::impl_loadContent (this=0x7ffdd69352c8) at /home/julien/lo/libreoffice/framework/source/loadenv/loadenv.cxx:1176
12 0x00007f439441b7d4 in framework::LoadEnv::start (this=0x7ffdd69352c8) at /home/julien/lo/libreoffice/framework/source/loadenv/loadenv.cxx:412

Regression from:
https://git.libreoffice.org/core/+/d934aeace6e7049db3959421538ae382cb97b1d1%5E%21
tdf#103064 sw,editeng: make para styles work inside comments

Change-Id: Ib9a1c9fe779ad14f93de0e1b3645beddb85e511d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174210
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-30 08:45:19 +02:00
..
documentation/writerfilter
inc tdf#162855 Draw a guide line while resizing the comment sidebar 2024-09-27 19:44:17 +02:00
qa tdf#163154 revert "tdf120224 writerfilter: consume excess bookmark 2024-09-28 20:46:42 +02:00
sdi Fix typo 2024-09-27 23:31:49 +02:00
source tdf#158323: CRASH when switch back from HTML to Normal View... 2024-09-30 08:45:19 +02:00
uiconfig tdf#132274 follow-up fix 2024-09-26 20:48:02 +02:00
util
AllLangMoTarget_sw.mk
CppunitTest_sw_a11y.mk
CppunitTest_sw_accessible_relation_set.mk
CppunitTest_sw_apiterminate.mk
CppunitTest_sw_apitests.mk
CppunitTest_sw_autocorrect.mk
CppunitTest_sw_core_accessibilitycheck.mk
CppunitTest_sw_core_attr.mk
CppunitTest_sw_core_crsr.mk
CppunitTest_sw_core_doc.mk
CppunitTest_sw_core_docnode.mk
CppunitTest_sw_core_draw.mk
CppunitTest_sw_core_edit.mk
CppunitTest_sw_core_fields.mk
CppunitTest_sw_core_frmedt.mk
CppunitTest_sw_core_header_footer.mk
CppunitTest_sw_core_layout.mk
CppunitTest_sw_core_objectpositioning.mk
CppunitTest_sw_core_text.mk
CppunitTest_sw_core_theme.mk tdf#162715: do not import theme when pasting from clipboard 2024-08-31 12:05:10 +02:00
CppunitTest_sw_core_tox.mk
CppunitTest_sw_core_txtnode.mk
CppunitTest_sw_core_undo.mk
CppunitTest_sw_core_unocore.mk
CppunitTest_sw_core_view.mk
CppunitTest_sw_dialogs_test.mk
CppunitTest_sw_dialogs_test_2.mk
CppunitTest_sw_docbookexport.mk
CppunitTest_sw_filter_ascii.mk
CppunitTest_sw_filter_html.mk
CppunitTest_sw_filter_ww8.mk
CppunitTest_sw_filter_xml.mk
CppunitTest_sw_filters_test.mk
CppunitTest_sw_fodfexport.mk
CppunitTest_sw_globalfilter.mk
CppunitTest_sw_htmlexport.mk
CppunitTest_sw_htmlimport.mk
CppunitTest_sw_indexingexport.mk
CppunitTest_sw_layoutwriter.mk
CppunitTest_sw_layoutwriter2.mk
CppunitTest_sw_layoutwriter3.mk
CppunitTest_sw_macros_test.mk
CppunitTest_sw_mailmerge.mk
CppunitTest_sw_mailmerge2.mk
CppunitTest_sw_odfexport.mk
CppunitTest_sw_odfexport2.mk
CppunitTest_sw_odffeatures.mk
CppunitTest_sw_odfimport.mk
CppunitTest_sw_ooxml_theme_export.mk
CppunitTest_sw_ooxmlencryption.mk
CppunitTest_sw_ooxmlexport.mk
CppunitTest_sw_ooxmlexport2.mk
CppunitTest_sw_ooxmlexport3.mk
CppunitTest_sw_ooxmlexport4.mk
CppunitTest_sw_ooxmlexport5.mk
CppunitTest_sw_ooxmlexport6.mk
CppunitTest_sw_ooxmlexport7.mk
CppunitTest_sw_ooxmlexport8.mk
CppunitTest_sw_ooxmlexport9.mk
CppunitTest_sw_ooxmlexport10.mk
CppunitTest_sw_ooxmlexport11.mk
CppunitTest_sw_ooxmlexport12.mk
CppunitTest_sw_ooxmlexport13.mk
CppunitTest_sw_ooxmlexport14.mk
CppunitTest_sw_ooxmlexport15.mk
CppunitTest_sw_ooxmlexport16.mk
CppunitTest_sw_ooxmlexport17.mk
CppunitTest_sw_ooxmlexport18.mk
CppunitTest_sw_ooxmlexport19.mk
CppunitTest_sw_ooxmlexport20.mk
CppunitTest_sw_ooxmlexport21.mk
CppunitTest_sw_ooxmlexport_template.mk
CppunitTest_sw_ooxmlfieldexport.mk
CppunitTest_sw_ooxmlimport.mk
CppunitTest_sw_ooxmlimport2.mk
CppunitTest_sw_ooxmllinks.mk
CppunitTest_sw_ooxmlw14export.mk
CppunitTest_sw_pdf_test.mk
CppunitTest_sw_rtfexport.mk
CppunitTest_sw_rtfexport2.mk
CppunitTest_sw_rtfexport3.mk
CppunitTest_sw_rtfexport4.mk
CppunitTest_sw_rtfexport5.mk
CppunitTest_sw_rtfexport6.mk
CppunitTest_sw_rtfexport7.mk
CppunitTest_sw_rtfexport8.mk
CppunitTest_sw_rtfimport.mk
CppunitTest_sw_tiledrendering.mk
CppunitTest_sw_tiledrendering2.mk
CppunitTest_sw_txtencexport.mk
CppunitTest_sw_txtexport.mk
CppunitTest_sw_txtimport.mk
CppunitTest_sw_uibase_dialog.mk
CppunitTest_sw_uibase_dochdl.mk
CppunitTest_sw_uibase_docvw.mk
CppunitTest_sw_uibase_fldui.mk
CppunitTest_sw_uibase_frmdlg.mk
CppunitTest_sw_uibase_shells.mk
CppunitTest_sw_uibase_uiview.mk
CppunitTest_sw_uibase_unit.mk
CppunitTest_sw_uibase_uno.mk
CppunitTest_sw_uibase_wrtsh.mk
CppunitTest_sw_uiwriter.mk
CppunitTest_sw_uiwriter2.mk
CppunitTest_sw_uiwriter3.mk
CppunitTest_sw_uiwriter4.mk
CppunitTest_sw_uiwriter5.mk
CppunitTest_sw_uiwriter6.mk
CppunitTest_sw_uiwriter7.mk
CppunitTest_sw_uiwriter8.mk
CppunitTest_sw_uiwriter9.mk
CppunitTest_sw_unowriter.mk
CppunitTest_sw_uwriter.mk
CppunitTest_sw_writerfilter_dmapper.mk
CppunitTest_sw_writerfilter_filter.mk
CppunitTest_sw_writerfilter_filters_test.mk
CppunitTest_sw_writerfilter_misc.mk
CppunitTest_sw_writerfilter_ooxml.mk
CppunitTest_sw_writerfilter_rtftok.mk
CppunitTest_sw_ww8export.mk
CppunitTest_sw_ww8export2.mk
CppunitTest_sw_ww8export3.mk
CppunitTest_sw_ww8export4.mk
CppunitTest_sw_ww8import.mk
CppunitTest_sw_xhtmlexport.mk
CustomTarget_generated.mk
CustomTarget_source.mk
IwyuFilter_sw.yaml
JunitTest_sw_complex.mk
JunitTest_sw_unoapi_1.mk
JunitTest_sw_unoapi_2.mk
JunitTest_sw_unoapi_3.mk
JunitTest_sw_unoapi_4.mk
layoutwriter_setup.mk
Library_msword.mk
Library_sw.mk sw: add Comments Panel in sidebar 2024-09-13 12:35:45 +02:00
Library_sw_writerfilter.mk
Library_swd.mk
Library_swqahelper.mk
Library_swui.mk
Library_vbaswobj.mk
Makefile
Module_sw.mk
ooxmlexport_setup.mk
PythonTest_sw_python.mk
README.md
README.writerfilter.md
rtfexport_setup.mk
UIConfig_sglobal.mk
UIConfig_sweb.mk
UIConfig_swform.mk
UIConfig_swreport.mk
UIConfig_swriter.mk add context menu for comments & some other changes 2024-09-19 13:55:56 +02:00
UIConfig_swxform.mk
UITest_chapterNumbering.mk
UITest_classification.mk
UITest_librelogo.mk
UITest_sw_chart.mk
UITest_sw_fieldDialog.mk
UITest_sw_findBar.mk
UITest_sw_findReplace.mk
UITest_sw_navigator.mk
UITest_sw_options.mk
UITest_sw_sidebar.mk
UITest_sw_styleInspector.mk
UITest_sw_table.mk
UITest_sw_ui_fmtui.mk
UITest_sw_ui_frmdlg.mk
UITest_sw_ui_index.mk
UITest_sw_ui_misc.mk
UITest_sw_uibase_docvw.mk
UITest_sw_uibase_shells.mk
UITest_writer_dialogs.mk
UITest_writer_macro_tests.mk
UITest_writer_tests.mk
UITest_writer_tests2.mk
UITest_writer_tests3.mk
UITest_writer_tests4.mk
UITest_writer_tests5.mk
UITest_writer_tests6.mk
UITest_writer_tests7.mk
UITest_writer_tests8.mk
uiwriter_setup.mk
ww8export_setup.mk

Writer Application Code

Exact history was lost before Sept. 18th, 2000, but old source code comments show that Writer core dates back until at least November 1990.

Module Contents

  • inc: headers available to all source files inside the module
  • qa: unit, slow and subsequent tests
  • sdi
  • source: see below
  • uiconfig: user interface configuration
  • util: UNO passive registration config

Source Contents

  • core: Writer core (document model, layout, UNO API implementation)
  • filter: Writer internal filters
    • ascii: plain text filter
    • basflt
    • docx: wrapper for the UNO DOCX import filter (in writerfilter) for autotext purposes
    • html: HTML filter
    • inc: include files for filters
    • rtf: thin copy&paste helper around the UNO RTF import filter (in writerfilter)
    • writer
    • ww8: DOC import, DOC/DOCX/RTF export
    • xml: ODF import/export, subclassed from xmloff (where most of the work is done)
  • uibase: user interface (those parts that are linked into sw & always loaded)
  • ui: user interface (optional parts that are loaded on demand (swui))

Core

There is a good overview documentation of basic architecture of Writer core in the OOo wiki:

Writer specific WhichIds are defined in sw/inc/hintids.hxx.

The details below are mainly about details missing from the wiki pages.

SwDoc

The central class for a document is SwDoc, which represents a document.

A lot of the functionality is split out into separate Manager classes, each of which implements some IDocument* interface; there are SwDoc::getIDocument*() methods to retrieve the managers.

However there are still too many members and methods in this class, many of which could be moved to some Manager or other...

SwNodes

Basically a (fancy) array of SwNode pointers. There are special subclasses of SwNode (SwStartNode and SwEndNode) which are used to encode a nested tree structure into the flat array; the range of nodes from SwStartNode to its corresponding SwEndNode is sometimes called a "section" (but is not necessarily what the high-level document model calls a "Section"; that is just one of the possibilities).

The SwNodes contains the following top-level sections:

  1. Empty
  2. Footnote content
  3. Frame / Header / Footer content
  4. Deleted Change Tracking content
  5. Body content

Undo

The Undo/Redo information is stored in a sw::UndoManager member of SwDoc, which implements the IDocumentUndoRedo interface. Its members include a SwNodes array containing the document content that is currently not in the actual document but required for Undo/Redo, and a stack of SwUndo actions, each of which represents one user-visible Undo/Redo step.

There are also ListActions which internally contain several individual SwUndo actions; these are created by the StartUndo/EndUndo wrapper methods.

Text Attributes

The sub-structure of paragraphs is stored in the SwpHintsArray member SwTextNode::m_pSwpHints. There is a base class SwTextAttr with numerous subclasses; the SwTextAttr has a start and end index and a SfxPoolItem to store the actual formatting attribute.

There are several sub-categories of SwTextAttr:

  • formatting attributes: Character Styles (SwTextCharFormat, RES_TXTATR_CHARFMT) and Automatic Styles (no special class, RES_TXTATR_AUTOFMT): these are handled by SwpHintsArray::BuildPortions and MergePortions, which create non-overlapping portions of formatting attributes.

  • nesting attributes: Hyperlinks (SwTextINetFormat, RES_TXTATR_INETFMT), Ruby (SwTextRuby, RES_TXTATR_CJK_RUBY) and Meta/MetaField (SwTextMeta, RES_TXTATR_META/RES_TXTATR_METAFIELD): these maintain a properly nested tree structure. The Meta/Metafield are "special" because they have both start/end and a dummy character at the start.

  • misc. attributes: Reference Marks, ToX Marks

  • attributes without end: Fields, Footnotes, Flys (AS_CHAR) These all have a corresponding dummy character in the paragraph text, which is a placeholder for the "expansion" of the attribute, e.g. field content.

Fields

There are multiple model classes involved for fields:

  • enum SwFieldIds enumerates the different types of fields.
  • SwFieldType contains some shared stuff for all fields of a type. There are many subclasses of SwFieldType, one for each different type of field. For most types of fields there is one shared instance of this per type, which is created in DocumentFieldsManager::InitFieldTypes() but for some there are more than one, and they are dynamically created, see DocumentFieldsManager::InsertFieldType(). An example for the latter are variable fields (SwFieldIds::GetExp/SwFieldIds::SetExp), with one SwFieldType per variable.
  • SwXFieldMaster is the UNO wrapper of a field type. It is a SwClient registered at the SwFieldType. Its life-cycle is determined by UNO clients outside of sw; it will get disposed when the SwFieldType dies.
  • SwFormatField is the SfxPoolItem of a field. The SwFormatField is a SwClient registered at its SwFieldType. The SwFormatField owns the SwField of the field.
  • SwField contains the core logic of a field. The SwField is owned by the SwFormatField of the field. There are many subclasses of SwField, one for each different type of field. Note that there are not many places that can Expand the field to its correct value, since for example page number fields require a View with an up to date layout; therefore the correct expansion is cached.
  • SwTextField is the text attribute of a field. It owns the SwFormatField of the field (like all text attributes).
  • SwXTextField is the UNO wrapper object of a field. It is a SwClient registered at the SwFormatField. Its life-cycle is determined by UNO clients outside of sw; it will get disposed when the SwFormatField dies.

Lists

  • SwNumFormat (subclass of SvxNumFormat) determines the formatting of a single numbering level.

  • SwNumRule (NOT a subclass of SvxNumRule) is a list style, containing one SwNumFormat per list level. SwNumRule::maTextNodeList is the list of SwTextNode that have this list style applied.

  • SwNumberTreeNode is a base class that represents an abstract node in a hierarchical tree of numbered nodes.

  • SwNodeNum is the subclass of SwNumberTreeNode that connects it with an actual SwTextNode and also with a SwNumRule; SwTextNode::mpNodeNum points back in the other direction

  • SwList represents a list, which is (mostly) a vector of SwNodeNum trees, one per SwNodes top-level section (why that?).

  • IDocumentListsAccess, sw::DocumentListsManager owns all SwList instances, and maintains mappings:

    • from list-id to SwList
    • from list style name to SwList (the "default" SwList for that list style)
  • IDocumentListItems, sw::DocumentListItemsManager contains a set of all SwNodeNum instances, ordered by SwNode index

  • the special Outline numbering rule: SwDoc::mpOutlineRule

  • IDocumentOutlineNodes, sw::DocumentOutlineNodesManager maintain a list (which is actually stored in SwNodes::m_pOutlineNodes) of SwTextNodes that either have the Outline numrule applied, or have the RES_PARATR_OUTLINELEVEL item set (note that in the latter case, the SwTextNode does not have a SwNodeNum and is not associated with the SwDoc::mpOutlineRule).

  • SwTextNodes and paragraph styles have items/properties:

    • RES_PARATR_OUTLINELEVEL/"OutlineLevel" to specify an outline level without necessarily having the outline SwNumRule assigned
    • RES_PARATR_NUMRULE/"NumberingStyleName" the list style to apply; may be empty "" which means no list style (to override inherited value) Only SwTextNode has these items:
    • RES_PARATR_LIST_ID/"ListId" determines the SwList to which the node is added
    • RES_PARATR_LIST_LEVEL/"NumberingLevel" the level at which the SwTextNode will appear in the list
    • RES_PARATR_LIST_ISRESTART/"ParaIsNumberingRestart" restart numbering sequence at this SwTextNode
    • RES_PARATR_LIST_RESTARTVALUE/"NumberingStartValue" restart numbering sequence at this SwTextNode with this value
    • RES_PARATR_LIST_ISCOUNTED/"NumberingIsNumber" determines if the node is actually counted in the numbering sequence; these are different from "phantoms" because there's still a SwTextNode.

Note that there is no UNO service to represent a list.

Layout

The layout is a tree of SwFrame subclasses, the following relationships are possible between frames:

  • You can visit the tree by following the upper, lower, next and previous pointers.
  • The functionality of flowing of a frame across multiple parents (e.g. pages) is implemented in SwFlowFrame, which is not an SwFrame subclass. The logical chain of such frames can be visited using the follow and precede pointers. ("Leaf" is a term that refers to such a relationship.)
  • In case a frame is split into multiple parts, then the first one is called master, while the others are called follows.