5dd814f13d
After some experiments I now can remove DirectPutItemInPool and DirectRemoveItemFromPool. With the changes done before it is now possible to get rid of this 'compromize'. Now there are no more Items held at the 'Pool' which now can be developed in the direction of ssth like 'SfxItemSupport' - what it really is. Some of the last usages of DirectPutItemInPool were in SvxAreaTabDialog::SavePalettes(), so I tried to trigger those cases with using LO and calling that Dialog in all situations I could possibly think about, but it was never used. Then I added asserts and run a UnitTests in the apps, also no luck. Thus I would guess these are not used. These put changed stuff from the Dialog 'directly' to the Pool (what is not really supported and is a hint for a 'compromize' that some functionality did not find/want to use the right spot in the model to save and hold that data). Thus it *would* be accessible using the SurrogateMechanism at the Pool (which is also a 'compromize', see some of my other commits), but I also found no hints at places where that is done. Thus I decided to create this change and let's see if that asserts ever get triggered in the builds or tests. Indeed did not trigger. I checked what other places do which use SfxObjectShell::Current() when they get no DocShell: Most avoid doing something, but none puts stuff to the Pool, so I go one step further and do what other places do: warn and return. Also simplified SvxAreaTabDialog::SavePalettes() as then feasible. Change-Id: I1c351eac4ada26288a56a69d57008a09f2d19121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162340 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| source | ||
| uiconfig/ui | ||
| util | ||
| AllLangMoTarget_cui.mk | ||
| CppunitTest_cui_dialogs_test.mk | ||
| CppunitTest_cui_dialogs_test_2.mk | ||
| CppunitTest_cui_dialogs_test_3.mk | ||
| CppunitTest_cui_dialogs_test_4.mk | ||
| IwyuFilter_cui.yaml | ||
| Library_cui.mk | ||
| Makefile | ||
| Module_cui.mk | ||
| Package_cui.mk | ||
| README.md | ||
| UIConfig_cui.mk | ||
| UITest_cui_dialogs.mk | ||
| UITest_cui_tabpages.mk | ||
Common User Interface (cui)
It was moved out from svx in DEV300m68:
http://www.mail-archive.com/dev@openoffice.org/msg12925.html
It contains dialogs used by more than one application, e.g. paragraph properties.