office-gobmx/vcl
Mike Kaganski c28b328643 Fix row/column pre-initialization in stack blur
The changed code is used to initialize data before processing first
pixel of each row/column of the bitmap, since in order to blur it,
we need some information about assumed previous pixels. But previous
code assumed that information for the first pixel or each row and
each column is taken from first pixels of first column, not from
first pixels of respective row or respective column. This doesn't
make practical difference for the pre-extended bitmap with a solid
color of the border (see centerExtendBitmap; it's the only actual
case ATM). But in case of not pre-extended bitmap with non-solid
border color, that would result in wrong blur of first pixels.

Consider this bitmap (* is white, 0 is black):

    *00000000
    *00000000
    *00000000
    *00000000
    *00000000
    000000000
    ...

For this bitmap, existing code pre-initialized each row and each
column as if it were prepended with "******" from column 0, and so
each first pixel of each column and each row would be blurred with
white, even where it's all black (consider columns >=1, and rows
>=5).

Additionally, the existing initialization assumed that there's
always at least as many scanlines as min(radius, bmpWidth), which
might be false. See how aArrays was initialized using nLastIndexX
in stackBlurHorizontal, and then that value affected the index
passed to pReadAccess->GetScanline.

This changes the code to consistently consider first pixels of
respective rows/columns for pre-initialization data.

Change-Id: Ibe3be8750fe5347302eca782a00b36096d99820c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93118
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-29 10:40:01 +02:00
..
android
backendtest SalInvert::N50 has 1x1 pixel checker size, not 2x2 (tdf#131580) 2020-04-01 11:25:59 +02:00
headless tdf#130924 [vcl] replace *printfs with SAL_* logging macros. 2020-04-20 10:24:18 +02:00
inc ImpGraphic: rename ImplCreateSwapInfo and simplify 2020-04-27 06:57:07 +02:00
ios
null
opengl no gray conversion needed for VCL alpha hacks 2020-04-07 11:53:54 +02:00
osx tf#131549 No titlebar on modal dialogs on macOS 2020-04-25 22:30:34 +02:00
qa Fix typos 2020-04-28 17:29:33 +02:00
qt5 Qt5 implement DELETE_ITEMS action in file picker 2020-04-14 19:35:51 +02:00
quartz Fix typos 2020-04-28 20:04:35 +02:00
skia debug info for Skia Windows widget drawing 2020-04-24 17:58:32 +02:00
source Fix row/column pre-initialization in stack blur 2020-04-29 10:40:01 +02:00
uiconfig Fix for print dialog 2020-04-25 09:23:12 +02:00
unx weld SfxTemplatePanelControl 2020-04-29 09:46:08 +02:00
win tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/ 2020-04-22 15:36:50 +02:00
workben rename vcl::Window::Update to PaintImmediately 2020-04-11 17:56:01 +02:00
AllLangMoTarget_vcl.mk
commonfuzzer.mk missing separator 2020-04-22 12:43:22 +02:00
CppunitTest_vcl_apitests.mk
CppunitTest_vcl_app_test.mk
CppunitTest_vcl_backend_test.mk
CppunitTest_vcl_bitmap_render_test.mk
CppunitTest_vcl_bitmap_test.mk
CppunitTest_vcl_bitmapprocessor_test.mk
CppunitTest_vcl_blocklistparser_test.mk
CppunitTest_vcl_complextext.mk
CppunitTest_vcl_dialogs_test.mk
CppunitTest_vcl_errorhandler.mk
CppunitTest_vcl_filters_test.mk
CppunitTest_vcl_font.mk
CppunitTest_vcl_fontcharmap.mk
CppunitTest_vcl_fontfeature.mk
CppunitTest_vcl_fontmetric.mk
CppunitTest_vcl_gen.mk
CppunitTest_vcl_graphic_test.mk vcl: add tests for GraphicNativeMetadata 2020-04-27 06:57:28 +02:00
CppunitTest_vcl_jpeg_read_write_test.mk
CppunitTest_vcl_lifecycle.mk
CppunitTest_vcl_mnemonic.mk
CppunitTest_vcl_outdev.mk
CppunitTest_vcl_pdfexport.mk
CppunitTest_vcl_png_test.mk
CppunitTest_vcl_svm_test.mk
CppunitTest_vcl_timer.mk
CppunitTest_vcl_type_serializer_test.mk
CppunitTest_vcl_widget_definition_reader_test.mk
CustomTarget_gtk3_kde5_moc.mk
CustomTarget_kf5_moc.mk
CustomTarget_nativecalc.mk
CustomTarget_nativecore.mk
CustomTarget_nativedraw.mk
CustomTarget_nativemath.mk
CustomTarget_nativewriter.mk
CustomTarget_qt5_moc.mk
Executable_602fuzzer.mk
Executable_bmpfuzzer.mk
Executable_cgmfuzzer.mk
Executable_diffuzzer.mk
Executable_docxfuzzer.mk
Executable_dxffuzzer.mk
Executable_epsfuzzer.mk
Executable_fftester.mk
Executable_fodpfuzzer.mk
Executable_fodsfuzzer.mk
Executable_fodtfuzzer.mk fix oss-fuzz build 2020-04-28 09:43:29 +02:00
Executable_giffuzzer.mk
Executable_htmlfuzzer.mk
Executable_hwpfuzzer.mk
Executable_icontest.mk
Executable_jpgfuzzer.mk
Executable_lo_kde5filepicker.mk
Executable_lwpfuzzer.mk
Executable_metfuzzer.mk
Executable_mmlfuzzer.mk
Executable_mtfdemo.mk
Executable_mtpfuzzer.mk
Executable_olefuzzer.mk
Executable_pcdfuzzer.mk
Executable_pctfuzzer.mk
Executable_pcxfuzzer.mk
Executable_pngfuzzer.mk
Executable_ppmfuzzer.mk
Executable_pptfuzzer.mk
Executable_pptxfuzzer.mk
Executable_psdfuzzer.mk
Executable_qpwfuzzer.mk
Executable_rasfuzzer.mk
Executable_rtffuzzer.mk
Executable_scrtffuzzer.mk
Executable_sftfuzzer.mk
Executable_slkfuzzer.mk
Executable_svdemo.mk
Executable_svmfuzzer.mk
Executable_svpclient.mk
Executable_svptest.mk
Executable_tgafuzzer.mk
Executable_tiffuzzer.mk
Executable_ui-previewer.mk
Executable_vcldemo.mk
Executable_visualbackendtest.mk
Executable_wksfuzzer.mk
Executable_wmffuzzer.mk
Executable_ww2fuzzer.mk
Executable_ww6fuzzer.mk
Executable_ww8fuzzer.mk
Executable_xbmfuzzer.mk
Executable_xlsfuzzer.mk
Executable_xlsxfuzzer.mk
Executable_xpmfuzzer.mk
IwyuFilter_vcl.yaml
Library_desktop_detector.mk
Library_vcl.mk loplugin:unusedenumconstants BmpConversion 2020-04-24 13:37:12 +02:00
Library_vclplug_gen.mk
Library_vclplug_gtk3.mk
Library_vclplug_gtk3_kde5.mk
Library_vclplug_kf5.mk
Library_vclplug_osx.mk
Library_vclplug_qt5.mk
Library_vclplug_win.mk
Makefile
Module_vcl.mk
Package_fontunxppds.mk
Package_fontunxpsprint.mk
Package_opengl_blacklist.mk
Package_opengl_shader.mk
Package_osxres.mk
Package_skia_blacklist.mk
Package_theme_definitions.mk
Package_tipoftheday.mk
README
README.GDIMetaFile
README.lifecycle
README.scheduler
README.vars
StaticLibrary_fuzzer_calc.mk
StaticLibrary_fuzzer_core.mk
StaticLibrary_fuzzer_draw.mk
StaticLibrary_fuzzer_math.mk
StaticLibrary_fuzzer_writer.mk
StaticLibrary_fuzzerstubs.mk
StaticLibrary_glxtest.mk
StaticLibrary_vclmain.mk
UIConfig_vcl.mk tdf#131120 use a replacement for GtkComboBox 2020-04-16 20:28:24 +02:00
vcl.android.component
vcl.common.component
vcl.headless.component
vcl.ios.component
vcl.macosx.component org.libreoffice.uitest.UITest missing from vcl.macosx.component 2020-03-30 14:44:54 +02:00
vcl.unx.component
vcl.windows.component
WinResTarget_vcl.mk

Visual Class Library is responsible for the widgets (windowing, buttons, controls, file-pickers etc.), operating system abstraction, including basic rendering (e.g. the output device).

It should not be confused with Borland's Visual Component Library, which is entirely unrelated.

VCL provides a graphical toolkit similar to gtk+, Qt, SWING etc.

source/
	+ the main cross-platform chunk of source

inc/
	+ cross-platform abstraction headers

headless/
	+ a backend renderer that draws to bitmaps

android/
	+ Android backend

osx/
	+ macOS backend

ios/
	+ iOS backend

quartz/
	+ code common to macOS and iOS

win/
	+ Windows backend

qt5/
	+ Qt5 (under construction)

unx/
	+ X11 backend and its sub-platforms
	gtk3/
		+ GTK3 support
	kf5/
		+ KF5 support (based on qt5 VCL plugin mentioned above)
	gtk3_kde5/
		+ GTK3 support with KDE5 file pickers (alternative to native kf5 one)
	generic/
		+ raw X11 support

		plugadapt/
			+ pluggable framework to select correct unx backend

		dtrans/
			+ "data transfer" - clipboard handling
			+ http://stackoverflow.com/questions/3261379/getting-html-source-or-rich-text-from-the-x-clipboard
			  for tips how to show the current content of the
			  clipboard


How the platform abstraction works

	+ InitVCL calls 'CreateSalInstance'
		+ this is implemented by the compiled-in platform backend
		+ it stores various bits of global state in the
		  'SalData' (inc/saldatabasic.hxx) structure but:
	+ the SalInstance vtable is the primary outward facing gateway
	  API for platform backends
		+ It is a factory for:
		  SalFrames, SalVirtualDevices, SalPrinters,
		  Timers, the SolarMutex, Drag&Drop and other
		  objects, as well as the primary event loop wrapper.

Note: references to "SV" in the code mean StarView, which was a
portable C++ class library for GUIs, with very old roots, that was
developed by StarDivision. Nowadays it is not used by anything except
LibreOffice (and OpenOffice).

"svp" stands for "StarView Plugin".

== COM threading ==

The way COM is used in LO generally:
- vcl puts main thread into Single-threaded Apartment (STA)
- oslWorkerWrapperFunction() puts every thread spawned via oslCreateThread()
  into MTA (free-threaded)

== GDIMetafile ==

GDIMetafile is a vector drawing representation that corresponds directly
to the SVM (StarView Metafile) format; it is extremely important as
an intermediate format in all sorts of drawing and printing operations.

There is a class MetafileXmlDump in include/vcl/mtfxmldump.hxx that
can store a GDIMetafile as XML, which makes debugging much easier
since you can just use "diff" to see changes.

== EMF+ ==

emf+ is vector file format used by MSO and is successor of wmf and
emf formats. see
http://msdn.microsoft.com/en-us/library/cc230724.aspx for
documentation. note that we didn't have this documentation from
start, so part of the code predates to the time when we had guessed
some parts and can be enhanced today. there also still many thing not
complete

emf+ is handled a bit differently compared to original emf/wmf files,
because GDIMetafile is missing features we need (mostly related to
transparency, argb colors, etc.)

emf/wmf is translated to GDIMetafile in import filter
vcl/source/filter/wmf and so special handling ends here

emf+ is encapsulated into GDIMetafile inside comment records and
parsed/rendered later, when it reaches cppcanvas. It is parsed and
rendered in cppcanvas/source/mtfrenderer. also note that there are
emf+-only and emf+-dual files. dual files contains both types of
records (emf and emf+) for rendering the images. these can used also
in applications which don't know emf+. in that case we must ignore
emf records and use emf+ for rendering. for more details see
documentation

parsing:

 wmf/emf filter --> GDI metafile with emf+ in comments --> cppcanvas metafile renderer

lately the GDIMetafile rendering path changed which also influenced
emf+ rendering. now many things happen in drawing layer, where
GDIMetafile is translated into drawing layer primitives. for
metafiles with emf+ we let the mtfrenderer render them into bitmap
(with transparency) and use this bitmap in drawinlayer. cleaner
solution for current state would be to extend the drawing layer for
missing features and move parsing into drawing layer (might be quite
a lot of work). intermediary enhancement would be to know better the
needed size/resolution of the bitmap, before we render emf+ into
bitmap in drawing layer. Thorsten is working on the same problem with
svg rendering, so hopefully his approach could be extended for emf+ as
well. the places in drawing layer where we use canvas mtfrenderer to
render into bitmaps can be found when you grep for GetUseCanvas. also
look at vcl/source/gdi/gdimetafile.cxx where you can look for
UseCanvas again. moving the parsing into drawinglayer might also have
nice side effect for emf+-dual metafiles. in case the emf+ records
are broken, it would be easier to use the duplicit emf
rendering. fortunately we didn't run into such a broken emf+ file
yet. but there were already few cases where we first though that the
problem might be because of broken emf+ part. so far it always turned
out to be another problem.

rendering:

 before

 vcl --> cppcanvas metafile renderer --> vcl

 now

 drawing layer --> vcl --> cppcanvas metafile renderer --> vcl --> drawing layer

another interesting part is actual rendering into canvas bitmap and
using that bitmap later in code using vcl API.

EMF+ implementation has some extensive logging, best if you do a dbgutil
build, and then

export SAL_LOG=+INFO.cppcanvas.emf+INFO.vcl.emf

before running LibreOffice; it will give you lots of useful hints.

You can also fallback to EMF (from EMF+) rendering via

export EMF_PLUS_DISABLE=1


== Printing/PDF export ==

Printing from Writer works like this:

1) individual pages print by passing an appropriate OutputDevice to XRenderable
2) in drawinglayer, a VclMetafileProcessor2D is used to record everything on
   the page (because the OutputDevice has been set up to record a GDIMetaFile)
3) the pages' GDIMetaFiles are converted to PDF by the vcl::PDFWriter
   in vcl/source/gdi/pdfwriter*

Creating the ODF thumbnail for the first page works as above except step 3 is:

3) the GDIMetaFile is replayed to create the thumbnail

On-screen display differs in step 1 and 2:

1) the VCL Window gets invalidated somehow and paints itself
2) in drawinglayer, a VclPixelProcessor2D is used to display the content


=== Debugging PDF export ===

Debugging the PDF export becomes much easier when
compression is disabled (so the PDF file is directly readable) and
the MARK function puts comments into the PDF file about which method
generated the following PDF content.

The compression can be disabled even using an env. var:

export VCL_DEBUG_DISABLE_PDFCOMPRESSION=1

To de-compress the contents of a PDF file written by a release build or
other programs, use the "pdfunzip" tool:

bin/run pdfunzip input.pdf output.pdf

=== SolarMutexGuard ===

The solar mutex is the "big kernel lock" of LibreOffice, a global one. It's a
recursive mutex, so it's allowed to take the lock on the same thread multiple
times, and only the last unlock will actually release the mutex.

UNO methods on components can be called from multiple threads, while the
majority of the codebase is not prepared for multi-threading. One way to get
around this mismatch is to create a SolarMutexGuard instance at the start of
each & every UNO method implementation, but only when it is necessary:

- Only acquire the SolarMutex if you actually need it (e.g., not in functions
  that return static information).

- Only around the code that actually needs it (i.e., never call out with it
  locked).

This way you ensure that code (not prepared for multithreading) is still
executed only on a single thread.

In case you expect that your caller takes the solar mutex, then you can use
the DBG_TESTSOLARMUTEX() macro to assert that in dbgutil builds.

Event listeners are a special (but frequent) case of the "never call out with
a mutex (SolarMutex or other) locked" fundamental rule:

- UNO methods can be called from multiple threads, so most implementations
  take the solar mutex as their first action when necessary.

- This can be problematic if later calling out (an event handler is called),
  where the called function may be an UNO method implementation as well and
  may be invoked on a different thread.

- So we try to not own the solar mutex, whenever we call out (invoke event
  listeners).

In short, never hold any mutex unless necessary, especially not when calling
out.