Test repository to check push and ssh key
Find a file
Mike Kaganski 29f59dad0e Unlock the mutex to avoid deadlock
The request thread was calling OleComponent::CloseObject, which executed
on main thread; OleEmbeddedObject::m_aMutex as locked by request thread:

 emboleobj.dll!OleComponent::CloseObject() Line 1004
 emboleobj.dll!OleComponent::Dispose() Line 451
 emboleobj.dll!OleComponent::close(unsigned char bDeliverOwnership) Line 1513
 emboleobj.dll!OleEmbeddedObject::GetRidOfComponent() Line 235
 emboleobj.dll!OleEmbeddedObject::Dispose() Line 269
 emboleobj.dll!OleEmbeddedObject::close(unsigned char bDeliverOwnership) Line 498
 comphelper.dll!comphelper::EmbeddedObjectContainer::CloseEmbeddedObjects() Line 208
 sfxlo.dll!SfxObjectShell::~SfxObjectShell() Line 322
 swlo.dll!SwDocShell::~SwDocShell() Line 380
 swlo.dll!SwDocShell::`vector deleting destructor'(unsigned int)
 cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 229
 sfxlo.dll!rtl::Reference<SfxObjectShell>::~Reference<SfxObjectShell>() Line 126
 sfxlo.dll!IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() Line 265
 sfxlo.dll!IMPL_SfxBaseModel_DataContainer::`scalar deleting destructor'(unsigned int)
 sfxlo.dll!std::_Destroy_in_place<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer & _Obj) Line 293
 sfxlo.dll!std::_Ref_count_obj2<IMPL_SfxBaseModel_DataContainer>::_Destroy() Line 2113
 sfxlo.dll!std::_Ref_count_base::_Decref() Line 1164
 sfxlo.dll!std::_Ptr_base<IMPL_SfxBaseModel_DataContainer>::_Decref() Line 1380
 sfxlo.dll!std::shared_ptr<IMPL_SfxBaseModel_DataContainer>::~shared_ptr<IMPL_SfxBaseModel_DataContainer>() Line 1685
 sfxlo.dll!std::shared_ptr<IMPL_SfxBaseModel_DataContainer>::reset() Line 1732
 sfxlo.dll!SfxBaseModel::dispose() Line 794
 swlo.dll!SwXTextDocument::dispose() Line 561
 sfxlo.dll!SfxBaseModel::close(unsigned char bDeliverOwnership) Line 1523
 swlo.dll!SwXTextDocument::close(unsigned char bDeliverOwnership) Line 574
 sfxlo.dll!SfxBaseModel::dispose() Line 745
 swlo.dll!SwXTextDocument::dispose() Line 561
 mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
 mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
 binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239
 binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
 binaryurplo.dll!request(void * pThreadSpecificData) Line 84
 cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
 cppu3.dll!cppu_threadpool::ORequestThread::run() Line 165
 cppu3.dll!threadFunc(void * param) Line 190
 sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67

Main thread was acquiring OleEmbeddedObject::m_aMutex, which deadlocked:

 sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 65
 emboleobj.dll!osl::Mutex::acquire() Line 63
 emboleobj.dll!osl::ResettableGuard<osl::Mutex>::reset() Line 250
 emboleobj.dll!OleEmbeddedObject::setVisualAreaSize(__int64 nAspect, const com::sun::awt::Size & aSize) Line 148
 swlo.dll!SwWrtShell::CalcAndSetScale(svt::EmbeddedObjectRef & xObj, const SwRect * pFlyPrtRect, const SwRect * pFlyFrameRect, const bool bNoTextFramePrtAreaChanged) Line 777
 swlo.dll!SwContentNotify::ImplDestroy() Line 926
 swlo.dll!SwContentNotify::~SwContentNotify() Line 1037
 swlo.dll!SwNoTextFrame::MakeAll(OutputDevice * pRenderContext) Line 584
 swlo.dll!SwFrame::OptPrepareMake() Line 412
 swlo.dll!SwFrame::OptCalc() Line 1110
 swlo.dll!SwLayAction::FormatContent_(const SwContentFrame * pContent, const SwPageFrame * pPage) Line 1960
 swlo.dll!SwLayAction::FormatFlyContent(const SwFlyFrame * pFly) Line 1985
 swlo.dll!SwObjectFormatter::FormatObj_(SwAnchoredObject & _rAnchoredObj) Line 312
 swlo.dll!SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject & _rAnchoredObj, const bool _bCheckForMovedFwd) Line 133
 swlo.dll!SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame * _pMasterTextFrame) Line 414
 swlo.dll!SwObjectFormatterTextFrame::DoFormatObjs() Line 348
 swlo.dll!SwObjectFormatter::FormatObjsAtFrame(SwFrame & _rAnchorFrame, const SwPageFrame & _rPageFrame, SwLayAction * _pLayAction) Line 160
 swlo.dll!SwLayAction::FormatContent(SwPageFrame * pPage) Line 1793
 swlo.dll!SwLayAction::InternalAction(OutputDevice * pRenderContext) Line 605
 swlo.dll!SwLayAction::Action(OutputDevice * pRenderContext) Line 389
 swlo.dll!SwLayIdle::SwLayIdle(SwRootFrame * pRt, SwViewShellImp * pI) Line 2363
 swlo.dll!SwViewShell::LayoutIdle() Line 827
 swlo.dll!sw::DocumentTimerManager::DoIdleJobs(Timer * __formal) Line 176
 swlo.dll!sw::DocumentTimerManager::LinkStubDoIdleJobs(void * instance, Timer * data) Line 156
 vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111
 vcllo.dll!Timer::Invoke() Line 75
 vcllo.dll!Scheduler::CallbackTaskScheduling() Line 509
 vcllo.dll!SalTimer::CallCallback() Line 53
 vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 169
 vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525
 vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
 vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 385
 vcllo.dll!Application::Yield() Line 473
 vcllo.dll!Application::Execute() Line 361
 sofficeapp.dll!desktop::Desktop::Main() Line 1652
 vcllo.dll!ImplSVMain() Line 229
 vcllo.dll!SVMain() Line 262
 sofficeapp.dll!soffice_main() Line 110
 soffice.bin!sal_main() Line 51
 soffice.bin!main(int argc, char * * argv) Line 49
 soffice.bin!invoke_main() Line 79
 soffice.bin!__scrt_common_main_seh() Line 288
 soffice.bin!__scrt_common_main() Line 331
 soffice.bin!mainCRTStartup(void * __formal) Line 17

Change-Id: Iaf5133c488d4f26f43530ea19584e99cce12d81e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171855
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-14 14:44:14 +02:00
.git-hooks
.github
.vscode
accessibility
android
animations
apple_remote
avmedia tdf#158510 Added fallback for media files in MediaWindowImpl 2024-08-14 00:19:23 +02:00
basctl cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
basegfx cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
basic cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
bean
bin dubious to enable/disable help button based on IsContextHelpEnabled 2024-08-14 11:04:51 +02:00
binaryurp cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
bridges fix build on armhf with gcc 14 2024-08-08 20:35:30 +02:00
canvas cid#555593 COPY_INSTEAD_OF_MOVE 2024-08-06 22:31:35 +02:00
chart2 cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
cli_ure
codemaker .NET Bindings: Fix netmaker and net_basetypes 2024-08-14 13:14:01 +02:00
comphelper Related: cool#9735 vcl lok: add an AnyInput() callback 2024-08-14 11:17:33 +02:00
compilerplugins fix clang crash 2024-08-12 19:13:07 +02:00
config_host .NET Bindings: Move built .NET libraries into instdir 2024-08-03 11:28:46 +02:00
configmgr
connectivity cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
cppcanvas cid#1608541 bogus Overflowed constant 2024-08-11 18:20:20 +02:00
cppu
cppuhelper cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
cpputools
cui Resolves tdf#80054 - Customization for non-printable character color 2024-08-14 09:24:29 +02:00
dbaccess cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
desktop Related: cool#9735 vcl lok: add an AnyInput() callback 2024-08-14 11:17:33 +02:00
dictionaries@0fbb94c57e Update git submodules 2024-08-13 12:44:46 +02:00
distro-configs
docmodel
drawinglayer CairoSDPR: Handle EmphasisMarks 2024-08-14 10:48:51 +02:00
editeng cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
embeddedobj Unlock the mutex to avoid deadlock 2024-08-14 14:44:14 +02:00
embedserv
emfio
eventattacher
extensions tdf#153343 Show settings for the actual default font in control properties 2024-08-02 18:34:08 +02:00
external more_fonts: ship "hinted" instead of "full" for "Noto Sans Arabic" 2024-08-12 12:18:25 +02:00
extras
filter cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
forms
formula
fpicker cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
framework tdf#146769 menuBarManager: dispatch with KeyModifier Shift/Ctrl/Alt 2024-08-14 13:34:44 +02:00
helpcompiler cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
helpcontent2@44301eb01f Update git submodules 2024-08-13 23:15:30 +02:00
hwpfilter
i18nlangtag
i18npool
i18nutil
icon-themes
idl cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
idlc/test/parser
include Related: cool#9735 vcl lok: add an AnyInput() callback 2024-08-14 11:17:33 +02:00
instsetoo_native .NET Bindings: Move built .NET libraries into instdir 2024-08-03 11:28:46 +02:00
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
lingucomponent cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
linguistic
lotuswordpro
m4
msicreator
net_ure .NET Bindings: Fix netmaker and net_basetypes 2024-08-14 13:14:01 +02:00
nlpsolver
o3tl
odk No LibreOfficeKit headers and examples for macOS 2024-08-03 10:04:51 +02:00
offapi tdf#161909: make showing GPG keys only an explicit functionality 2024-08-13 01:09:01 +02:00
officecfg Resolves tdf#80054 - Customization for non-printable character color 2024-08-14 09:24:29 +02:00
oovbaapi
oox cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
opencl
osx
package package: clarify comment 2024-08-14 10:46:40 +02:00
pch
postprocess
pyuno
qadevOOo
readlicense_oo update credits 2024-08-08 22:54:24 +02:00
registry
remotebridges
reportbuilder cid#1608462 XML external entity processing enabled 2024-08-04 20:05:02 +02:00
reportdesign cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
ridljar
sal
salhelper
sax
sc tdf#162069 Initial focus is in the document when creating a new sheet 2024-08-14 11:20:27 +02:00
scaddins
sccomp
schema
scp2 .NET Bindings: Move built .NET libraries into instdir 2024-08-03 11:28:46 +02:00
scripting cid#1608302 XML external entity processing enabled 2024-08-11 18:20:27 +02:00
sd cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-13 21:53:15 +02:00
sdext cid#1556026 COPY_INSTEAD_OF_MOVE 2024-08-09 21:00:59 +02:00
setup_native
sfx2 dubious to enable/disable help button based on IsContextHelpEnabled 2024-08-14 11:04:51 +02:00
shell
slideshow cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
smoketest cid#1555415 COPY_INSTEAD_OF_MOVE 2024-08-06 09:13:52 +02:00
solenv solenv/bin/uiex: more helpful error message for context issues 2024-08-14 07:51:07 +02:00
soltools
sot
starmath cid#1555415 COPY_INSTEAD_OF_MOVE 2024-08-06 09:13:52 +02:00
static Emscripten: Move the Qt event loop off the JS main thread 2024-08-12 16:31:35 +02:00
stoc cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
store cid#1608100 silence Overflowed array index read 2024-08-12 20:52:11 +02:00
svgio Fix wrong / misleading uses of fTools::(more|less|equal) with literal 0 2024-08-02 11:31:00 +02:00
svl Simplify a bit 2024-08-12 17:50:05 +02:00
svtools Resolves tdf#80054 - Customization for non-printable character color 2024-08-14 09:24:29 +02:00
svx Related tdf#135561: read ase palette with Lab colormodel 2024-08-14 13:38:30 +02:00
sw tdf#162458 doc export: don't change "margin" to "page" 2024-08-14 13:33:44 +02:00
swext
sysui
test
testtools
toolkit use less exception throwing for flow control 2024-08-14 12:56:50 +02:00
tools cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
translations@45533a0038 Update git submodules 2024-08-08 22:36:38 +02:00
ucb use less exception throwing for flow control 2024-08-14 12:56:50 +02:00
ucbhelper
udkapi
uitest
UnoControls
unodevtools
unoidl
unoil
unotest
unotools use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
unoxml
ure
uui tdf#161909: Escape filepaths for password dialog. 2024-08-07 09:29:06 +02:00
vbahelper use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
vcl qt: Remove "5" from render backend name 2024-08-14 14:01:03 +02:00
winaccessibility wina11y: clang-format CAccHypertext 2024-08-13 07:18:27 +02:00
wizards ScriptForge (SFDialogs) Closure of non-modal dialogs 2024-08-10 11:18:07 +02:00
writerperfect use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
xmerge cid#1616070 XML external entity processing enabled 2024-08-09 10:52:57 +02:00
xmlhelp
xmloff use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
xmlreader
xmlscript
xmlsecurity tdf#161909: show where the certs in the CertificateChooser are from 2024-08-13 01:09:51 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in .NET Bindings: Move built .NET libraries into instdir 2024-08-03 11:28:46 +02:00
config_host_lang.mk.in
configure.ac .NET Bindings: Move built .NET libraries into instdir 2024-08-03 11:28:46 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst nss: upgrade to release 3.102.1 2024-08-02 17:01:11 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in .NET Bindings: Add DotnetTest class to gbuild 2024-08-03 12:07:11 +02:00
README.cross
README.help.md
README.md
README.Solaris
Repository.mk .NET Bindings: Move built .NET libraries into instdir 2024-08-03 11:28:46 +02:00
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.