75e152a7e8
Visible at e.g. in Calc: Format Cells/Borders/Line Styles. The problem was that first commit2e99e4e11d(opengl: use MVP matrix in vertex shaders, pixel offsets, 2015-07-08) introduced the concept of pixel offsets, setting the value (implicitly) to 0 in OpenGLSalGraphicsImpl::DrawTrapezoid(), but using 0.5 in OpenGLSalGraphicsImpl::FlushLinesOrTriangles(). This is fine, but then later commit2003076c43(opengl: batch draw polypolygons, 2016-05-29) changed OpenGLSalGraphicsImpl::drawPolyPolygon() to use deferred drawing instead of DrawTrapezoid(), without doing any translation of the input polypolygon. This resulted in loss of those polygons when used in the above mentioned dialog, which has a listbox of bitmaps, where each line style preview is drawn on a virtual device with a height of 1px. So at the end the 1px offset meant the previews were simply missing. ('make CppunitTest_vcl_gen SAL_USE_VCLPLUGIN=gen SAL_FORCEGL=1' is needed on Linux to see the test failing without the fix.) Change-Id: Ia9f3d6e7cb38a43fe2f8a41746b538af68add43c Reviewed-on: https://gerrit.libreoffice.org/69920 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
43 lines
1.1 KiB
Makefile
43 lines
1.1 KiB
Makefile
# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
|
|
#*************************************************************************
|
|
#
|
|
# This file is part of the LibreOffice project.
|
|
#
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
#
|
|
#*************************************************************************
|
|
|
|
$(eval $(call gb_CppunitTest_CppunitTest,vcl_gen))
|
|
|
|
$(eval $(call gb_CppunitTest_add_exception_objects,vcl_gen, \
|
|
vcl/qa/cppunit/gen/gen \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_use_libraries,vcl_gen, \
|
|
basegfx \
|
|
comphelper \
|
|
cppu \
|
|
cppuhelper \
|
|
sal \
|
|
sfx \
|
|
subsequenttest \
|
|
test \
|
|
tl \
|
|
unotest \
|
|
vcl \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_use_external,vcl_gen,boost_headers))
|
|
|
|
$(eval $(call gb_CppunitTest_use_sdk_api,vcl_gen))
|
|
|
|
$(eval $(call gb_CppunitTest_use_ure,vcl_gen))
|
|
$(eval $(call gb_CppunitTest_use_vcl_non_headless,vcl_gen))
|
|
|
|
$(eval $(call gb_CppunitTest_use_rdb,vcl_gen,services))
|
|
|
|
$(eval $(call gb_CppunitTest_use_configuration,vcl_gen))
|
|
|
|
# vim: set noet sw=4 ts=4:
|