Test repository to check push and ssh key
Find a file
Jan-Marek Glogowski 313081c070 tdf#131533 Qt5 defer dropping clipboard ownership
This is maybe a Qt bug. Calling QClipboard::setMimeData from
Qt5Clipboard::setContents after a previous call to
QClipboard::clear results in a clipboard ownership failure.
In a terminal you'll see: "QXcbClipboard::setMimeData: Cannot set
X11 selection owner".

Calling Application::Reschedule() after the clear() doesn't help.

The result is a de-sync between the LO's clipboard state and the
real clipboard state, which will lead to a crash on LO shutdown.

I'm not sure this fix is correct. Maybe this could also be handled
by some X11 flush operation. But it's the only working solution I
could find: don't clear, if LO re-claims the ownership later.

I tried to reproduce the ownership error by modifying the Qt
fridgemagnets example, adding some QClipboard::clear and
QClipboard::setMimeData calls to the drop handling, but couldn't
reproduce. Maybe the dynamic Qt5MimeData object is also involved.

Change-Id: I32b6575a78a4b10a2e2b7b189303ab3a40dc69ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90990
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-25 22:15:50 +01:00
.git-hooks
.github
accessibility Revert "loplugin:constfields in svtools" 2020-03-13 19:20:38 +01:00
android android: Pass Intent's action in ctor already 2020-03-13 22:01:25 +01:00
animations
apple_remote
avmedia tdf#124176: Use pragma once instead of include guards 2020-03-23 12:35:57 +01:00
basctl tdf#124176: Use pragma once instead of include guards 2020-03-23 12:35:57 +01:00
basegfx make more classes private in mergedlibs mode 2020-03-23 12:05:36 +01:00
basic Initialize buffer 2020-03-24 18:06:23 +01:00
bean
bin make SpinField DLLPUBLIC again 2020-03-09 15:26:54 +01:00
binaryurp
bridges
canvas tdf#124176 Use pragma once instead of include guards 2020-03-23 21:28:29 +01:00
chart2 lokit: Mark document as modified on chart insert/edit... 2020-03-25 14:17:17 +01:00
cli_ure
codemaker
comphelper Simplify the LibreOfficeKit mobile phone and tablet API 2020-03-24 10:10:04 +01:00
compilerplugins Fix typos 2020-03-23 21:52:24 +01:00
config_host The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
configmgr
connectivity MSVC hack to avoid multiply defined symbols 2020-03-20 19:16:26 +01:00
cppcanvas
cppu
cppuhelper Fix typo 2020-03-10 20:43:41 +01:00
cpputools
cui tdf#114441: Convert use of sal_uLong to better integer types 2020-03-25 20:20:22 +01:00
dbaccess Fix typos 2020-03-23 21:52:24 +01:00
desktop nss: fix this up to work with Online again 2020-03-25 20:32:15 +01:00
dictionaries@74d8e82635 Update git submodules 2020-03-17 12:21:16 +01:00
distro-configs Add --disable-compiler-plugins-analyzer-pch for Jenkins/linux_clang_dbgutil_64 2020-03-09 13:48:35 +01:00
drawinglayer Fix typo 2020-03-25 22:14:12 +01:00
dtrans
editeng tdf#114441: Convert use of sal_uLong to better integer types 2020-03-20 17:57:09 +01:00
embeddedobj
embedserv -Werror,-Wpointer-to-int-cast (LLVM 10 trunk clang-cl) 2020-03-20 20:48:03 +01:00
emfio make more classes private in mergedlibs mode 2020-03-23 12:05:36 +01:00
eventattacher
extensions Resolves: tdf#131522 sync textview from edit when edit changes 2020-03-25 15:23:18 +01:00
external nss: fix this up to work with Online again 2020-03-25 20:32:15 +01:00
extras sduilo-SdPageListControl doesn't exist anymore 2020-03-24 18:23:05 +01:00
filter Remove some unused includes 2020-03-25 09:12:23 +01:00
forms Fix typo 2020-03-21 09:36:13 +01:00
formula Resolves: tdf#131423 Handle Function Wizard max argument count correctly 2020-03-21 00:10:01 +01:00
fpicker Revert "loplugin:constfields in svtools" 2020-03-13 19:20:38 +01:00
framework make more classes private in mergedlibs mode 2020-03-23 12:05:36 +01:00
helpcompiler
helpcontent2@68dc0e7b37 Update git submodules 2020-03-25 21:34:13 +01:00
hwpfilter
i18nlangtag tdf#131297 Add Sundanese [sun-ID] to language list 2020-03-12 15:08:03 +01:00
i18npool sw: add pad-to-5 numbering 2020-03-23 14:32:37 +01:00
i18nutil
icon-themes Sifr: Fix for tdf#130864: Enlarge the border 2020-03-25 17:47:01 +01:00
idl The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
idlc
include tdf#101181: add sidebar panel for Glow effect 2020-03-25 21:42:54 +01:00
instsetoo_native tdf#128281 Increase a checkbox height in Windows installer 2020-03-16 15:36:13 +01:00
io
ios
javaunohelper Fix typo 2020-03-10 20:43:18 +01:00
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit libreofficekit: Use 'gb_Library_set_include' for GTK3_CFLAGS 2020-03-17 15:53:05 +01:00
lingucomponent
linguistic
lotuswordpro fix assert when loading id:000059,sig:11,src:000008,op:havoc,rep:2.lwp 2020-03-25 14:36:42 +01:00
m4
nlpsolver
o3tl
odk
offapi sw: add pad-to-5 numbering 2020-03-23 14:32:37 +01:00
officecfg tdf#101181: add sidebar panel for Glow effect 2020-03-25 21:42:54 +01:00
onlineupdate comparison operators should be const 2020-03-12 11:05:36 +01:00
oovbaapi
oox tdf#131553 a null pointer crashes Impress 2020-03-25 17:44:22 +01:00
opencl Revert "loplugin:constfields in oox" 2020-03-12 07:31:08 +01:00
osx
package Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
pch
postprocess tdf#130911: convert image-sort from Perl to Python 2020-03-20 09:52:15 +01:00
pyuno Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
qadevOOo Fix typo 2020-03-10 20:42:53 +01:00
readlicense_oo update credits 2020-03-11 17:07:33 +01:00
registry Revert "loplugin:constfields in package..registry" 2020-03-12 08:17:11 +01:00
remotebridges
reportbuilder
reportdesign Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
ridljar
sal Avoid stack overflow in testTdf124815 on Windows 2020-03-16 14:02:00 +01:00
salhelper
sax Revert "loplugin:constfields in reportdesign,sal,sax" 2020-03-12 09:22:20 +01:00
sc tdf#101181: add sidebar panel for Glow effect 2020-03-25 21:42:54 +01:00
scaddins tdf#130975 replace rtl::math::isNan with std::isnan. 2020-03-14 09:19:00 +01:00
sccomp Revert "loplugin:constfields in scaddins,sccomp" 2020-03-12 17:44:30 +01:00
schema
scp2 Revert "Resolves tdf#99675: Add BPMN images to the gallery" 2020-03-14 10:22:02 +01:00
scripting Revert "loplugin:constfields in scripting" 2020-03-12 09:22:31 +01:00
sd tdf#101181: add sidebar panel for Glow effect 2020-03-25 21:42:54 +01:00
sdext Revert "loplugin:constfields in sdext" 2020-03-12 09:34:21 +01:00
setup_native
sfx2 Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
shell Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
slideshow Revert "loplugin:constfields in slideshow" 2020-03-12 19:44:42 +01:00
smoketest Revert "loplugin:constfields in smoketest..sot" 2020-03-12 19:43:04 +01:00
solenv weld writer navigator 2020-03-24 11:00:50 +01:00
soltools Revert "loplugin:constfields in smoketest..sot" 2020-03-12 19:43:04 +01:00
sot Revert "loplugin:constfields in smoketest..sot" 2020-03-12 19:43:04 +01:00
starmath loplugin:redundantpointerops add some more smart pointer types 2020-03-19 09:04:21 +01:00
stoc Revert "loplugin:constfields in stoc..svgio" 2020-03-14 07:54:02 +01:00
store Revert "loplugin:constfields in stoc..svgio" 2020-03-14 07:54:02 +01:00
svgio Revert "loplugin:constfields in stoc..svgio" 2020-03-14 07:54:02 +01:00
svl Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
svtools no reason for the FontAntiAliasing setting being UNX-only (tdf#107744) 2020-03-25 14:32:17 +01:00
svx tdf#101181: add sidebar panel for Glow effect 2020-03-25 21:42:54 +01:00
sw tdf#101181: add sidebar panel for Glow effect 2020-03-25 21:42:54 +01:00
swext
sysui
test tdf#130975 replace rtl::math::isNan with std::isnan. 2020-03-14 09:19:00 +01:00
testtools Revert "loplugin:constfields in sw" 2020-03-13 15:41:42 +01:00
toolkit Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
tools Revert "loplugin:constfields in tools" 2020-03-15 16:28:03 +01:00
translations@7b4a46ae14 Update git submodules 2020-03-16 13:16:32 +01:00
ucb ucb-webdav-neon: drop large commented code blocks 2020-03-25 19:36:10 +01:00
ucbhelper Revert "loplugin:constfields in ucbhelper" 2020-03-15 16:28:14 +01:00
udkapi
uitest Defect type: IDENTIFIER_TYPO 2020-03-25 14:34:07 +01:00
UnoControls Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
unodevtools
unoidl Revert "loplugin:constfields in unoidl" 2020-03-15 16:28:50 +01:00
unoil
unotest
unotools Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
unoxml Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
ure
uui use SolarMutexReleaser in UUIInteractionHelper 2020-03-19 13:46:30 +01:00
vbahelper Revert "loplugin:constfields in vbahelper" 2020-03-16 08:17:02 +01:00
vcl tdf#131533 Qt5 defer dropping clipboard ownership 2020-03-25 22:15:50 +01:00
winaccessibility
wizards
writerfilter tdf#106843 docxexport: don't write double docProtect 2020-03-25 09:17:34 +01:00
writerperfect Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
xmerge
xmlhelp Revert "loplugin:constfields in xmlhelp" 2020-03-16 10:29:56 +01:00
xmloff Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
xmlreader
xmlscript
xmlsecurity Remove unused using declarations in oox...xmlsecurity 2020-03-25 09:13:27 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile Initial commit for Gitpodifying LibreOffice core 2020-03-09 13:00:32 +01:00
.gitpod.yml Install C++ VSCode extension for Gitpod 2020-03-09 15:54:14 +01:00
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in actually export $NINJA from configure 2020-03-23 18:46:43 +01:00
config_host_lang.mk.in
configure.ac Fix test for /usr/share/java/flute-1.3.0.jar 2020-03-25 14:09:37 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst python3: upgrade to release 3.7.7 2020-03-23 16:09:52 +01:00
g
hardened_runtime.xcent
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch build nss using their new build system (gyp/ninja-based) 2020-03-23 14:31:04 +01:00
Makefile.gbuild
Makefile.in rework the default make target 2020-03-23 14:30:37 +01:00
README.cross Add missing autogen.input entries to README.cross 2020-03-25 16:25:14 +01:00
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk implement text rendering using directly Skia (X11) 2020-03-18 10:47:49 +01:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-blacklist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.4
  • macOS:
    • Runtime: 10.10
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.