strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/solenv
History
Regina Henschel 9ad7df4157 tdf#83671 make SmartArt visible in import of xlsx 
Problem is, that Excel writes a zero size in xdr:xfrm for the SmartArt.
With that the import generates a background size with zero width and
height and no shapes at all in the SmartArt group. The diagram DOM is
imported correctly. The actual size is not known until the row and column
values of the anchor are evaluated.
The idea of this patch is to correct the background size directly and to
repeat the import of drawing.xml when the actual size is known.

I noticed that in import of SmartArt in docx there is a similar problem
that the SmartArt shapes are missing at some point, as can be seen in
ShapeContextHandler::getShape(), about line 428. It uses
ShapeDrawingFragmentHandler to import the shapes. To be able to use that
handler too, I have moved its header file to include.
The solution for docx uses a loop over the vector getExtDrawings(). But I
have not seen a SmartArt case, where more then one element exists in it.

Whether the shape is a diagram, is indirectly tested currently. The
shape has yet no direct method for it.

Change-Id: I9d705ed5bfb2894e9ce740ebf8589e06b4870bed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141571
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-24 15:09:37 +02:00
..
bin macOS sandbox: only use com.apple.application-identifier for main package 2022-10-23 12:11:38 +02:00
buck
clang-cl
clang-format tdf#83671 make SmartArt visible in import of xlsx 2022-10-24 15:09:37 +02:00
doc/gbuild
gbuild Make MSVC -showIncludes processing more reliable 2022-10-19 13:07:38 +02:00
gbuildtojson
gcc-wrappers
gdb
inc
lldb/libreoffice
lockfile
maven
qa/python
sanitizers
vs
wsl
CompilerTest_compilerplugins_clang-c++03.mk
CompilerTest_compilerplugins_clang.mk
CustomTarget_gbuildtesttools.mk
Executable_concat-deps.mk
Executable_g++-wrapper.mk
Executable_gbuildtojson.mk
Executable_gcc-wrapper.mk
Executable_lockfile.mk
flatpak-manifest.in
Makefile
Module_solenv.mk
PythonTest_solenv_python.mk
README.md
StaticLibrary_wrapper.mk

README.md

Tools and Makefile Fragments Necessary for Compilation

This module contains many tools and makefile configuration pieces, critical for building LibreOffice:

  • bin/

    • contains lots of tools used during the build:

      • concat-deps* these aggregate, and remove duplicates from module dependencies, to accelerate build times.

      • make_installer.pl this script executes the compiled instructions from the scp2/ module to create an installer, and/or to do a local install for the smoketest.

  • gbuild/

    implementation of the LibreOffice build system See gbuild/README for more info.

  • gdb/

    lots of nice python helpers to make debugging -much- easier that (eg.) print UCS2 strings as UTF-8 on the console to help with debugging.

  • inc/

    old / increasingly obsolete dmake setup and includes, we are trying to entirely rid ourselves of this

  • src/

    useful standard / re-usable component map files for components which shouldn't export anything more than a few registration symbols.

  • flatpak-manifest.in

    This file is copied manually to https://github.com/flathub/org.libreoffice.LibreOffice/blob/master/org.libreoffice.LibreOffice.json The flatpak/build.sh in the LO dev-tools repository is obsolete.