strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/svl/Library_svl.mk
Mike Kaganski f3e7004794 tdf#130725: use strtod by David M. Gay to make sure we get the nearest 
... representation of given decimal.
Use dtoa.c from https://www.netlib.org/fp/dtoa.c to build a custom
static library that doesn't use current locale (unlike strtod from
stdlib.h).  This is the implementation used by e.g. python and nss
(search for "dtoa.c" under UnpackedTarball).

To avoid name clash with the standard strtod, rename the function
to strtod_nolocale.

Size of buffer on stack in ImpSvNumberInputScan::StringToDouble is
256 characters. Logging function usage in make check, of ~124 600
invocations, the longest string was 14 characters, average being
2.1 characters. So heap allocation is unlikely in scenarios with
intensive function usage.

After std::from_chars is available in baseline compilers, external
library can be dropped, and call to strtod_nolocale replaced with
the standard function.

The artifact at https://dev-www.libreoffice.org/src/dtoa-20180411.tgz
is created with

  mkdir dtoa && mkdir dtoa/src && wget https://www.netlib.org/fp/dtoa.c -O dtoa/src/dtoa.c && \
   printf 'd8bab255476f39ea495c8c8ed164f9077da926e6ca7afb9ad3c56d337c4484fe dtoa/src/dtoa.c' | sha256sum -c && \
   tar -c --owner=0 --group=0 --mode=go=r,u=rw --mtime='Wed, 11 Apr 2018 15:59:39 GMT' dtoa/src/dtoa.c | gzip -n > dtoa-20180411.tgz && \
   printf '0082d0684f7db6f62361b76c4b7faba19e0c7ce5cb8e36c4b65fea8281e711b4 dtoa-20180411.tgz' | sha256sum -c

(where the date "Wed, 11 Apr 2018 15:59:39 GMT" is from
`wget -S https://www.netlib.org/fp/dtoa.c`
"Last-Modified: Wed, 11 Apr 2018 15:59:39 GMT" header).

Change-Id: Ia61b7678e257c4bc1ff193f3f856d611aa5c1a21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88854
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-27 11:02:03 +01:00

211 lines
5.5 KiB
Makefile
Raw Blame History

# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This file incorporates work covered by the following license notice:
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed
# with this work for additional information regarding copyright
# ownership. The ASF licenses this file to you under the Apache
# License, Version 2.0 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.apache.org/licenses/LICENSE-2.0 .
#
$(eval $(call gb_Library_Library,svl))
$(eval $(call gb_Library_use_externals,svl,\
boost_headers \
$(if $(filter LINUX MACOSX ANDROID %BSD SOLARIS HAIKU,$(OS)), \
curl) \
dtoa \
icu_headers \
icuuc \
mdds_headers \
libxml2 \
))
$(eval $(call gb_Library_set_componentfile,svl,svl/util/svl))
$(eval $(call gb_Library_set_include,svl,\
-I$(SRCDIR)/svl/source/inc \
$$(INCLUDE) \
))
$(eval $(call gb_Library_use_custom_headers,svl,\
officecfg/registry \
))
$(eval $(call gb_Library_set_precompiled_header,svl,svl/inc/pch/precompiled_svl))
$(eval $(call gb_Library_use_sdk_api,svl))
$(eval $(call gb_Library_add_defs,svl,\
-DSVL_DLLIMPLEMENTATION \
))
ifeq ($(TLS),NSS)
$(eval $(call gb_Library_use_externals,svl,\
plc4 \
nss3 \
))
else
ifeq ($(TLS),OPENSSL)
$(eval $(call gb_Library_use_externals,svl,\
openssl \
openssl_headers \
))
endif
endif
$(eval $(call gb_Library_use_libraries,svl,\
basegfx \
comphelper \
cppu \
cppuhelper \
i18nlangtag \
i18nutil \
$(if $(ENABLE_JAVA), \
jvmfwk) \
sal \
sot \
tl \
ucbhelper \
utl \
))
$(eval $(call gb_Library_use_system_win32_libs,svl,\
advapi32 \
crypt32 \
gdi32 \
gdiplus \
imm32 \
mpr \
ole32 \
shell32 \
usp10 \
uuid \
version \
winspool \
setupapi \
shlwapi \
))
ifeq ($(OS),WNT)
$(eval $(call gb_Library_add_defs,svl,\
-DSVL_CRYPTO_MSCRYPTO \
))
$(eval $(call gb_Library_use_system_win32_libs,svl,\
crypt32 \
))
else
ifneq (,$(filter DESKTOP,$(BUILD_TYPE))$(filter ANDROID,$(OS)))
$(eval $(call gb_Library_add_defs,svl,\
-DSVL_CRYPTO_NSS \
))
$(eval $(call gb_Library_use_externals,svl,\
nss3 \
plc4 \
))
endif # BUILD_TYPE=DESKTOP
endif
$(eval $(call gb_Library_add_exception_objects,svl,\
svl/source/config/asiancfg \
svl/source/config/cjkoptions \
svl/source/config/ctloptions \
svl/source/config/itemholder2 \
svl/source/config/languageoptions \
svl/source/crypto/cryptosign \
svl/source/filepicker/pickerhistory \
svl/source/items/aeitem \
svl/source/items/cenumitm \
svl/source/items/cintitem \
svl/source/items/custritm \
svl/source/items/flagitem \
svl/source/items/globalnameitem \
svl/source/items/grabbagitem \
svl/source/items/ilstitem \
svl/source/items/imageitm \
svl/source/items/intitem \
svl/source/items/int64item \
svl/source/items/itemiter \
svl/source/items/itempool \
svl/source/items/itemprop \
svl/source/items/IndexedStyleSheets \
svl/source/items/itemset \
svl/source/items/lckbitem \
svl/source/items/legacyitem \
svl/source/items/macitem \
svl/source/items/poolcach \
svl/source/items/poolio \
svl/source/items/poolitem \
svl/source/items/ptitem \
svl/source/items/rectitem \
svl/source/items/rngitem \
svl/source/items/sitem \
svl/source/items/slstitm \
svl/source/items/srchitem \
svl/source/items/stringio \
svl/source/items/stritem \
svl/source/items/style \
svl/source/items/stylepool \
svl/source/items/visitem \
svl/source/items/whiter \
svl/source/misc/PasswordHelper \
svl/source/misc/adrparse \
$(if $(filter DESKTOP,$(BUILD_TYPE)),\
svl/source/misc/documentlockfile \
svl/source/misc/msodocumentlockfile) \
svl/source/misc/filenotation \
svl/source/misc/fstathelper \
svl/source/misc/getstringresource \
svl/source/misc/gridprinter \
svl/source/misc/inethist \
svl/source/misc/inettype \
svl/source/misc/lngmisc \
svl/source/misc/lockfilecommon \
svl/source/misc/ownlist \
svl/source/misc/sharecontrolfile \
svl/source/misc/sharedstring \
svl/source/misc/sharedstringpool \
svl/source/misc/strmadpt \
svl/source/misc/urihelper \
svl/source/notify/SfxBroadcaster \
svl/source/notify/broadcast \
svl/source/notify/hint \
svl/source/notify/isethint \
svl/source/notify/listener \
svl/source/notify/lstner \
svl/source/numbers/currencytable \
svl/source/numbers/numfmuno \
svl/source/numbers/numuno \
svl/source/numbers/supservs \
svl/source/numbers/zforfind \
svl/source/numbers/zforlist \
svl/source/numbers/zformat \
svl/source/numbers/zforscan \
svl/source/svsql/converter \
svl/source/undo/undo \
svl/source/uno/pathservice \
))
ifeq ($(OS),WNT)
$(eval $(call gb_Library_add_exception_objects,svl,\
svl/source/svdde/ddecli \
svl/source/svdde/ddedata \
svl/source/svdde/ddestrg \
svl/source/svdde/ddesvr \
))
else
$(eval $(call gb_Library_add_exception_objects,svl,\
svl/unx/source/svdde/ddedummy \
))
endif
# vim: set noet sw=4 ts=4:
Reference in a new issue View git blame Copy permalink