22cbdc7b11
rely on the -DNDEBUG we pass in on non-debug builds to to disable assert Change-Id: I089be56aa6fcddb78507bb0f0457c67c226437a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
51 lines
1.1 KiB
Diff
51 lines
1.1 KiB
Diff
--- dtor/src/dtoa.c.coverity
|
|
+++ dtor/src/dtoa.c
|
|
@@ -216,14 +216,14 @@
|
|
typedef unsigned Long ULong;
|
|
#endif
|
|
|
|
-#ifdef DEBUG
|
|
#include <assert.h>
|
|
+
|
|
+#ifdef DEBUG
|
|
#include "stdio.h"
|
|
#define Bug(x) {fprintf(stderr, "%s\n", x); exit(1);}
|
|
#define Debug(x) x
|
|
int dtoa_stats[7]; /* strtod_{64,96,bigcomp},dtoa_{exact,64,96,bigcomp} */
|
|
#else
|
|
-#define assert(x) /*nothing*/
|
|
#define Debug(x) /*nothing*/
|
|
#endif
|
|
|
|
@@ -2301,6 +2301,7 @@
|
|
if ((y = d1)) {
|
|
if ((k = lo0bits(&y))) {
|
|
x[0] = y | z << (32 - k);
|
|
+ assert(k < 32); /* https://bugs.python.org/issue23999 */
|
|
z >>= k;
|
|
}
|
|
else
|
|
@@ -3029,6 +3030,7 @@
|
|
|| ((n = nbits & kmask) !=0
|
|
&& hi0bits(x[k-1]) < 32-n)) {
|
|
rshift(b,1);
|
|
+ /* coverity[dead_error_line] - not worth investigating */
|
|
if (++e > Emax)
|
|
goto ovfl;
|
|
}
|
|
@@ -3345,6 +3347,7 @@
|
|
if ((dd = s0[j++] - '0' - dig))
|
|
goto ret;
|
|
if (!b->x[0] && b->wds == 1) {
|
|
+ /* coverity[copy_paste_error : FALSE] */
|
|
if (i < nd)
|
|
dd = 1;
|
|
goto ret;
|
|
@@ -3607,6 +3610,7 @@
|
|
switch(c = *++s) {
|
|
case '-':
|
|
esign = 1;
|
|
+ /* fall through */
|
|
case '+':
|
|
c = *++s;
|
|
}
|