office-gobmx/shell
Stephan Bergmann 0bbbde84b0 tdf#140886: Make "Do you really want to open it?" more reliable
70009098fd "tdf#128969: Let the user explicitly
decide to execute an external program" had shoehorned that new warning dialog
into the existing XSystemShellExecute::execute IllegalArgumentException return
path, which caused some issues:  For example, it caused the warning dialog to
reappear after you acknowledged it on macOS (see comment at
<https://bugs.documentfoundation.org/show_bug.cgi?id=140886#c10> "Allow
hyperlink opening on file with execute bit set ref. CVE-2019-9847"), and it
caused the warning dialog to erroneously appear for a non-existing file on
Windows (see comment at
<https://gerrit.libreoffice.org/c/core/+/124422/2#message-ac76b728fedc53e7d0a04c99f00364068b51a8ea>
"tdf#128969: Let the user explicitly decide to execute an external program").

So rather than reusing IllegalArgumentException for this case, use a different
kind of exception to trigger that warning dialog.  The existing
AccessControlException (which is also a RuntimeException) happened to fit more
or less well.

Change-Id: I3f743c21be48d54f10951006ef3d7172e23e9076
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135524
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-09 11:17:14 +02:00
..
inc loplugin:trivialconstructor 2022-03-24 09:27:56 +01:00
qa/zip drop 'using namespace std' in sax/sc/scaddins/sfx2/shell 2021-10-04 22:25:07 +02:00
source tdf#140886: Make "Do you really want to open it?" more reliable 2022-06-09 11:17:14 +02:00
AllLangMoTarget_shell.mk
CppunitTest_shell_zip.mk
CustomTarget_shlxthdl_res.mk
CustomTarget_spsupp_idl.mk
CustomTarget_x64.mk
Executable_lngconvex.mk
Executable_regsvrex.mk
Executable_senddoc.mk
Executable_spsupp_helper.mk
Executable_uri_encode.mk
IwyuFilter_shell.yaml
Library_cmdmail.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Library_desktopbe.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Library_jumplist.mk Remove execution bits from data files 2022-03-31 14:51:18 +02:00
Library_kf5be.mk rhbz#2047319 drop the SolarMutex before QApplication::init() 2022-02-03 17:16:12 +01:00
Library_localebe.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Library_losessioninstall.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Library_macbe.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Library_ooofilt.mk
Library_ooofilt_x64.mk
Library_propertyhdl.mk
Library_propertyhdl_x64.mk
Library_shlxthdl.mk
Library_shlxthdl_x64.mk
Library_smplmail.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Library_spsupp_x64.mk
Library_spsupp_x86.mk
Library_syssh.mk Library_syssh must link against expat when using StaticLibrary_shell_xmlparser 2022-05-11 16:16:35 +02:00
Library_wininetbe.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Makefile
Module_shell.mk Add UNO API for custom Jump Lists 2022-03-30 12:14:28 +02:00
Package_senddoc.mk
README.md
StaticLibrary_shlxthandler_common.mk
StaticLibrary_shlxthandler_common_x64.mk
StaticLibrary_xmlparser.mk
StaticLibrary_xmlparser_x64.mk
WinResTarget_shlxthdl.mk
WinResTarget_spsupp.mk
WinResTarget_spsupp_dlg.mk

System Helpers

Launching URI, system integration, external mailer support etc.