3d9f5c856a
Since OString already has a ctor accepting const char*, I cannot find out a way to distinguish string literals other than using a template, otherwise const char* somehow takes precedence (all of gcc, clang, msvc). But the template requires the Substitution Is Not A Failure Idiom to actually create only wanted instances. And the compiler can try evaluate the OString ctor as a possibility when comparing an int to an anonymous enum, and anonymous enum as a type without linkage cannot be a template argument before C++11. SFINAE should still work, but not with gcc older than 4.0.2 (which we right now use only on macs). So for that case disable the string literal ctors, which means macs will have one extra strlen call, and also that embedded \0's in string literals will be inconsistent. The tiny performance problem shouldn't matter that much and will eventually go away, the \0 problem should not matter, since before string literal ctors were introduced \0's had not been included anyway unless RTL_CONSTASCII_STRINGPARAM was used. So we should be safe and when removing the CONSTASCII macros \0 cases should be handled by explicitly mentioning the length. |
||
|---|---|---|
| .. | ||
| android | ||
| cpprt | ||
| cppunittester | ||
| inc | ||
| osl | ||
| prj | ||
| qa | ||
| rtl/source | ||
| systools/win32/uwinapi | ||
| test | ||
| textenc | ||
| typesconfig | ||
| util | ||
| workben | ||
| CppunitTest_Module_DLL.mk | ||
| CppunitTest_sal_bytesequence.mk | ||
| CppunitTest_sal_osl_condition.mk | ||
| CppunitTest_sal_osl_file.mk | ||
| CppunitTest_sal_osl_getsystempathfromfileurl.mk | ||
| CppunitTest_sal_osl_module.mk | ||
| CppunitTest_sal_osl_mutex.mk | ||
| CppunitTest_sal_osl_old_test_file.mk | ||
| CppunitTest_sal_osl_pipe.mk | ||
| CppunitTest_sal_osl_process.mk | ||
| CppunitTest_sal_osl_profile.mk | ||
| CppunitTest_sal_osl_security.mk | ||
| CppunitTest_sal_osl_setthreadname.mk | ||
| CppunitTest_sal_osl_thread.mk | ||
| CppunitTest_sal_rtl_alloc.mk | ||
| CppunitTest_sal_rtl_cipher.mk | ||
| CppunitTest_sal_rtl_crc32.mk | ||
| CppunitTest_sal_rtl_doublelock.mk | ||
| CppunitTest_sal_rtl_locale.mk | ||
| CppunitTest_sal_rtl_math.mk | ||
| CppunitTest_sal_rtl_ostringbuffer.mk | ||
| CppunitTest_sal_rtl_oustringbuffer.mk | ||
| CppunitTest_sal_rtl_strings.mk | ||
| CppunitTest_sal_tcwf.mk | ||
| CppunitTest_sal_types.mk | ||
| Executable_cppunittester.mk | ||
| Executable_osl_process_child.mk | ||
| Library_lo-bootstrap.mk | ||
| Library_sal.mk | ||
| Library_sal_textenc.mk | ||
| Library_uwinapi.mk | ||
| Makefile | ||
| Module_sal.mk | ||
| Package_generated.mk | ||
| Package_inc.mk | ||
| README | ||
| StaticLibrary_salcpprt.mk | ||
System abstraction layer; rtl, osl and sal rtl: Platform independent strings osl: platform specific stuff, threads, dynamic loading, process, ipc, etc Exports only C API and some inline-methods (only C++ API).