office-gobmx/svx
Stephan Bergmann 941ab8acf0 comphelper::OCommonAccessibleComponent's XAggregation is apparently unused
It had been using WeakAggComponentImplHelper2 ever since
2f79d5f479 "initial checkin - helper for
implementing an XAccessibleContext", but all the classes that derive from it
(comphelper::OAccessibleComponentHelper,
comphelper::OAccessibleExtendedComponentHelper, and classes that in turn derive
from those) implement queryInterface (in a way not just forwarding to the base
class queryInterface, as would be required for classes implementing
XAggregation) rather than queryAggregation, so aggregation was broken and any
delegator would be ignored when calling queryInterface on one of the derived
classes.

Also, without this commit but instead with a local

> --- a/include/comphelper/accessiblecomponenthelper.hxx
> +++ b/include/comphelper/accessiblecomponenthelper.hxx
> @@ -49,6 +49,7 @@ namespace comphelper
>                  :public ::cppu::BaseMutex
>                  ,public OCommonAccessibleComponent_Base
>      {
> +        void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
>          friend class OContextEntryGuard;
>      private:
>          css::uno::WeakReference< css::accessibility::XAccessible > m_aCreator;         // the XAccessible which created our XAccessibleContext

on all of Linux, macOS, and Windows: `make check` still succeeded, and running
the resulting LibreOffice with the system in some assistive technology narration
mode produced audio, all without hitting that injected assert that should have
fired if the XAggregation mechanism had been used after all.

Change-Id: I47045824d0762a5f3de150a11576694621b163b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145330
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-12 08:12:44 +00:00
..
doc
inc Resolves: tdf#152593 reuse Line Style preview code for Line Width preview 2022-12-21 13:56:44 +00:00
qa oox: add support for importing font scheme into a svx::Theme 2023-01-01 23:34:32 +00:00
sdi Related: tdf#150339 remove SID_ATTR_COLOR_STR 2023-01-04 14:05:46 +00:00
source comphelper::OCommonAccessibleComponent's XAggregation is apparently unused 2023-01-12 08:12:44 +00:00
uiconfig/ui tdf#56258 sw toolbar: show SetOutline by default 2023-01-06 00:35:13 +00:00
util WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
AllLangMoTarget_svx.mk migrate to boost::gettext 2017-07-21 08:20:50 +01:00
CppunitTest_svx_core.mk CppunitTest_svx_core: inherit from UnoApiTest 2022-11-01 11:09:55 +01:00
CppunitTest_svx_dialogs_test.mk gbuild: Remove MSVC 2013 legacy code 2017-04-21 18:18:44 +02:00
CppunitTest_svx_gallery_test.mk svx:unit tests for adding, acquiring, counting objects into gallery theme 2020-06-01 22:30:47 +02:00
CppunitTest_svx_removewhichrange.mk Separate core drawinglayer func. into drawinglayercore library 2021-12-22 12:10:10 +01:00
CppunitTest_svx_styles.mk move password handling from SwModelTestBase to UnoApiTest 2022-11-11 20:09:41 +01:00
CppunitTest_svx_unit.mk oox: add support for importing font scheme into a svx::Theme 2023-01-01 23:34:32 +00:00
Executable_gengal.mk Drop support for OpenGL denylist on X11 2022-03-28 14:31:07 +02:00
IwyuFilter_svx.yaml Recheck modules sv* with IWYU 2022-03-03 09:50:43 +01:00
JunitTest_svx_unoapi.mk Simplify and fix Java UNO API test makefiles 2018-11-09 07:37:00 +01:00
Library_svx.mk Resolves: tdf#92051 add tooltips to section/table statusbar 2022-12-15 10:36:49 +00:00
Library_svxcore.mk svx: fix unmaintainable TypeConstant definition 2022-12-09 12:08:47 +00:00
Library_textconversiondlgs.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Makefile switch to include-based build rather than sourced-based build 2012-02-05 19:34:05 -06:00
Module_svx.mk gbuild: implement static partial build 2022-01-13 12:13:06 +01:00
Package_gengal.mk gbuild: set Package default target to INSTDIR 2013-10-28 20:17:26 +01:00
README.md svx: fix URL and class name in README 2022-03-01 08:19:01 +01:00
UIConfig_svx.mk Add graphic size checker for the preferred document DPI 2021-12-20 06:21:34 +01:00
UITest_svx_table.mk tdf#129961 svx: finish UI for table shadow as direct format 2020-12-15 22:41:14 +01:00

Graphics Related Helper Code

Contains graphics related helper code. Lots of the draw and impress code is in this shared library.

  • xoutdev

    this is where a lot of wht work would happen to move to the canvas. (what does that mean?)

  • svdraw

    transparent gradient stuff. [seriously? surely much more, too]

SdrObject

The shapes you can see in LibreOffice (like rectangle, etc.) are SdrObjects. They are declared as a hierarchy:

SdrObject <- SdrAttrObj <- E3dObject <- E3dCompoundObject <- E3dCubeObj
    ^ ^ ^             ^            ^              | | ^ ^
    | | |             |            |              | | | +--- E3dExtrudeObj
    | | |             |            |              | | +----- E3dLatheObj
    | | |             |            |              | +------- E3dPolygonObj
    | | |             |            |              +--------- E3dSphereObj
    | | |             |            +--- E3dScene...
    | | |             |
    | | |             +--- SdrTextObj <- SdrObjCustomShape...
    | | |                   ^ ^ ^ ^ ^
    | | |                   | | | | +--- SdrEdgeObj...
    | | |                   | | | +----- SdrMeasureObj...
    | | |                   | | +------- SdrPathObj...
    | | |                   | +--------- SdrRectObj...
    | | |                   +----------- SdrTableObj...
    | | +--- SdrObjGroup...
    | + ---- SdrPageObj...
    +------- SdrVirtObj...

The above is incomplete of course.

SdrModel / SdrView

Copied from svdview.hxx:

First of all the app creates a SdrModel. Then it opens a Win and creates a SdrView. ShowSdrPage() announces a page at SdrView. It's possible to show SdrView in any Wins at once.

SdrView can show as many Wins as it wants at once. Pages are announced or checked out with the help of ShowSdrPage()/HideSdrPage(). For every announced page there is a SdrPageView instance in container aPages. If more than one page is showed, you have to pay attention that the offset parameter of ShowSdrPage() is conformed to the size of the page (to prevent overlapping of two pages).

SdrView itself is inherited from many objects in a chain of inheritance (all that starts with SdrPaintView - that is itself inherited from few classes too):

SdrPaintView <- SdrSnapView <- SdrMarkView <- SdrEditView <- SdrPolyEditView
                                                                 ^
+----------------------------------------------------------------+
|
SdrGlueEditView <- SdrObjEditView <- SdrExchangeView <- SdrDragView
                                                                 ^
+----------------------------------------------------------------+
|
SdrCreateView <- SdrView

From SdrView on, it is not flat, but a real hierarchy again.

Drawing Layer / SdrObject(s)

See drawinglayer/README.md for general information about drawinglayer.

Below is the class diagram that comes from https://web.archive.org/web/20160827020830if_/http://www.openoffice.org:80/marketing/ooocon2006/presentations/wednesday_g11.odp slide number 6.

.------- Model --------------.      .------- View -----------------------------------------.
| SdrObject - ViewContact    | 1..* | ViewObjectContact                                    |
|              getChild()    |------|    getPrimitiveList()  -----> Object(s) ---> SdrView |
|              getVOC()      |      |    getRecPrimitiveList()      Contact                |
|              getViewInd... |      |________|_____________________________________________|
| ...ependentPrimitiveList() |               |
|____________________________|            generates
                                             |           ______
                                             V          /      |
                                   .----------------------.    |
                                   | basePrimitive        |    |
                                   |   getRange()         |<---'
                                   |   getDecomposition() |
                                   |______________________|

For SdrObjects, there are own DrawingLayer primitives in svx/source/sdr/primitive2d

The ViewContact / ViewObject / ViewObjectContact are in svx/source/sdr/contact Decomposes the SdrObjects, and does all sort of operations on them.

If the number of visualizable objects (e.g. SdrObjects) is X, and the number of SdrViews is Y, then:

  • there are X ViewContact instances (1:1 relation with a visualizable object)
  • there are Y ObjectContact instances (1:1 relation with an SdrView)
  • there are X*Y ViewObjectContact instances (1:N relation to both visualizable objects and SdrViews)