2446fdba3e
Just store the last used menu id, and consistently get all the information (command name, image id, target frame etc.) from the menu instance. Also implement the XSubToolbarController interface, so we get a chance to update the image on icon size or theme change. The initial action and icon of the button are based on the url passed by the .uno:AddDirect status update, given that there is a corresponding menu item. The only defined fallback now is to .uno:AddDirect itself for both executing and getting the icon, but this shouldn't happen normally, as I fixed all the affected cases I found so far, namely Base (including windows like table design etc.) and the Basic IDE. Actually these cases were partially broken anyway, and as a result now completely fixed: - In Base main app window, the button used to default to a new Writer document, although its tooltip advertises Ctrl+N as the kb shortcut, and pressing that shortcut actually opens the database creation wizard (as expected). - In the Basic IDE, the button was working, but not the Ctrl+N shortcut. Change-Id: I6537b3f38e7d7001ec1b39d78285445464fd8cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99514 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| qa/unit | ||
| sdi | ||
| source | ||
| uiconfig/basicide | ||
| util | ||
| AllLangMoTarget_basctl.mk | ||
| CppunitTest_basctl_dialogs_test.mk | ||
| IwyuFilter_basctl.yaml | ||
| Library_basctl.mk | ||
| Makefile | ||
| Module_basctl.mk | ||
| README | ||
| UIConfig_basicide.mk | ||
Controls and dialogs for Basic. Contains the Basic IDE.