73299faa75
while self compiled one still segfaults frequently, it is a tad better than the included one (and compiling froms source instead of using precompiled binaries is a net win in any case) Out of 50 attempts with the mergedlo.dll, the new compiled dump_syms succeeded 11 times, the shipped one succeeded 7 times - so could still be regular variance in that small sample size, but at least not significantly worse either. Change-Id: I86c213fe6aece58f1391d4c2bf9906b85eee9c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117056 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
34 lines
1.3 KiB
Groff
34 lines
1.3 KiB
Groff
diff -ur breakpad.org/src/common/windows/pdb_source_line_writer.cc breakpad/src/common/windows/pdb_source_line_writer.cc
|
|
--- breakpad.org/src/common/windows/pdb_source_line_writer.cc 2021-06-11 12:37:22.682324700 +0200
|
|
+++ breakpad/src/common/windows/pdb_source_line_writer.cc 2021-06-11 12:44:24.480184800 +0200
|
|
@@ -34,7 +34,7 @@
|
|
#include <atlbase.h>
|
|
#include <dia2.h>
|
|
#include <diacreate.h>
|
|
-#include <ImageHlp.h>
|
|
+#include <dbghelp.h>
|
|
#include <stdio.h>
|
|
|
|
#include <algorithm>
|
|
diff -ur breakpad.org/src/common/windows/pe_util.cc breakpad/src/common/windows/pe_util.cc
|
|
--- breakpad.org/src/common/windows/pe_util.cc 2021-06-11 12:37:22.682324700 +0200
|
|
+++ breakpad/src/common/windows/pe_util.cc 2021-06-11 12:52:34.542708600 +0200
|
|
@@ -35,6 +35,7 @@
|
|
#include <ImageHlp.h>
|
|
|
|
#include <functional>
|
|
+#include <memory>
|
|
|
|
#include "common/windows/string_utils-inl.h"
|
|
#include "common/windows/guid_string.h"
|
|
diff -ur breakpad.org/src/tools/windows/dump_syms/dump_syms.cc breakpad/src/tools/windows/dump_syms/dump_syms.cc
|
|
--- breakpad.org/src/tools/windows/dump_syms/dump_syms.cc 2021-06-11 12:37:20.697959400 +0200
|
|
+++ breakpad/src/tools/windows/dump_syms/dump_syms.cc 2021-06-11 12:41:16.922559700 +0200
|
|
@@ -33,6 +33,7 @@
|
|
#include <stdio.h>
|
|
#include <wchar.h>
|
|
|
|
+#include <memory>
|
|
#include <string>
|
|
|
|
#include "common/windows/pdb_source_line_writer.h"
|