office-gobmx/chart2
Caolán McNamara 8ed865ffc1 crash when one user deletes a chart another has a property dialog open for
Insert a chart, user #1 select it, user #2 select it. User #1 double click
it, double click again the legend to get dialog to edit it. User #2 delete
chart, User #1 'ok'

 #0  0x00007f5365797d59 in osl::Mutex::acquire (this=<optimized out>) at include/osl/mutex.hxx:63
 #1  osl::ClearableGuard<osl::Mutex>::ClearableGuard (t=..., this=0x7ffc7ffcccf0) at include/osl/mutex.hxx:182
 #2  apphelper::LifeTimeGuard::LifeTimeGuard (rManager=..., this=0x7ffc7ffcccf0) at chart2/source/inc/LifeTime.hxx:175
 #3  chart::ChartModel::lockControllers (this=0x0) at chart2/source/model/main/ChartModel.cxx:415
 #4  0x00007f53658375ab in chart::ControllerLockGuardUNO::ControllerLockGuardUNO (this=this@entry=0x7ffc7ffcce80, xModel=...)
     at chart2/source/tools/ControllerLockGuard.cxx:34
 #5  0x00007f5364df5f34 in chart::ChartController::executeDlg_ObjectProperties_withoutUndoGuard (this=<optimized out>, rObjectCID=..., bSuccessOnUnchanged=<optimized out>)
     at chart2/source/controller/main/ChartController_Properties.cxx:797
 #6  0x00007f5364df7a5e in chart::ChartController::executeDlg_ObjectProperties (this=0x7f535401f310, rSelectedObjectCID=...)
     at chart2/source/controller/main/ChartController_Properties.cxx:707
 #7  0x00007f5364e0f497 in chart::ChartController::execute_MouseButtonUp (this=<optimized out>, rMEvt=...) at chart2/source/controller/main/ChartController_Window.cxx:924
 #8  0x00007f53760d61dc in (anonymous namespace)::LOKPostAsyncEvent (pEv=0x55e2f1b93db0) at sfx2/source/view/lokhelper.cxx:893
 #9  0x00007f53760d0977 in LokChartHelper::postMouseEvent (this=<optimized out>, nType=1, nX=<optimized out>, nY=<optimized out>, nCount=2, nButtons=1, nModifier=0, fScaleX=0.083333333333333329,
     fScaleY=0.083333333333333329) at sfx2/source/view/lokcharthelper.cxx:294

just hold a reference to the chart the dialog operates on

Change-Id: I3b05d1fc12e4df899c1a996f1029f9d3d62e87ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-21 15:36:31 +01:00
..
inc simplify and modernise ScopedBitmapAccess 2023-12-07 09:32:14 +01:00
qa tdf#158223: chart2_uichart: Add unittest 2023-12-07 18:56:02 +01:00
source crash when one user deletes a chart another has a property dialog open for 2023-12-21 15:36:31 +01:00
uiconfig
workbench/addin
AllLangMoTarget_chart.mk
CppunitTest_chart2_common_functors.mk
CppunitTest_chart2_dialogs_test.mk
CppunitTest_chart2_dump.mk
CppunitTest_chart2_export.mk
CppunitTest_chart2_export2.mk
CppunitTest_chart2_export3.mk
CppunitTest_chart2_geometry.mk
CppunitTest_chart2_import.mk
CppunitTest_chart2_import2.mk
CppunitTest_chart2_pivot_chart_test.mk
CppunitTest_chart2_trendcalculators.mk
CppunitTest_chart2_uichart.mk
CppunitTest_chart2_xshape.mk
export_setup.mk tdf#126084 import svg image from ooxml document that use svgBlip elem. 2023-12-06 08:23:34 +01:00
import_setup.mk
IwyuFilter_chart2.yaml
JunitTest_chart2_unoapi.mk
Library_chartcontroller.mk
Library_chartcore.mk tdf#158421 use correct awt:Gradient2 in Chart lists 2023-12-11 10:29:32 +01:00
Makefile
Module_chart2.mk
README.md
UIConfig_chart2.mk

Chart Implementation for LibreOffice Calc

The chart2 denotes a second generation re-write done to rid us of the foul and twisted legacy chart code.

Debugging

Shortcuts

CTRL + F12 creates a layout dump based on the XShapeDumper based on SAL_WARN("chart2", ...