789a737ac9
There are some CrashReports in 7.6 which have
DeleteItemOnIdle on the stack, but there is nothing
reproducable. So I took a look...
I first thought it's a MCGR regression, due to classes
on the stack. But the Item involved is just random, can
happen with any Item.
Then I thought it may have to do with ITEM refactorings,
but it happens with DeleteItemOnIdle involved, so also
not the case. I already saw DeleteItemOnIdle when doing
these and qualified as 'hack' in the way. already
It is only on Windows and DeleteItemOnIdle is involved.
This again (took a deeper look now) is an old hack to
keep an SfxPoolItem 'alive' for some 'time'. For that,
it triggers an async reschedule which then deletes the
Item when being called. If the Item will be used after
that is pure coincidence - seems to work in most cases.
It seems as if for Windows the timing slightly changed
for some scenarios, so a reschedule is too early. This
can happen with this hack anytime.
DeleteItemOnIdle is used in scenarios where SfxPoolItem*
is e.g. returned, but is *not* anchored, so e.g. not
member of an SfxItemSet. Or in short: Lifetime is not
safe.
DeleteItemOnIdle exists since 1st import, but was
changed to AsyncEvent ca. 4 months ago (see
|
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| source | ||
| uiconfig/ui | ||
| util | ||
| AllLangMoTarget_cui.mk | ||
| CppunitTest_cui_dialogs_test.mk | ||
| CppunitTest_cui_dialogs_test_2.mk | ||
| CppunitTest_cui_dialogs_test_3.mk | ||
| CppunitTest_cui_dialogs_test_4.mk | ||
| IwyuFilter_cui.yaml | ||
| Library_cui.mk | ||
| Makefile | ||
| Module_cui.mk | ||
| Package_cui.mk | ||
| README.md | ||
| UIConfig_cui.mk | ||
| UITest_cui_dialogs.mk | ||
| UITest_cui_tabpages.mk | ||
Common User Interface (cui)
It was moved out from svx in DEV300m68:
http://www.mail-archive.com/dev@openoffice.org/msg12925.html
It contains dialogs used by more than one application, e.g. paragraph properties.