office-gobmx/xmlsecurity
Stephan Bergmann 7b3190eda3 boost::optional: replace uses of get_value_or with value_or
...in preparation for wholesale replacement of boost::optional with
o3tl::optional, which will be an alias for either std::optional or
boost::optional, and std::optional only has value_or.

boost::optional::value_or was added with <https://github.com/boostorg/optional/
commit/3984c9f9a157ef116cea69bc8bb20f433320eb61> "Added function value_or()",
which according to git-describe first appeared in tag boost-1.56.0.  We appear
to have no strict Boost baseline (the closest we get is with

> [AC_MSG_ERROR(boost/spirit/include/classic_core.hpp not found. install boost >= 1.36)]

in configure.ac), and at least CentOS 7 TDF machine tb76 only has
boost-devel-1.53.0-27.el7.x86_64.  However, any environment using Xcode < 10
that needs to make o3tl::optional fall back to boost::optional should use
--without-system-boost, and external/boost is currently at 1.69.0, so should be
safe.

ATTENTION:  In isolation, this commit will break in any environment that uses
Boost older than 1.56.0.  It requires the following commit introducing
o3tl::optional.  (But doing these changes in individual commits was deemed more
valuable than supporting a hypothetical future git-bisect against an old Boost.)

Change-Id: Ib31affa3eebf0d0029d8620dc6abb7a60f6c7629
Reviewed-on: https://gerrit.libreoffice.org/84127
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01 13:58:49 +01:00
..
doc
inc make some function symbols module private 2019-11-29 13:15:28 +01:00
qa Extend loplugin:external to warn about classes 2019-11-22 12:57:32 +01:00
source boost::optional: replace uses of get_value_or with value_or 2019-12-01 13:58:49 +01:00
test_docs
uiconfig/ui
util
workben
AllLangMoTarget_xsc.mk
CppunitTest_qa_certext.mk
CppunitTest_xmlsecurity_dialogs_test.mk
CppunitTest_xmlsecurity_pdfsigning.mk
CppunitTest_xmlsecurity_signing.mk
Executable_pdfverify.mk
IwyuFilter_xmlsecurity.yaml
Library_xmlsecurity.mk
Library_xsec_xmlsec.mk
Makefile
Module_xmlsecurity.mk
README
UIConfig_xmlsec.mk

Stuff for document signing.

This code provides dialogs, and infrastructure wrapping libxmlsec and gpgme that
implements document signing.