56e17186ff
Both sfx2::XmlDump and css::qa::XDumper were (only) used to dump various data from ChartModel and ChartView instances in debugging (e.g., F12 and Shift-F12 in an SW_DEBUG=1 Writer) and testing scenarios. The problem with XmlDump was that it was used as the target of a dynamic_cast from a UNO type, which is dangerous (see the upcoming commit introducing loplugin:unocast for details). One fix would have been to replace that dynamic_cast with a use of XUnoTunnel, and make ChartModel and ChartView implement that. But those classes already implement XDumper, so it looks more natural to use XDumper for that purpose too. However, the information that was obtained via XDumper was rather different from the information that was obtained via XmlDump. So make an incompatible change to the (unpublished) XDumper, adding a kind parameter distinguishing the original behavior of XDumper (kind == "shapes") from the original behavior of XmlDump (kind == ""). Change-Id: Ia7379bedfc45ab62a298fdc2f030cebaf21c4885 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144145 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> |
||
|---|---|---|
| .. | ||
| android | ||
| animations | ||
| apple_remote | ||
| avmedia | ||
| basegfx | ||
| basic | ||
| canvas | ||
| codemaker | ||
| com/sun/star/uno | ||
| comphelper | ||
| connectivity | ||
| cppcanvas | ||
| cppu | ||
| cppuhelper | ||
| cppunittester | ||
| cui | ||
| dbaccess | ||
| desktop | ||
| drawinglayer | ||
| editeng | ||
| embeddedobj | ||
| filter | ||
| formula | ||
| fpicker | ||
| framework | ||
| helpcompiler | ||
| i18nlangtag | ||
| i18npool | ||
| i18nutil | ||
| jvmaccess | ||
| jvmfwk | ||
| LibreOfficeKit | ||
| linguistic | ||
| o3tl | ||
| onlineupdate | ||
| oox | ||
| opencl | ||
| osl | ||
| package | ||
| registry | ||
| rtl | ||
| sal | ||
| salhelper | ||
| sax | ||
| sfx2 | ||
| sot | ||
| store | ||
| svl | ||
| svtools | ||
| svx | ||
| systools/win32 | ||
| test | ||
| toolkit | ||
| tools | ||
| typelib | ||
| ucbhelper | ||
| uno | ||
| unoidl | ||
| unotest | ||
| unotools | ||
| vbahelper | ||
| vcl | ||
| xmloff | ||
| xmlreader | ||
| xmlscript | ||
| default.rc | ||
| IwyuFilter_include.yaml | ||
| postmac.h | ||
| postwin.h | ||
| premac.h | ||
| prewin.h | ||
| version.hrc | ||