c9763a9f16
follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d now same actions are performed on all the dialogs Change-Id: I6531a766327dda106770a2c513ebd492dea7c655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892 Tested-by: Jenkins
212 lines
7.3 KiB
C++
212 lines
7.3 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <test/lokcallback.hxx>
|
|
|
|
#include <LibreOfficeKit/LibreOfficeKitEnums.h>
|
|
#include <rtl/strbuf.hxx>
|
|
#include <tools/gen.hxx>
|
|
#include <comphelper/lok.hxx>
|
|
#include <sfx2/viewsh.hxx>
|
|
#include <sfx2/childwin.hxx>
|
|
#include <sfx2/viewfrm.hxx>
|
|
#include <sfx2/sfxsids.hrc>
|
|
#include <sfx2/sidebar/SidebarDockingWindow.hxx>
|
|
|
|
TestLokCallbackWrapper::TestLokCallbackWrapper(LibreOfficeKitCallback callback, void* data)
|
|
: Idle("TestLokCallbackWrapper flush timer")
|
|
, m_callback(callback)
|
|
, m_data(data)
|
|
{
|
|
// Flushing timer needs to run with the lowest priority, so that all pending tasks
|
|
// such as invalidations are processed before it.
|
|
SetPriority(TaskPriority::LOWEST);
|
|
}
|
|
|
|
void TestLokCallbackWrapper::clear()
|
|
{
|
|
m_viewId = -1;
|
|
m_updatedTypes.clear();
|
|
m_updatedTypesPerViewId.clear();
|
|
}
|
|
|
|
inline void TestLokCallbackWrapper::startTimer()
|
|
{
|
|
if (!IsActive())
|
|
Start();
|
|
}
|
|
|
|
constexpr int NO_VIEWID = -1;
|
|
|
|
inline void TestLokCallbackWrapper::callCallback(int nType, const char* pPayload, int nViewId)
|
|
{
|
|
discardUpdatedTypes(nType, nViewId);
|
|
m_callback(nType, pPayload, m_data);
|
|
startTimer();
|
|
}
|
|
|
|
void TestLokCallbackWrapper::libreOfficeKitViewCallback(int nType, const rtl::OString& pPayload)
|
|
{
|
|
callCallback(nType, pPayload.getStr(), NO_VIEWID);
|
|
}
|
|
|
|
void TestLokCallbackWrapper::libreOfficeKitViewCallbackWithViewId(int nType,
|
|
const rtl::OString& pPayload,
|
|
int nViewId)
|
|
{
|
|
callCallback(nType, pPayload.getStr(), nViewId);
|
|
}
|
|
|
|
void TestLokCallbackWrapper::libreOfficeKitViewInvalidateTilesCallback(
|
|
const tools::Rectangle* pRect, int nPart, int nMode)
|
|
{
|
|
OStringBuffer buf(64);
|
|
if (pRect)
|
|
buf.append(pRect->toString());
|
|
else
|
|
buf.append("EMPTY");
|
|
if (comphelper::LibreOfficeKit::isPartInInvalidation())
|
|
{
|
|
buf.append(", " + OString::number(static_cast<sal_Int32>(nPart)) + ", "
|
|
+ OString::number(static_cast<sal_Int32>(nMode)));
|
|
}
|
|
callCallback(LOK_CALLBACK_INVALIDATE_TILES, buf.makeStringAndClear().getStr(), NO_VIEWID);
|
|
}
|
|
|
|
// TODO This is probably a pointless code duplication with CallbackFlushHandler,
|
|
// and using this in unittests also means that CallbackFlushHandler does not get
|
|
// tested as thoroughly as it could. On the other hand, this class is simpler,
|
|
// so debugging those unittests should also be simpler. The proper solution
|
|
// is presumably this class using CallbackFlushHandler internally by default,
|
|
// but having an option to use this simpler code when needed.
|
|
|
|
void TestLokCallbackWrapper::libreOfficeKitViewUpdatedCallback(int nType)
|
|
{
|
|
if (std::find(m_updatedTypes.begin(), m_updatedTypes.end(), nType) == m_updatedTypes.end())
|
|
{
|
|
m_updatedTypes.push_back(nType);
|
|
startTimer();
|
|
}
|
|
}
|
|
|
|
void TestLokCallbackWrapper::libreOfficeKitViewUpdatedCallbackPerViewId(int nType, int nViewId,
|
|
int nSourceViewId)
|
|
{
|
|
const PerViewIdData data{ nType, nViewId, nSourceViewId };
|
|
auto& l = m_updatedTypesPerViewId;
|
|
// The source view doesn't matter for uniqueness, just keep the latest one.
|
|
auto it = std::find_if(l.begin(), l.end(), [data](const PerViewIdData& other) {
|
|
return data.type == other.type && data.viewId == other.viewId;
|
|
});
|
|
if (it != l.end())
|
|
*it = data;
|
|
else
|
|
l.push_back(data);
|
|
startTimer();
|
|
}
|
|
|
|
void TestLokCallbackWrapper::libreOfficeKitViewAddPendingInvalidateTiles()
|
|
{
|
|
// Invoke() will call flushPendingLOKInvalidateTiles().
|
|
startTimer();
|
|
}
|
|
|
|
void TestLokCallbackWrapper::discardUpdatedTypes(int nType, int nViewId)
|
|
{
|
|
// If a callback is called directly with an event, drop the updated flag for it, since
|
|
// the direct event replaces it.
|
|
for (auto it = m_updatedTypes.begin(); it != m_updatedTypes.end();)
|
|
{
|
|
if (*it == nType)
|
|
it = m_updatedTypes.erase(it);
|
|
else
|
|
++it;
|
|
}
|
|
// If we do not have a specific view id, drop flag for all views.
|
|
bool allViewIds = false;
|
|
if (nViewId < 0)
|
|
allViewIds = true;
|
|
if (nType == LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR
|
|
&& !comphelper::LibreOfficeKit::isViewIdForVisCursorInvalidation())
|
|
allViewIds = true;
|
|
for (auto it = m_updatedTypesPerViewId.begin(); it != m_updatedTypesPerViewId.end();)
|
|
{
|
|
if (it->type == nType && (allViewIds || it->viewId == nViewId))
|
|
it = m_updatedTypesPerViewId.erase(it);
|
|
else
|
|
++it;
|
|
}
|
|
}
|
|
|
|
void TestLokCallbackWrapper::flushLOKData()
|
|
{
|
|
if (m_updatedTypes.empty() && m_updatedTypesPerViewId.empty())
|
|
return;
|
|
// Ask for payloads of all the pending types that need updating, and call the generic callback with that data.
|
|
assert(m_viewId >= 0);
|
|
SfxViewShell* viewShell = SfxViewShell::GetFirst(false, [this](const SfxViewShell& shell) {
|
|
return shell.GetViewShellId().get() == m_viewId;
|
|
});
|
|
assert(viewShell != nullptr);
|
|
// First move data to local structures, so that callbacks don't possibly modify it.
|
|
std::vector<int> updatedTypes;
|
|
std::swap(updatedTypes, m_updatedTypes);
|
|
std::vector<PerViewIdData> updatedTypesPerViewId;
|
|
std::swap(updatedTypesPerViewId, m_updatedTypesPerViewId);
|
|
|
|
for (int type : updatedTypes)
|
|
{
|
|
std::optional<OString> payload = viewShell->getLOKPayload(type, m_viewId);
|
|
if (payload)
|
|
libreOfficeKitViewCallback(type, *payload);
|
|
}
|
|
for (const PerViewIdData& data : updatedTypesPerViewId)
|
|
{
|
|
viewShell = SfxViewShell::GetFirst(false, [data](const SfxViewShell& shell) {
|
|
return shell.GetViewShellId().get() == data.sourceViewId;
|
|
});
|
|
assert(viewShell != nullptr);
|
|
std::optional<OString> payload = viewShell->getLOKPayload(data.type, data.viewId);
|
|
if (payload)
|
|
libreOfficeKitViewCallbackWithViewId(data.type, *payload, data.viewId);
|
|
}
|
|
}
|
|
|
|
void TestLokCallbackWrapper::Invoke()
|
|
{
|
|
// Timer timeout, flush any possibly pending data.
|
|
for (SfxViewShell* viewShell = SfxViewShell::GetFirst(false); viewShell != nullptr;
|
|
viewShell = SfxViewShell::GetNext(*viewShell, false))
|
|
{
|
|
viewShell->flushPendingLOKInvalidateTiles();
|
|
}
|
|
flushLOKData();
|
|
}
|
|
|
|
SfxChildWindow* TestLokCallbackWrapper::InitializeSidebar()
|
|
{
|
|
// in init.cxx we do setupSidebar which creates the controller, do it here
|
|
|
|
SfxViewShell* pViewShell = SfxViewShell::Current();
|
|
assert(pViewShell);
|
|
|
|
SfxViewFrame& rViewFrame = pViewShell->GetViewFrame();
|
|
rViewFrame.ShowChildWindow(SID_SIDEBAR);
|
|
SfxChildWindow* pSideBar = rViewFrame.GetChildWindow(SID_SIDEBAR);
|
|
assert(pSideBar);
|
|
|
|
auto pDockingWin = dynamic_cast<sfx2::sidebar::SidebarDockingWindow*>(pSideBar->GetWindow());
|
|
assert(pDockingWin);
|
|
|
|
pDockingWin->GetOrCreateSidebarController(); // just to create the controller
|
|
|
|
return pSideBar;
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|