52b692d16b
It is not possible to use implCreateItemEntry/implCleanupItemEntry, that is tooling limited *by purpose* to svl/Item/ItemSet stuff. But what I can do is to do that SfxPoolItemHolder I already talked/thought about. It is a helper that can safely hold a SfxPoolItem in cases where an SfxItemSet is too expensive. Think about it as a SfxItemSet for a single item. That solves the problem why DirectPutItemInPool/DirectRemoveItemFromPool is used in general (each usage is a 'compromize'). Did that now, works well. Editengine is now free of DirectPutItemInPool/DirectRemoveItemFromPool. Replaced ::CursorMoved with checkAndDeleteEmptyAttribs since all these got static with no longer need to DirectRemoveItemFromPool. Corrected create/delete counters. Change-Id: Ia6e53f48ac2e479b461546515e68697039b5b628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159931 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> |
||
---|---|---|
.. | ||
inc | ||
qa | ||
source | ||
uiconfig/ui | ||
AllLangMoTarget_editeng.mk | ||
CppunitTest_editeng_borderline.mk | ||
CppunitTest_editeng_core.mk | ||
CppunitTest_editeng_lookuptree.mk | ||
CustomTarget_generated.mk | ||
IwyuFilter_editeng.yaml | ||
Library_editeng.mk | ||
Makefile | ||
Module_editeng.mk | ||
README.md | ||
UIConfig_editeng.mk |
Edit Engine
In OpenOffice.org build DEV300m72 this module was split off from svx
but it
has no dependencies on svx
(nor on sfx2
) while in turn svx
depends on editeng
Read more in the mailing list post: http://www.mail-archive.com/dev@openoffice.org/msg13237.html
If you build LibreOffice with dbgutil
, you have some extended debug keys:
- Ctrl+Alt+F1 - draws the paragraph rectangles in different colors
- Ctrl+Alt+F11 - toggles dumping the edit engine state to the "editenginedump.log" on draw
- Ctrl+Alt+F12 - dumps the current edit engine state to "editenginedump.log"