52b692d16b
It is not possible to use implCreateItemEntry/implCleanupItemEntry, that is tooling limited *by purpose* to svl/Item/ItemSet stuff. But what I can do is to do that SfxPoolItemHolder I already talked/thought about. It is a helper that can safely hold a SfxPoolItem in cases where an SfxItemSet is too expensive. Think about it as a SfxItemSet for a single item. That solves the problem why DirectPutItemInPool/DirectRemoveItemFromPool is used in general (each usage is a 'compromize'). Did that now, works well. Editengine is now free of DirectPutItemInPool/DirectRemoveItemFromPool. Replaced ::CursorMoved with checkAndDeleteEmptyAttribs since all these got static with no longer need to DirectRemoveItemFromPool. Corrected create/delete counters. Change-Id: Ia6e53f48ac2e479b461546515e68697039b5b628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159931 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> |
||
|---|---|---|
| .. | ||
| inc/pch | ||
| qa | ||
| source | ||
| unx/source/svdde | ||
| util | ||
| AllLangMoTarget_svl.mk | ||
| CppunitTest_svl_adrparse.mk | ||
| CppunitTest_svl_inetcontenttype.mk | ||
| CppunitTest_svl_itempool.mk | ||
| CppunitTest_svl_items.mk | ||
| CppunitTest_svl_lngmisc.mk | ||
| CppunitTest_svl_lockfiles.mk | ||
| CppunitTest_svl_notify.mk | ||
| CppunitTest_svl_qa_cppunit.mk | ||
| CppunitTest_svl_urihelper.mk | ||
| IwyuFilter_svl.yaml | ||
| JunitTest_svl_complex.mk | ||
| Library_fsstorage.mk | ||
| Library_passwordcontainer.mk | ||
| Library_svl.mk | ||
| Makefile | ||
| Module_svl.mk | ||
| README.md | ||
Non-Graphical Helper Code (svtools light)
Contains non-graphical helper code for office applications.
Specifically this module does not depend on or use includes from module vcl. Originally all code in svtools that did not depend on vcl was split off into this svl ("svtools light") module.
In particular the SfxItemSet is a property-bag like container that
stores arbitrary sets of properties for everything from text run
formats, to Chart regression line properties.
There are lots of other useful helpers in here for various office
tasks; much of this code was originally moved from svx/sfx2.
Items, Pools and Sets
SfxPoolItem
A small reference counted piece of data. Many subclasses, each with a
unique integer to identify its type (WhichId). Can be compared for equality
(operator==), Clone()d, and converted to/from uno::Any (QueryValue/PutValue).
A pool item may have value semantics ("poolable"), meaning that
there will generally be only one instance that compares equal per item pool,
or not, in which case the item will be Clone()d quite a bit.
SfxItemPool
Usually there is one item pool per document, with a range of valid WhichIds
that is specific to the type of document.
The item pool owns all instances of SfxPoolItem or its subclasses that have
ever been added to an item set. It also contains a default item for
every WhichId, which will be (depending on parameters) returned from item
sets if the set does not contain an item at this WhichId.
SfxItemSet
The item set can be created with a user-supplied range of WhichIds; it
will accept SfxPoolItems with matching WhichIds and ignore attempts to
insert items with non-matching WhichIds.
Items that are successfully inserted into the set will be stored in the
set's SfxItemPool, and for poolable items only a single instance that
compares equal under the predicate operator== will be stored in the pool,
regardless of how many sets contain it, thus conserving memory.
There are members m_pWhichRanges for the valid ranges (as pairs of WhichIds),
m_nCount for the number of items contained, and m_pItems for the pointers to
the actual items.