Test repository to check push and ssh key
Find a file
Stephan Bergmann 5926b22b5d The SystemEnvData passed into the canvas factories appears to be unused
It was passed in as aArg[1] ever since d551190e83
"INTEGRATION: CWS canvas05", but I can't find any current use of that specific
argument in canvas/source/ (assuming that all the factories are implemented
there), nor can I find any trace in the git history of it ever havig been used.

That means that Window::GetSystemDataAny is unused now and can be removed.

Change-Id: I16efe548afb5cc3e0606cffea135f7e6674d5def
Reviewed-on: https://gerrit.libreoffice.org/80295
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05 18:31:20 +02:00
.git-hooks
.github
accessibility loplugin:virtualdead in vcl 2019-09-26 20:13:30 +02:00
android
animations
apple_remote
avmedia loplugin:stringconstant (clang-cl) 2019-10-01 13:19:04 +02:00
basctl loplugin:singlevalfields 2019-10-04 08:53:37 +02:00
basegfx loplugin:virtualdead in basegfx 2019-09-28 17:56:57 +02:00
basic loplugin:data (clang-cl) 2019-10-01 13:20:30 +02:00
bean
bin bin/find-most-common-warn-messages.py: Switch to python3 2019-10-05 02:08:08 +02:00
binaryurp
bridges always use gb_LinkTarget__get_cxxflags for cxxobjects 2019-10-04 08:57:29 +02:00
canvas The SystemEnvData passed into the canvas factories appears to be unused 2019-10-05 18:31:20 +02:00
chart2 use SfxUInt16Item for SID_ATTR_TRANSFORM_SIZE_POINT 2019-10-05 08:16:34 +02:00
cli_ure
codemaker loplugin:stringadd in basctl..cui 2019-10-01 09:22:23 +02:00
comphelper Implement parallel version of super-scalar-sample-sort... 2019-10-01 18:11:36 +02:00
compilerplugins loplugin:unusedfields 2019-10-04 14:22:55 +02:00
config_host drop gtk2 support 2019-09-30 16:53:32 +02:00
configmgr Add conversion from rtl::OStringNumber to std::string_view 2019-09-27 23:41:23 +02:00
connectivity loplugin:redundantcast (clang-cl) 2019-10-01 16:51:08 +02:00
cppcanvas
cppu loplugin:stringadd in basctl..cui 2019-10-01 09:22:23 +02:00
cppuhelper add property name when throwing css::uno::UnknownPropertyException 2019-09-26 18:32:25 +02:00
cpputools
cui tdf#127935 Make double click expand/collapse entry in option tree 2019-10-05 16:16:48 +02:00
dbaccess don't need button.hxx here 2019-10-05 16:13:22 +02:00
desktop Related: tdf#127529 make it harder to misunderstand this VirtualDevice ctor 2019-10-04 20:38:00 +02:00
dictionaries@e2f020e6e2
distro-configs Use --with-sytem-cairo for the ASan+UBSan tinderbox again 2019-10-01 23:02:37 +02:00
drawinglayer
dtrans loplugin:stringconstant (clang-cl) 2019-10-01 13:19:04 +02:00
editeng Drop bogus memset 2019-10-05 07:59:31 +02:00
embeddedobj loplugin:logexceptionnicely (clang-cl) 2019-10-01 23:03:19 +02:00
embedserv -Werror,-Wmicrosoft-exception-spec (clang-cl) 2019-10-02 08:18:57 +02:00
emfio ofz#17817 avoid OOM 2019-09-30 14:33:52 +02:00
eventattacher
extensions drop some unnecessary includes 2019-10-04 20:39:17 +02:00
external Resolves: tdf#127887 Fix libwps wrong Lotus version detection 2019-10-02 11:23:03 +02:00
extras SvtFileView not referenced in any .uis anymore 2019-10-04 21:15:20 +02:00
filter ofz#17448 avoid OOM 2019-10-05 15:17:26 +02:00
forms loplugin:constmethod in forms..fpicker 2019-09-26 03:04:34 +02:00
formula drop some unnecessary includes 2019-10-03 09:55:21 +02:00
fpicker move file picker only code to fpicker 2019-10-05 16:06:59 +02:00
framework loplugin:unusedmethods 2019-10-03 16:34:31 +02:00
helpcompiler loplugin:stringadd in helpcompiler..oox 2019-10-01 08:26:49 +02:00
helpcontent2@259b7b03dc Update git submodules 2019-10-04 15:23:16 +02:00
hwpfilter ofz#17823 avoid timeout 2019-10-04 22:18:09 +02:00
i18nlangtag loplugin:stringadd in helpcompiler..oox 2019-10-01 08:26:49 +02:00
i18npool
i18nutil Drop bogus memset 2019-10-05 13:21:30 +02:00
icon-themes
idl
idlc loplugin:data (clang-cl) 2019-10-01 13:20:30 +02:00
include The SystemEnvData passed into the canvas factories appears to be unused 2019-10-05 18:31:20 +02:00
instsetoo_native tdf#127711 - A runtime-switch for the MiniCrashDump 2019-10-02 09:43:12 +02:00
io loplugin:stringadd in helpcompiler..oox 2019-10-01 08:26:49 +02:00
ios
javaunohelper
jurt
jvmaccess
jvmfwk loplugin:stringadd in helpcompiler..oox 2019-10-01 08:26:49 +02:00
l10ntools pocheck: also preserve header in check for function names 2019-10-02 23:36:51 +02:00
librelogo
libreofficekit enable -Wunused-exception-parameter on clang 2019-10-04 14:23:17 +02:00
lingucomponent loplugin:stringadd in helpcompiler..oox 2019-10-01 08:26:49 +02:00
linguistic loplugin:stringadd in helpcompiler..oox 2019-10-01 08:26:49 +02:00
lotuswordpro ofz#17675 loop in lwp filter 2019-10-04 22:19:50 +02:00
m4
nlpsolver
o3tl
odk
offapi
officecfg
onlineupdate drop gtk2 support 2019-09-30 16:53:32 +02:00
oovbaapi
oox Deduplicate some serializer writing code, and simplify writing OString 2019-10-04 12:40:06 +02:00
opencl
osx
package loplugin:stringadd in package..sax 2019-10-01 10:51:39 +02:00
pch add gbuild function for a common PCH and use it in sc/ and sax/ 2019-10-04 08:59:34 +02:00
postprocess
pyuno
qadevOOo
readlicense_oo
registry tdf#127766: Avoid ODR violation for class/struct FieldEntry 2019-10-03 17:35:37 +02:00
remotebridges
reportbuilder
reportdesign Convert various RPTUI_ID_* to SfxUInt16Item 2019-10-05 09:10:41 +02:00
ridljar
sal loplugin:data (clang-cl) 2019-10-01 13:20:30 +02:00
salhelper
sax Deduplicate some serializer writing code, and simplify writing OString 2019-10-04 12:40:06 +02:00
sc Convert various FID_VALID_* to SfxUInt16Item 2019-10-05 09:10:58 +02:00
scaddins add gbuild function for a common PCH and use it in sc/ and sax/ 2019-10-04 08:59:34 +02:00
sccomp loplugin:constmethod in sc 2019-09-26 10:15:00 +02:00
schema sw anchored object allow overlap: replace TODO with OASIS proposal 2019-10-03 09:01:46 +02:00
scp2 tdf#127711 - A runtime-switch for the MiniCrashDump 2019-10-02 09:43:12 +02:00
scripting loplugin:stringadd in sc 2019-10-01 08:26:52 +02:00
sd Convert some SID in sd to SfxUInt16Item 2019-10-05 13:16:19 +02:00
sdext drop some unnecessary includes 2019-10-03 11:10:58 +02:00
setup_native
sfx2 simplify SfxAllEnumItem 2019-10-05 14:06:33 +02:00
shell -Werror,-Wmicrosoft-exception-spec (clang-cl) 2019-10-02 08:18:57 +02:00
slideshow loplugin:constmethod in sdext..starmath 2019-09-28 13:47:28 +02:00
smoketest
solenv move file picker only code to fpicker 2019-10-05 16:06:59 +02:00
soltools
sot loplugin:stringadd n sfx2..svl 2019-10-01 10:46:15 +02:00
starmath drop some unnecessary includes 2019-10-03 09:53:11 +02:00
stoc
store
svgio loplugin:unusedfields 2019-10-03 12:16:38 +02:00
svl simplify SfxAllEnumItem 2019-10-05 14:06:33 +02:00
svtools move file picker only code to fpicker 2019-10-05 16:06:59 +02:00
svx use SfxUInt16Item for SID_ATTR_TRANSFORM_SIZE_POINT 2019-10-05 08:16:34 +02:00
sw Drop bogus memset 2019-10-05 07:59:50 +02:00
swext
sysui
test
testtools
toolkit find-unneeded-includes: ignore extra recommendations 2019-10-04 09:08:49 +02:00
tools always use gb_LinkTarget__get_cxxflags for cxxobjects 2019-10-04 08:57:29 +02:00
translations@c1894cfe4c Update git submodules 2019-10-02 23:40:07 +02:00
ucb loplugin:stringadd in tools..unotools 2019-10-02 08:01:38 +02:00
ucbhelper add property name when throwing css::uno::UnknownPropertyException 2019-09-26 18:32:25 +02:00
udkapi
uitest Revert "uitest: make child soffice process die when parent dies" 2019-10-04 12:44:27 +02:00
UnoControls loplugin:duplicate-defines in UnoControls 2019-09-30 13:12:43 +02:00
unodevtools
unoidl Deduplicate O(U)StringNumber definitions; add toAsciiUpperCase 2019-09-27 15:03:41 +02:00
unoil
unotest WTF "WTF 255 return value?" 2019-10-02 15:24:39 +02:00
unotools loplugin:stringadd in tools..unotools 2019-10-02 08:01:38 +02:00
unoxml loplugin:constmethod in ucb..uui 2019-09-28 11:30:49 +02:00
ure
uui loplugin:constmethod in ucb..uui 2019-09-28 11:30:49 +02:00
vbahelper new loplugin:stringadd 2019-10-02 11:22:27 +02:00
vcl The SystemEnvData passed into the canvas factories appears to be unused 2019-10-05 18:31:20 +02:00
winaccessibility -Werror,-Wmicrosoft-exception-spec (clang-cl) 2019-10-02 08:18:57 +02:00
wizards tdf#50846 - Wrong type of function GetLastUsedRow 2019-09-27 20:26:35 +02:00
writerfilter ofz#17992 null deref 2019-10-04 22:18:19 +02:00
writerperfect On Windows, Library_wpftwriter indirectly references Bcrypt.lib 2019-10-02 11:25:35 +02:00
xmerge
xmlhelp constmethod for accessor-type methods 2019-09-29 12:43:37 +02:00
xmloff xmloff: create XMLDrawMetaExportOOO instances with an uno constructor 2019-10-04 09:07:13 +02:00
xmlreader
xmlscript loplugin:stringadd in writerfilter..xmloff 2019-10-02 08:47:24 +02:00
xmlsecurity loplugin:stringconstant (clang-cl) 2019-10-01 13:19:04 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitreview
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in tdf#127711 - A runtime-switch for the MiniCrashDump 2019-10-02 09:43:12 +02:00
config_host_lang.mk.in
configure.ac tdf#127711 - A runtime-switch for the MiniCrashDump 2019-10-02 09:43:12 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst
g
hardened_runtime.xcent
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.md
README.Solaris
Repository.mk drop gtk2 support 2019-09-30 16:53:32 +02:00
RepositoryExternal.mk gbuild: treat $(DCONF_CFLAGS) as includes, not defines 2019-10-01 07:44:10 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk add "system" PCH that contains often used system headers such as STL 2019-10-04 08:58:52 +02:00
sanitize-ubsan-blacklist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2017 version 15.7
  • macOS:
    • Runtime: 10.10
    • Build: 10.13.2 + Xcode 9.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.