Test repository to check push and ssh key
Find a file
Ashod Nakashian 593bf02c8b sd: LOK: avoid caching pointers and leaking
Change-Id: I68163bc30b0655b11dec34bdcc750b495b93365a
Reviewed-on: https://gerrit.libreoffice.org/68265
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit da70e56208)
Reviewed-on: https://gerrit.libreoffice.org/76284
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25 12:04:41 +02:00
.git-hooks
accessibility cid#1448398 Dereference before null check 2019-07-23 09:33:28 +02:00
android
animations
apple_remote
avmedia avmedia: Drop 'wrap_*' functions 2019-07-22 17:40:50 +02:00
basctl "Basic macros" instead of "$Productname Basic macros" 2019-07-24 12:27:37 +02:00
basegfx loplugin:referencecasting in avmedia..basic 2019-07-19 12:22:43 +02:00
basic Fix typos 2019-07-24 23:34:49 +02:00
bean
bin tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
binaryurp
bridges
canvas loplugin:referencecasting in canvas..chart2 2019-07-19 11:31:51 +02:00
chart2 tdf#114166 DOCX chart import: fix missing complex categories 2019-07-24 14:04:06 +02:00
cli_ure
codemaker
comphelper Don't draw gridlines and document background in Online server process 2019-07-23 15:54:48 +02:00
compilerplugins loplugin:unusedfields 2019-07-24 15:36:24 +02:00
config_host tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
configmgr tdf#42949 Fix IWYU warnings in configmgr/* 2019-07-17 13:58:57 +02:00
connectivity cid#1448360 Assignment of overlapping memory 2019-07-24 22:21:32 +02:00
cppcanvas rhbz#1728763 black bg seen in renderer emfs 2019-07-23 17:16:38 +02:00
cppu
cppuhelper loplugin:referencecasting in cppcanvas..cui 2019-07-19 11:47:47 +02:00
cpputools
cui QRCode Dialog Box feature 2019-07-25 07:15:10 +02:00
dbaccess "Basic macros" instead of "$Productname Basic macros" 2019-07-24 12:27:37 +02:00
desktop LOK: remove duplicate cursor invalidations for same view only 2019-07-25 12:01:50 +02:00
dictionaries@86b4b5bfbf
distro-configs tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
drawinglayer cid#1448352 silence Arguments in wrong order 2019-07-16 09:32:25 +02:00
dtrans Fix typo 2019-07-24 16:40:36 +02:00
editeng cid#1451637 silence Dereference after null check 2019-07-24 13:09:22 +02:00
embeddedobj loplugin:referencecasting in embeddedobj 2019-07-19 21:49:20 +02:00
embedserv
emfio
eventattacher
extensions weld GridWindow 2019-07-25 09:27:48 +02:00
external external: update pdfium to 3849 2019-07-17 09:12:47 +02:00
extras weld GridWindow 2019-07-25 09:27:48 +02:00
filter cid#1448519 Untrusted loop bound 2019-07-24 17:04:04 +02:00
forms loplugin:referencecasting in forms..fpicker 2019-07-19 18:29:34 +02:00
formula
fpicker loplugin:referencecasting in forms..fpicker 2019-07-19 18:29:34 +02:00
framework loplugin:unusedfields 2019-07-24 15:36:24 +02:00
helpcompiler cid#1448495 Unchecked return value 2019-07-19 09:43:02 +02:00
helpcontent2@68d866ef1b Update git submodules 2019-07-16 00:51:15 +02:00
hwpfilter
i18nlangtag It's Classical Armenian, not Classic [xcl-AM] 2019-07-18 20:42:20 +02:00
i18npool
i18nutil
icon-themes Add Redaction toolbar icons from colibre to tango 2019-07-25 11:51:27 +02:00
idl cid#1448323 Unchecked return value 2019-07-18 21:15:24 +02:00
idlc cid#1448213 Assignment of overlapping memory 2019-07-24 17:44:29 +02:00
include tdf#119228 Add storage and serialisation for the Resolved flag 2019-07-25 10:38:36 +02:00
instsetoo_native
io
ios
javaunohelper Fix typos 2019-07-20 04:17:41 +02:00
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit
lingucomponent loplugin:referencecasting in various 2019-07-21 16:04:20 +02:00
linguistic loplugin:referencecasting in linguistic 2019-07-20 07:55:53 +02:00
lotuswordpro Fix typos 2019-07-25 07:07:25 +02:00
m4
nlpsolver
o3tl
odk Fix typo 'a SDK' 2019-07-24 11:53:09 +02:00
offapi Fix typo in code 2019-07-25 10:08:29 +02:00
officecfg "Basic macros" instead of "$Productname Basic macros" 2019-07-24 12:27:37 +02:00
onlineupdate Fix typos 2019-07-23 22:19:26 +02:00
oovbaapi
oox tdf#114166 DOCX chart import: fix missing complex categories 2019-07-24 14:04:06 +02:00
opencl Fix typos 2019-07-23 22:19:26 +02:00
osx
package Fix typos 2019-07-23 22:19:26 +02:00
postprocess tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
pyuno loplugin:referencecasting in oox..pyuno 2019-07-20 07:56:19 +02:00
qadevOOo Fix typos 2019-07-24 23:34:49 +02:00
readlicense_oo
registry close some more holes in structures 2019-07-23 06:46:41 +02:00
remotebridges
reportbuilder Fix typos 2019-07-25 07:07:25 +02:00
reportdesign dispose() methods should clear their smart pointers 2019-07-23 06:46:13 +02:00
ridljar
sal Fix typo 2019-07-24 23:36:21 +02:00
salhelper
sax cid#1448394 can't change xml_parse_config setting 2019-07-24 17:37:22 +02:00
sc tdf#107394 sc ui: fix lack of row height update on undo of paste 2019-07-25 09:21:13 +02:00
scaddins Fix typos 2019-07-24 23:34:49 +02:00
sccomp
schema tdf#119228 Add storage and serialisation for the Resolved flag 2019-07-25 10:38:36 +02:00
scp2 tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
scripting cid#1448376 SIC: Inner class could be made static 2019-07-23 09:34:53 +02:00
sd sd: LOK: avoid caching pointers and leaking 2019-07-25 12:04:41 +02:00
sdext Fix typos 2019-07-24 23:34:49 +02:00
setup_native
sfx2 sd: sidebars are now visible in LOOL 2019-07-25 09:29:47 +02:00
shell Simplify Sequence iterations in shell..svgio 2019-07-22 18:42:35 +02:00
slideshow Simplify Sequence iterations in shell..svgio 2019-07-22 18:42:35 +02:00
smoketest
solenv xmloff: create XMLImportStylesImportOasis instances with an uno constructor 2019-07-25 09:21:20 +02:00
soltools cid#1448523 silence bogus Out-of-bounds read 2019-07-24 17:20:04 +02:00
sot Simplify Sequence iterations in shell..svgio 2019-07-22 18:42:35 +02:00
starmath Optimize names transforming 2019-07-23 23:32:46 +02:00
stoc Simplify Sequence iterations in shell..svgio 2019-07-22 18:42:35 +02:00
store
svgio Simplify Sequence iterations in shell..svgio 2019-07-22 18:42:35 +02:00
svl loplugin:referencecasting in slideshow..svtools 2019-07-21 08:49:01 +02:00
svtools cid#1448414 silence Explicit null dereferenced 2019-07-25 09:27:00 +02:00
svx QRCode Dialog Box feature 2019-07-25 07:15:10 +02:00
sw tdf#119228 Add storage and serialisation for the Resolved flag 2019-07-25 10:38:36 +02:00
swext
sysui tdf#125693: On macOS, create empty LibreOffice.app/Contents/Resources/en.lproj 2019-07-17 08:10:00 +02:00
test tdf#42949 Fix IWYU warnings in include/test 2019-07-23 14:16:09 +02:00
testtools
toolkit loplugin:referencecasting in test..toolkit 2019-07-21 08:49:13 +02:00
tools cid#1448224 Unchecked return value 2019-07-18 21:16:52 +02:00
translations@a6f6a9d0e6 Update git submodules 2019-07-17 17:02:29 +02:00
ucb dispose() methods should clear their smart pointers 2019-07-23 06:46:13 +02:00
ucbhelper
udkapi
uitest
UnoControls loplugin:referencecasting in various 2019-07-21 16:04:20 +02:00
unodevtools
unoidl cid#1448548 Assignment of overlapping memory 2019-07-24 17:04:24 +02:00
unoil
unotest loplugin:referencecasting in unotools..uui 2019-07-21 08:49:56 +02:00
unotools Fix typos 2019-07-25 07:07:25 +02:00
unoxml loplugin:referencecasting in unotools..uui 2019-07-21 08:49:56 +02:00
ure
uui loplugin:referencecasting in unotools..uui 2019-07-21 08:49:56 +02:00
vbahelper tdf#42949 Fix IWYU warnings in include/vbahelper 2019-07-22 10:24:33 +02:00
vcl tdf#124042: Remove unnecessary code for iOS 2019-07-25 09:57:11 +02:00
winaccessibility
wizards cid#1448373 UC: Useless code 2019-07-23 09:33:48 +02:00
writerfilter tdf#123627 DOCX import: fix relative hyperlinks to documents 2019-07-25 09:31:34 +02:00
writerperfect Fix typo 2019-07-21 08:28:37 +02:00
xmerge Fix typos 2019-07-24 23:34:49 +02:00
xmlhelp loplugin:referencecasting in writerfilter..xmlhelp 2019-07-21 08:50:50 +02:00
xmloff tdf#119228 Add storage and serialisation for the Resolved flag 2019-07-25 10:38:36 +02:00
xmlreader
xmlscript loplugin:referencecasting in various 2019-07-21 16:04:20 +02:00
xmlsecurity Fix typos 2019-07-25 07:07:25 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.gitattributes
.gitignore
.gitmodules
.gitreview
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
config_host_lang.mk.in
configure.ac Accept also iOS SDK 12.4 2019-07-24 13:40:49 +03:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst tdf#126079 update Source Serif font to 3.0 2019-07-17 13:02:50 +02:00
g
hardened_runtime.xcent
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.md
README.Solaris
Repository.mk tdf#125922 rename kde5 to kf5 + plasma5 2019-07-21 23:22:46 +02:00
RepositoryExternal.mk QRCode Dialog Box feature 2019-07-25 07:15:10 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-blacklist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2017
  • macOS:
    • Runtime: 10.10
    • Build: 10.13.2 + Xcode 9.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.