71fed56e4a
The "which" utility is not guaranteed to be installed either, and if it is, its behavior is not portable either. This means that when various programs are installed, the `which` check will report a fatal error because the which tool did not exist and the shell returned a nonzero status when attempting to fork+exec. If it did exist, it might not be an implementation of `which` that returns nonzero when commands do not exist. The general scripting suggestion is to use the "command -v" shell builtin; this is required to exist in all POSIX 2008 compliant shells, and is thus guaranteed to work everywhere. For some in-depth discussions on the topic, see: - https://mywiki.wooledge.org/BashFAQ/081 - https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250 Examples of open-source shells likely to be installed as /bin/sh on Linux, which implement the 15-year-old standard: ash, bash, busybox, dash, ksh, mksh and zsh. This commit updates the build system to configure and build correctly on systems without `which`. Change-Id: I23dbde5c7f104dd610fd5f78c82bf9a7d0cc1930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160663 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
71 lines
2.7 KiB
Bash
Executable file
71 lines
2.7 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
#
|
|
# This file is part of the LibreOffice project.
|
|
#
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
#
|
|
#
|
|
|
|
EXECUTABLE=${1}
|
|
COREDIR=${2}
|
|
EXITCODE=${3}
|
|
|
|
if command -v gdb >/dev/null
|
|
then
|
|
found=
|
|
for COREFILE in "$COREDIR"/core*
|
|
do
|
|
if [ -f "$COREFILE" ]
|
|
then
|
|
guess=$(file "$COREFILE")
|
|
guess=${guess#* execfn: \'}
|
|
guess=${guess%%\'*}
|
|
if [ ! -x "$guess" ]; then guess=$EXECUTABLE; fi
|
|
printf '\nIt looks like %s generated %s\nBacktraces:\n' \
|
|
"$guess" "$COREFILE"
|
|
GDBCOMMANDFILE=$(mktemp)
|
|
printf "info registers\nthread apply all backtrace full\n" \
|
|
>"$GDBCOMMANDFILE"
|
|
PYTHONWARNINGS=default gdb -iex "add-auto-load-safe-path ${INSTDIR?}" \
|
|
-x "$GDBCOMMANDFILE" --batch "$guess" "$COREFILE" && found=x
|
|
rm "$GDBCOMMANDFILE"
|
|
echo
|
|
fi
|
|
done
|
|
if test -n "$WITH_COREDUMPCTL"; then
|
|
# Unfortunately `coredumpctl debug` only operates on the most recent core dump matching any
|
|
# given criteria, not on all core dumps matching those criteria; so get the PIDs of all core
|
|
# dumps matching the given COREDUMP_USER_UNIT (and for which a core dump is still present)
|
|
# first, and then iterate over them (though this introduces possibilities for some,
|
|
# hopefully unlikely and mostly harmless, races, like when core dumps disappear in between,
|
|
# or multiple matching core dumps have identical PIDs):
|
|
for i in $($COREDUMPCTL --json=short list COREDUMP_USER_UNIT="$LIBO_TEST_UNIT".scope | \
|
|
$JQ -r 'map(select(.corefile=="present"))|map(.pid)|join(" ")')
|
|
do
|
|
GDBCOMMANDFILE=$(mktemp)
|
|
printf 'info registers\nthread apply all backtrace full\n' >"$GDBCOMMANDFILE"
|
|
PYTHONWARNINGS=default $COREDUMPCTL debug \
|
|
COREDUMP_USER_UNIT="$LIBO_TEST_UNIT".scope COREDUMP_PID="$i" \
|
|
--debugger-arguments="-iex 'add-auto-load-safe-path ${INSTDIR?}' \
|
|
-x '$GDBCOMMANDFILE' --batch"
|
|
rm "$GDBCOMMANDFILE"
|
|
found=x
|
|
done
|
|
fi
|
|
if [ -z "$found" -a "$EXITCODE" -ge 128 ]; then
|
|
echo
|
|
echo "No core file identified in directory ${COREDIR}"
|
|
echo "To show backtraces for crashes during test execution,"
|
|
echo "enable core files with:"
|
|
echo
|
|
echo " ulimit -c unlimited"
|
|
echo
|
|
exit 1
|
|
fi
|
|
else
|
|
echo "You need gdb in your path to show backtraces"
|
|
exit 1
|
|
fi
|