Test repository to check push and ssh key
Find a file
Michael Stahl 632cc05073 sw: fix AppendRedline() creating empty redlines for Outside
This happens on tdf#133967 bugdoc with the Delete/Delete case first, in
line 1445 - the start positions are equal, so the new redline is empty
=> DocumentRedlineManager.cxx:92: redline table corrupted: empty redline

Similar bugs exist for Delete/Insert case in line 1725 and Format/? case
in line 1892, the latter even checks a nonsensical condition
*pEnd != *pRStt that is always true for Outside case.

It's like that since inital CVS import.

Change-Id: I7ade25380a5a43b14e87db37da8fc84267e89dd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99389
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-27 11:14:40 +02:00
.git-hooks
.github
accessibility
android
animations
apple_remote
avmedia
basctl move getUIRootDir to AllSettings 2020-07-25 17:23:48 +02:00
basegfx basegfx: remove completly useless namespace opening and closing 2020-07-26 22:16:13 +02:00
basic Use comphelper::IsContextFlagActive for flags from comphelper::NewFlagContext 2020-07-25 17:29:23 +02:00
bean
bin Fix escaped sequences in regular expressions 2020-07-24 11:07:09 +02:00
binaryurp
bridges
canvas tdf#135078: let vclcanvas::SpriteCanvas implement css::lang::XServiceInfo 2020-07-24 10:46:27 +02:00
chart2 merge duplicate GetFocus implementations 2020-07-22 20:48:24 +02:00
cli_ure
codemaker
comphelper loplugin:unusedmethods 2020-07-25 08:57:13 +02:00
compilerplugins loplugin:constantparam 2020-07-25 10:38:59 +02:00
config_host Revert "configure: add a --with-product-flavor switch" 2020-07-21 13:24:16 +02:00
configmgr configmgr: Use a proper LanguageTag-based locale fallback mechanism. 2020-07-23 10:40:27 +02:00
connectivity connectivity/odbc: create instances with uno constructors 2020-07-23 11:56:22 +02:00
cppcanvas
cppu
cppuhelper Remove no longer relevant assert 2020-07-23 19:49:49 +02:00
cpputools
cui tdf#118148 Add extended tips to optuserpage.ui 2020-07-26 12:59:57 +02:00
dbaccess move getUIRootDir to AllSettings 2020-07-25 17:23:48 +02:00
desktop allow to .uno:Save a PDF doc - divert to SaveAs to the doc. file 2020-07-27 07:12:05 +02:00
dictionaries@8cd579e3a6 Update git submodules 2020-07-22 16:01:45 +02:00
distro-configs
drawinglayer limit bitmap size for glow/softedge effects to visible area (tdf#134237) 2020-07-20 12:40:17 +02:00
dtrans dtrans/dnd: create instances with uno constructors 2020-07-24 13:25:45 +02:00
editeng move getUIRootDir to AllSettings 2020-07-25 17:23:48 +02:00
embeddedobj embeddedobj/msole: create instances with uno constructors 2020-07-22 17:48:12 +02:00
embedserv
emfio
eventattacher
extensions extensions/WinUserInfo: create instances with uno constructors 2020-07-27 08:30:40 +02:00
external Name of python.bin-gdb.py must match name of python.bin executable 2020-07-24 15:28:54 +02:00
extras tdf#87605 Add some new terms 2020-07-25 09:37:48 +02:00
filter filter/xsltdialog: create instances with uno constructors 2020-07-25 17:39:26 +02:00
forms weld AbsolutePos 2020-07-23 20:45:17 +02:00
formula
fpicker fpicker/win32: create instances with uno constructors 2020-07-26 22:15:12 +02:00
framework move getUIRootDir to AllSettings 2020-07-25 17:23:48 +02:00
helpcompiler
helpcontent2@09c3906689 Update git submodules 2020-07-26 12:59:08 +02:00
hwpfilter
i18nlangtag
i18npool tdf#132082 Fix a crash in LOKit (Japanese-only) 2020-07-23 13:46:23 +02:00
i18nutil
icon-themes Remove tagline from brand image and splash screen 2020-07-21 16:00:14 +02:00
idl
idlc
include sc: create instances with uno constructors 2020-07-26 13:41:59 +02:00
instsetoo_native tdf#134522 remove --with-build-version ./configure flag 2020-07-23 10:51:30 +02:00
io
ios tdf#134832: Also run the BitmapTest from vcl 2020-07-22 10:38:22 +03:00
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit We apparently need to call Application::Quit() on iOS now 2020-07-20 13:14:46 +02:00
lingucomponent this should be a single-instance component 2020-07-20 22:00:09 +02:00
linguistic fix SAL_WARN when instantiating Thesaurus 2020-07-20 17:28:33 +02:00
lotuswordpro
m4
nlpsolver
o3tl
odk Remove obsolete dynamic exception specifications from SDK example C++ code 2020-07-22 15:13:24 +02:00
offapi
officecfg lok-freezepanes: Generalize FreezePanes* uno-commands... 2020-07-24 15:19:40 +02:00
onlineupdate
oovbaapi
oox oox: remove commented code block 2020-07-25 00:35:08 +02:00
opencl
osx
package package/xstor: create instances with uno constructors 2020-07-26 10:41:17 +02:00
pch
postprocess
pyuno
qadevOOo xmloff: remove dead com.sun.star.comp.Impress.XMLContentExporter 2020-07-24 09:03:22 +02:00
readlicense_oo
registry compact namespace decl 2020-07-20 10:12:57 +02:00
remotebridges
reportbuilder
reportdesign move getUIRootDir to AllSettings 2020-07-25 17:23:48 +02:00
ridljar
sal Improved oplugin:staticanonymous -> redundantstatic redux, macOS 2020-07-21 09:19:33 +02:00
salhelper
sax
sc tdf#134769: sc_subsequent_export_test: Add unittest 2020-07-26 22:11:27 +02:00
scaddins don't need prefix here anymore 2020-07-25 16:29:34 +02:00
sccomp
schema
scp2
scripting
sd sd: create instances with uno constructors 2020-07-26 17:10:24 +02:00
sdext loplugin:unnecessaryvirtual 2020-07-20 23:03:43 +02:00
setup_native
sfx2 starmath: create instances with uno constructors 2020-07-26 10:41:52 +02:00
shell shell/wininet: create instances with uno constructors 2020-07-23 08:52:27 +02:00
slideshow Deprecated std::result_of has been removed from C++20 2020-07-21 22:50:32 +02:00
smoketest
solenv sw: create instances with uno constructors 2020-07-26 18:42:52 +02:00
soltools
sot
starmath starmath: create instances with uno constructors 2020-07-26 10:41:52 +02:00
stoc Use comphelper::IsContextFlagActive for flags from comphelper::NewFlagContext 2020-07-25 17:29:23 +02:00
store
svgio compact namespace: svgio 2020-07-20 08:42:57 +02:00
svl
svtools don't grab focus if Field Properties panel is actively being resized 2020-07-24 15:08:20 +02:00
svx move getUIRootDir to AllSettings 2020-07-25 17:23:48 +02:00
sw sw: fix AppendRedline() creating empty redlines for Outside 2020-07-27 11:14:40 +02:00
swext
sysui Revert "tdf#132787: Don't duplicate hicolor icon theme as gnome" 2020-07-26 19:02:05 +02:00
test
testtools
toolkit cid#1465510 Dereference null return value 2020-07-25 15:01:41 +02:00
tools Fix uses of char16_t*/wchar_t* stream inserters 2020-07-21 21:32:10 +02:00
translations@d602d2af8c
ucb ucb/gio: create instances with uno constructors 2020-07-23 10:24:38 +02:00
ucbhelper
udkapi
uitest
UnoControls
unodevtools Silence GCC 11 trunk -Werror=nonnull involving dynamic_cast 2020-07-23 07:53:20 +02:00
unoidl
unoil
unotest
unotools
unoxml
ure
uui compact namespace decl 2020-07-20 10:12:57 +02:00
vbahelper
vcl tdf#135077 Qt5 revert broken fix for tdf#132172 2020-07-27 08:12:56 +02:00
winaccessibility
wizards
writerfilter tdf#134648 DOCX import: fix bottom auto margin of subitem 2020-07-21 11:01:12 +02:00
writerperfect compact namespace: writerperfect 2020-07-20 08:42:29 +02:00
xmerge
xmlhelp
xmloff sc: create instances with uno constructors 2020-07-26 13:41:59 +02:00
xmlreader
xmlscript
xmlsecurity xmlsecurity: detect unsigned incremental update between signatures 2020-07-24 13:47:08 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in tdf#134522 remove --with-build-version ./configure flag 2020-07-23 10:51:30 +02:00
config_host_lang.mk.in
configure.ac tdf#134522 remove --with-build-version ./configure flag 2020-07-23 10:51:30 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst external: update pdfium to 4203 2020-07-22 10:40:57 +02:00
g
hardened_runtime.xcent.in
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.4
  • macOS:
    • Runtime: 10.10
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.