office-gobmx/shell
Stephan Bergmann 4521cb0c40 Drop redundant -Wnon-virtual-dtor
Inspired by
<https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607102.html> "[PATCH]
doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor", drop explicitly
enabling -Wnon-virtual-dtor in favor of -Wdelete-non-virtual-dtor, which is
already enabled by -Wall.

(-Wdelete-non-virtual-dtor first appeared in Clang 3.0,
<8bd428574c>
"Add new warning that warns when invoking 'delete' on a polymorphic, non-final,
class without a virtual destructor", and GCC 4.7,
<https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=014ab419efc12a59efebd2720d79e1c055675c85>
"invoke.texi: Document -Wdelete-non-virtual-dtor. [...]")

Dropping the explicit setting of -Wnon-virtual-dtor (and nowhere setting it
implicitly via -Weffc++) means we can get rid of lots of places that either set
-Wno-non-virtual-dtor or use some pragma to ignore -Wnon-virtual-dtor.

(In various places across extensions/source/activex/ and winaccessibility/, the
commits f26996bd33 "Silence
-Werror,-Wnon-virtual-dtor in generated so_activex.h (clang-cl)" and
c6086ca653 "Silence -Werror,-Wnon-virtual-dtor in
generated UAccCOM.h (clang-cl)" had singled out some includes to wrap them in
pragmas.  Now that those pragmas are gone again, move those includes back to
where they had been prior to being singled out.  And the -Wno-non-virtual-dtor
in external/firebird/macos-arm64.patch.0 appeared first in
ccd0e5f445 "Make firebird build for macOS on
arm64", which, though it doesn't state it explicitly, apparently created that
patch's builds/posix/prefix.darwin_arm64 as a copy of firebird's already
existing builds/posix/prefix.* files, which routinely include that warning
option too, so keep it there too even if it is probably irrelevant throughout.)

Change-Id: I7e4fa9f2c07e267b2ed15607905027f6b78142f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143182
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-24 10:38:28 +01:00
..
inc
qa/zip
source
AllLangMoTarget_shell.mk
CppunitTest_shell_zip.mk
CustomTarget_shlxthdl_res.mk
CustomTarget_spsupp_idl.mk
CustomTarget_x64.mk
Executable_lngconvex.mk
Executable_regsvrex.mk
Executable_senddoc.mk
Executable_spsupp_helper.mk
Executable_uri_encode.mk
IwyuFilter_shell.yaml
Library_cmdmail.mk
Library_desktopbe.mk
Library_jumplist.mk
Library_kf5be.mk
Library_localebe.mk
Library_losessioninstall.mk
Library_macbe.mk
Library_ooofilt.mk
Library_ooofilt_x64.mk
Library_propertyhdl.mk
Library_propertyhdl_x64.mk
Library_shlxthdl.mk
Library_shlxthdl_x64.mk
Library_smplmail.mk
Library_spsupp_x64.mk
Library_spsupp_x86.mk
Library_syssh.mk
Library_wininetbe.mk
Makefile
Module_shell.mk
Package_senddoc.mk
README.md
StaticLibrary_shlxthandler_common.mk
StaticLibrary_shlxthandler_common_x64.mk
StaticLibrary_xmlparser.mk
StaticLibrary_xmlparser_x64.mk
WinResTarget_shlxthdl.mk
WinResTarget_spsupp.mk
WinResTarget_spsupp_dlg.mk

System Helpers

Launching URI, system integration, external mailer support etc.