e57d5daaea
Specifically in sd/source/core/annotations/Annotation.cxx We seem to end up fixing leaks here often. The current tools::JsonWriter API is just very hard to use correctly. So rather return an OString, which is cheap to copy, and push that down into the LOK code. AFAIK that seems to end up requiring less code and less adhoc copying of data (specifically the queueing code in init.cxx was creating copies when converting to std::string). Ideally, we could have some special API to avoid the new strdup() calls in init.cxx, but not sure how to prevent other people from accidentally using that. Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
51 lines
1.4 KiB
C++
51 lines
1.4 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
*/
|
|
|
|
#ifndef INCLUDED_VCL_IDIALOGRENDERABLE_HXX
|
|
#define INCLUDED_VCL_IDIALOGRENDERABLE_HXX
|
|
|
|
#include <config_options.h>
|
|
#include <vcl/dllapi.h>
|
|
#include <rtl/ustring.hxx>
|
|
|
|
#include <vector>
|
|
|
|
namespace tools { class Rectangle; }
|
|
|
|
class SfxItemSet;
|
|
|
|
namespace vcl
|
|
{
|
|
|
|
typedef std::pair<const OString, const OString> LOKPayloadItem;
|
|
|
|
typedef sal_uInt32 LOKWindowId;
|
|
|
|
class VCL_DLLPUBLIC ILibreOfficeKitNotifier
|
|
{
|
|
public:
|
|
virtual ~ILibreOfficeKitNotifier();
|
|
|
|
/// Callbacks
|
|
virtual void notifyWindow(vcl::LOKWindowId nLOKWindowId,
|
|
const OUString& rAction,
|
|
const std::vector<LOKPayloadItem>& rPayload = std::vector<LOKPayloadItem>()) const = 0;
|
|
|
|
virtual void libreOfficeKitViewCallback(int nType, const OString& pPayload) const = 0;
|
|
|
|
/// Emits a LOK_CALLBACK_INVALIDATE_TILES.
|
|
virtual void notifyInvalidation(tools::Rectangle const *) const = 0;
|
|
};
|
|
|
|
} // namespace vcl
|
|
|
|
#endif // INCLUDED_VCL_IDIALOGRENDERABLE_HXX
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|