Test repository to check push and ssh key
Find a file
Xisco Fauli 6b4d1e003c tdf#163486 sw: PVS: identical sub-expressions
Since
commit 47889e229c
Author: Thomas Lange <tl@openoffice.org>
Date:   Mon Sep 28 10:46:54 2009 +0000

    158766 avoid duplicating symbols in the catalog

V501 	There are identical sub-expressions to the left and to the right of the '==' operator: aSymSetName == aSymSetName

Change-Id: If204238eb0fca958e075ebb2ff4f3ad13a55630f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175332
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21 17:01:17 +02:00
.configurations Fix typo 2024-10-11 14:01:05 +02:00
.git-hooks
.github
.vscode
accessibility tdf#163486: PVS: identical conditional expressions 2024-10-17 21:00:01 +02:00
android android-viewer translated using Weblate 2024-10-15 17:03:07 +02:00
animations
apple_remote
avmedia Silence -Werror,-Wdeprecated-declarations (macOS 15.0) 2024-09-30 12:07:21 +02:00
basctl tdf#163486: PVS: Identical branches 2024-10-19 19:49:40 +02:00
basegfx
basic Resolves tdf#163515 - Basic Macro Organizer: After renaming a 2024-10-21 14:09:32 +02:00
bean
bin find-unneeded-includes: add option to detect IWYU failures 2024-10-18 08:30:41 +02:00
binaryurp
bridges
canvas vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
chart2 tdf#163486: PVS: Two similar code fragments were found 2024-10-21 15:32:17 +02:00
cli_ure
codemaker cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
comphelper tdf#158237 comphelper: Use C++20 contains() instead of find() and end() 2024-10-18 10:02:51 +02:00
compilerplugins
config_host Make --disable-emscripten-proxy-to-pthread configurable 2024-10-10 14:39:24 +02:00
configmgr cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
connectivity tdf#163486: PVS: Identical branches 2024-10-18 10:27:06 +02:00
cppcanvas tdf#163410: fix missing text highlight color for outline text 2024-10-13 20:39:24 +02:00
cppu
cppuhelper tdf#163486: PVS: recurring check 2024-10-18 08:49:15 +02:00
cpputools cid#1555171 Data race condition 2024-10-17 20:25:15 +02:00
cui vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
dbaccess tdf#163486: PVS: fix copy&paste error 2024-10-20 16:14:47 +02:00
desktop cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
dictionaries@d0c939181a Update git submodules 2024-10-20 19:23:00 +02:00
distro-configs
docmodel
drawinglayer vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
editeng Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
embeddedobj Avoid deadlock 2024-10-18 11:14:16 +02:00
embedserv
emfio Use good old string literals in assertXPath and friends 2024-10-05 10:06:44 +02:00
eventattacher
extensions
external ofz#372757014 png_fp_sub Integer-overflow 2024-10-14 09:26:57 +02:00
extras tdf#87605: Add new words to technical dictionary. 2024-10-20 07:09:19 +02:00
filter tdf#163486: PVS: duplicated items 2024-10-21 14:10:59 +02:00
forms Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
formula
fpicker
framework tdf#163486: PVS: Remove forgotten else block 2024-10-21 01:22:49 +02:00
helpcompiler
helpcontent2@b1d8f7ad81 Update git submodules 2024-10-21 10:39:30 +02:00
hwpfilter tdf#163486: PVS: redundant nullptr check 2024-10-18 08:50:31 +02:00
i18nlangtag Add Santali, Ol Chiki {sat-Olck-IN} [0x06B3] to language list 2024-10-14 18:36:38 +02:00
i18npool Move {sat-IN} locale data to {sat-Olck-IN}, tdf#154987 follow-up 2024-10-14 21:58:27 +02:00
i18nutil tdf#163215: Enable kashida justification for AAT fonts 2024-10-18 21:49:03 +02:00
icon-themes
idl
idlc/test/parser
include drop StyleSheetCreated 2024-10-21 16:25:33 +02:00
instsetoo_native Emscripten: For executables, only build .js files, not .html files 2024-10-10 10:21:42 +02:00
io cid#1608473 Data race condition 2024-10-17 14:37:49 +02:00
ios
javaunohelper
jurt
jvmaccess
jvmfwk cid#1606631 Overflowed constant 2024-10-04 20:30:43 +02:00
l10ntools Add Santali, Ol Chiki {sat-Olck-IN} [0x06B3] to language list 2024-10-14 18:36:38 +02:00
librelogo
libreofficekit
lingucomponent Optimize a bit: only create std::locale once in parseDudenResponse 2024-10-17 09:12:54 +02:00
linguistic
lotuswordpro cid#1608255 silence Overflowed constant 2024-10-21 12:33:48 +02:00
m4
msicreator
net_ure
nlpsolver
o3tl Use good old string literals in assertXPath and friends 2024-10-05 10:06:44 +02:00
odk Drop extra quoting 2024-10-16 15:18:59 +02:00
offapi set master slide name at creation time 2024-10-21 15:48:24 +02:00
officecfg tdf#151941: Show Alt_Shift_P as shortcut key for Page Style 2024-10-21 13:37:29 +02:00
oovbaapi
oox vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
opencl
osx
package loplugin:unusedfields 2024-10-16 15:51:52 +02:00
pch
postprocess
pyuno tdf#163190: [pyuno] SyntaxWarning: invalid escape sequence '\P' 2024-09-29 20:17:13 +02:00
qadevOOo
readlicense_oo
registry version COVERITY conditionals 2024-10-14 13:07:37 +02:00
remotebridges
reportbuilder
reportdesign use more concrete UNO types in reportdesign 2024-10-01 19:34:46 +02:00
ridljar
sal extract NaN payload test from single unit test 2024-10-17 11:46:34 +02:00
salhelper
sax cid#1632259 COPY_INSTEAD_OF_MOVE 2024-10-08 13:16:08 +02:00
sc tdf#163486 sw: PVS: identical sub-expressions 2024-10-21 16:43:10 +02:00
scaddins cid#1608078 Overflowed return value 2024-10-10 07:46:59 +02:00
sccomp Fix typo 2024-10-09 22:41:42 +02:00
schema
scp2 tdf#163170 Add support for MS Visio Template format with .vstx extension 2024-09-29 10:04:37 +02:00
scripting cid#1556166 Data race condition 2024-10-03 18:44:28 +02:00
sd set master slide name at creation time 2024-10-21 15:48:24 +02:00
sdext cid#1633260 COPY_INSTEAD_OF_MOVE 2024-10-19 14:49:55 +02:00
setup_native
sfx2 sfx2: check mpViewShell in another place 2024-10-21 15:27:02 +02:00
shell
slideshow tdf#163486: PVS: The variable was assign the same value. 2024-10-20 10:31:03 +02:00
smoketest
solenv SW: extract transform charts (using dialog code) 2024-10-18 12:49:41 +02:00
soltools
sot
starmath tdf#163486 sw: PVS: identical sub-expressions 2024-10-21 17:01:17 +02:00
static
stoc cid#1607010 Data race condition 2024-10-05 08:57:34 +02:00
store cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
svgio vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
svl drop StyleSheetCreated 2024-10-21 16:25:33 +02:00
svtools Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
svx tdf#145161: Change image compression dialog string 2024-10-21 16:39:54 +02:00
sw drop StyleSheetCreated 2024-10-21 16:25:33 +02:00
swext
sysui
test Document LIBO_TEST_DEFAULT_DESKTOP environment variable 2024-10-21 10:48:29 +02:00
testtools cid#1608417 silence deliberate documented Infinite loop 2024-10-06 15:30:51 +02:00
toolkit tdf#163486: PVS: fix copy&paste error 2024-10-20 16:15:52 +02:00
tools Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
translations@d5e786eb56 Update git submodules 2024-10-04 17:06:42 +02:00
ucb tdf#163486: PVS: The variable was assign the same value. 2024-10-20 10:28:20 +02:00
ucbhelper loplugin:unusedmethods 2024-10-16 15:52:02 +02:00
udkapi
uitest Document LIBO_TEST_DEFAULT_DESKTOP environment variable 2024-10-21 10:48:29 +02:00
UnoControls
unodevtools
unoidl cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
unoil
unotest
unotools Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
unoxml unoxml: port testXProcessingInstruction from java to c++ 2024-10-15 17:37:33 +02:00
ure
uui
vbahelper
vcl tdf#163484 Treeview not maximized in the StyleList 2024-10-21 16:57:18 +02:00
winaccessibility Fix typo 2024-10-19 15:52:43 +02:00
wizards scriptforge.pyi - Fix typo 2024-10-18 13:38:18 +02:00
writerperfect fix(lok): Expose the character encoding dialog 2024-10-21 10:34:18 +02:00
xmerge
xmlhelp
xmloff only set parent style name if necessary 2024-10-21 15:49:38 +02:00
xmlreader
xmlscript Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
xmlsecurity Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
.vsconfig winget configuration files for installing Visual Studio Community 2022 2024-10-10 23:49:19 +02:00
antivirusDetection.vbs
autogen.sh wsl-as-helper: fix paths to module/Makefile in builddir!=srcdir case 2024-10-14 19:48:15 +02:00
BUCK
config.guess
config.sub
config_host.mk.in Make --disable-emscripten-proxy-to-pthread configurable 2024-10-10 14:39:24 +02:00
config_host_lang.mk.in
configure.ac configure.ac: Drop bashism 2024-10-17 11:40:37 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint sw: drop DECLARE_FODFEXPORT_TEST macro 2024-10-16 15:28:13 +02:00
download.lst Update pdfium to 6764 2024-10-14 08:11:10 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md README: mention PVS-Studio 2024-10-18 14:31:08 +02:00
README.Solaris
Repository.mk
RepositoryExternal.mk don't need to use dlsym for cairo_surface_set_device_scale... 2024-10-17 17:49:07 +02:00
RepositoryFixes.mk Emscripten: For executables, only build .js files, not .html files 2024-10-10 10:21:42 +02:00
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.

SAST Tools

PVS-Studio - static analyzer for C, C++, C#, and Java code.