Stephan Bergmann 16e3b84d2e Improve loplugin:dyncastvisibility to check for non-inline key functions ... This would have caught the issue discussed in 709b1f3ddb "Make sure VCLXPopupMenu has unique RTTI". (The commit message talks about RTTI there, while what Clang actually compared for an optimized implementation of a dynamic_cast to a final class is vtable pointers, but the overall picture remains the same. Both RTTI and vtables are emitted along the key function, and if that is missing or inline, they are emitted for each dynamic library individually, and as internal symbols on macOS.) This commit also addresses all the issues found by the improved loplugin:dyncastvisibility on Linux. See the newly added TODO in compilerplugins/clang/dyncastvisibility.cxx and 86b86ac87e "Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function" for an issue with key functions for class template instantiations. Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins		2024-11-14 12:49:22 +01:00
..
basmgr	no need to take a copy of the getProcessComponentContext return value	2024-11-08 15:23:52 +01:00
classes	clang-tidy: performance-unnecessary-copy-initialization in basic	2024-11-11 15:46:52 +01:00
comp	loplugin:passstuffbyref in basic	2024-11-06 15:45:14 +01:00
inc	loplugin:passstuffbyref in basic	2024-11-06 15:45:14 +01:00
runtime	no need to take a copy of the getProcessComponentContext return value	2024-11-08 15:23:52 +01:00
sbx	Improve loplugin:dyncastvisibility to check for non-inline key functions	2024-11-14 12:49:22 +01:00
uno	no need to take a copy of the getProcessComponentContext return value	2024-11-08 15:23:52 +01:00