6fa4e5965b
This patch fixes the following issue when pressing F1 while hovering on a menu entry that has submenus: 1) Place the mouse over a menu entry that has submenus (f.i. in Draw go to Format - Table) 2) A submenu will appear, however leave the mouse over "Table" 3) Press F1... the help ID used will be "slot:0" because LO is trying to find the help ID of the selected entry in the submenu, but since none is selected, then the generic "slot:0" value is used. To fix this problem, this patch assigns a Help ID for the submenu (not for its entries) so that when no entry is focused, then the submenu HID is used. IMPORTANT: note that pressing F1 on menus only work with gen and win. Due to bug 156376 pressing F1 on menus does not work with kf5 and gtk3 (yet). Change-Id: I717e7669faac47a12c929129c0de98dee7f44439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154862 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
118 lines
4.2 KiB
C++
118 lines
4.2 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#include "menuwindow.hxx"
|
|
#include "menuitemlist.hxx"
|
|
|
|
#include <vcl/help.hxx>
|
|
#include <vcl/menu.hxx>
|
|
#include <vcl/settings.hxx>
|
|
#include <vcl/svapp.hxx>
|
|
#include <vcl/window.hxx>
|
|
|
|
static sal_uLong ImplChangeTipTimeout( sal_uLong nTimeout, vcl::Window *pWindow )
|
|
{
|
|
AllSettings aAllSettings( pWindow->GetSettings() );
|
|
HelpSettings aHelpSettings( aAllSettings.GetHelpSettings() );
|
|
sal_uLong nRet = aHelpSettings.GetTipTimeout();
|
|
aHelpSettings.SetTipTimeout( nTimeout );
|
|
aAllSettings.SetHelpSettings( aHelpSettings );
|
|
pWindow->GetOutDev()->SetSettings( aAllSettings );
|
|
return nRet;
|
|
}
|
|
|
|
bool MenuWindow::ImplHandleHelpEvent(vcl::Window* pMenuWindow, Menu const * pMenu, sal_uInt16 nHighlightedItem,
|
|
const HelpEvent& rHEvt, const tools::Rectangle &rHighlightRect)
|
|
{
|
|
if( ! pMenu )
|
|
return false;
|
|
|
|
bool bDone = false;
|
|
sal_uInt16 nId = 0;
|
|
|
|
if ( nHighlightedItem != ITEMPOS_INVALID )
|
|
{
|
|
MenuItemData* pItemData = pMenu->GetItemList()->GetDataFromPos( nHighlightedItem );
|
|
if ( pItemData )
|
|
nId = pItemData->nId;
|
|
}
|
|
|
|
if ( ( rHEvt.GetMode() & HelpEventMode::BALLOON ) && pMenuWindow )
|
|
{
|
|
Point aPos;
|
|
if( rHEvt.KeyboardActivated() )
|
|
aPos = rHighlightRect.Center();
|
|
else
|
|
aPos = rHEvt.GetMousePosPixel();
|
|
|
|
tools::Rectangle aRect( aPos, Size() );
|
|
if (!pMenu->GetHelpText(nId).isEmpty())
|
|
Help::ShowBalloon( pMenuWindow, aPos, aRect, pMenu->GetHelpText( nId ) );
|
|
else
|
|
{
|
|
// give user a chance to read the full filename
|
|
sal_uLong oldTimeout=ImplChangeTipTimeout( 60000, pMenuWindow );
|
|
// call always, even when strlen==0 to correctly remove tip
|
|
Help::ShowQuickHelp( pMenuWindow, aRect, pMenu->GetTipHelpText( nId ) );
|
|
ImplChangeTipTimeout( oldTimeout, pMenuWindow );
|
|
}
|
|
bDone = true;
|
|
}
|
|
else if ( ( rHEvt.GetMode() &HelpEventMode::QUICK ) && pMenuWindow )
|
|
{
|
|
Point aPos = rHEvt.GetMousePosPixel();
|
|
tools::Rectangle aRect( aPos, Size() );
|
|
// give user a chance to read the full filename
|
|
sal_uLong oldTimeout=ImplChangeTipTimeout( 60000, pMenuWindow );
|
|
// call always, even when strlen==0 to correctly remove tip
|
|
Help::ShowQuickHelp( pMenuWindow, aRect, pMenu->GetTipHelpText( nId ) );
|
|
ImplChangeTipTimeout( oldTimeout, pMenuWindow );
|
|
bDone = true;
|
|
}
|
|
else if ( rHEvt.GetMode() & HelpEventMode::CONTEXT )
|
|
{
|
|
// is help in the application selected
|
|
Help* pHelp = Application::GetHelp();
|
|
if ( pHelp )
|
|
{
|
|
// Check if there is a Help ID available, or else use
|
|
// the command URL
|
|
OUString aCommand = pMenu->GetItemCommand( nId );
|
|
OUString aHelpId;
|
|
|
|
// If no entry is selected, use the general menu Help ID
|
|
if (nId <= 0)
|
|
aHelpId = pMenu->GetHelpId();
|
|
else
|
|
aHelpId = pMenu->GetHelpId(nId);
|
|
|
|
if( aHelpId.isEmpty() )
|
|
aHelpId = OOO_HELP_INDEX;
|
|
|
|
if ( !aHelpId.isEmpty() )
|
|
pHelp->Start(aHelpId);
|
|
else
|
|
pHelp->Start(aCommand);
|
|
}
|
|
bDone = true;
|
|
}
|
|
return bDone;
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|